Android: How to save to Pictures folder

[NalleParticipant]

Hello everyone,

How in Monkey2 the Pictures folder of Android systems can be retrieved?

I’m currently using path “sdcard/Pictures/”, but this probably isn’t the best way to do it.

I would like to have the pictures to be visible with computer too, so that it would be easy to transfer the files from Android device to computer.

The way I’m currently done it, the user has to copy or move first the file on Android device, which makes it visible to a computer too.

[nerobotParticipant]

Hi. There is the function  GetSpecialDir:String( name:String ) but it understand only “internal” and “external” params for android,

but you can extend it by changing this file

/monkey2/modules/std/filesystem/native/Monkey2FileSystem.java

add one more else  branch:

Monkey

if( name.equals( "internal" ) ){ f=Monkey2Activity.instance().getFilesDir(); }else if( name.equals( "external" ) ){ f=Monkey2Activity.instance().getExternalFilesDir( null ); }else if( name.equals( "pictures" ) ){ f=Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_PICTURES ); }

1 2 3 4 5 6 7

if( name.equals( "internal" ) ){    f=Monkey2Activity.instance().getFilesDir(); }else if( name.equals( "external" ) ){    f=Monkey2Activity.instance().getExternalFilesDir( null ); }else if( name.equals( "pictures" ) ){    f=Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_PICTURES ); }

and rebuild std module for android target.

[nerobotParticipant]

I will test and add realisation for all external dirs.

[NalleParticipant]

With my new Samsung Galaxy A6+ saving to Pictures folder doesn’t work. I checked SavePixmap state from the debugger, it was false and nothing was saved. Has anyone else tried this?

[Mark SiblyKeymaster]

It may be a permissions issue, try something like this…

RequestPermissions( New String[][(“android.permission.WRITE_EXTERNAL_STORAGE”),Lambda( results:UInt[] )

End )

I have no idea if this is the correct permission to ask for though, more here:

https://developer.android.com/reference/android/Manifest.permission

[NalleParticipant]

As default there is in the Android Manifest this permission: WRITE_EXTERNAL_STORAGE

I also thought, that could it be permissions issue, because ..Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_PICTURES ) is the correct way to get the Pictures folder.

[GwenelParticipant]

if setting it to targetSdkVersion 21 works fine, then we have the same problem. working on it

[GwenelParticipant]

this seem to be what has changed to increase the security in Android filesystem, i dont have any pacakaged solution yet as i dont have much time before Christmas. But it might give an idea to ppl.

https://developer.android.com/reference/android/support/v4/content/FileProvider

[NalleParticipant]

From Android version 6 (API >= 23) one must ask at run-time permission for example to Pictures folder.

This was my first try to do Android coding inside the Android Studio and I came up with this not working skeleton, that is based on Google’s example code:

Java

else if( name.equals( "pictures" ) ){ if (ContextCompat.checkSelfPermission(Monkey2Activity.instance(), Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) { // Permission is not granted // Should we show an explanation? if (ActivityCompat.shouldShowRequestPermissionRationale(Monkey2Activity.instance(), Manifest.permission.READ_EXTERNAL_STORAGE)) { // Show an explanation to the user *asynchronously* -- don't block // this thread waiting for the user's response! After the user // sees the explanation, try again to request the permission. } else { // No explanation needed; request the permission ActivityCompat.requestPermissions(Monkey2Activity.instance(), new String[]{Manifest.permission.READ_EXTERNAL_STORAGE}, MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE); // MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE is an // app-defined int constant. The callback method gets the // result of the request. } } else { // Permission has already been granted f = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES); }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27

else if( name.equals( "pictures" ) ){   if (ContextCompat.checkSelfPermission(Monkey2Activity.instance(), Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {   // Permission is not granted // Should we show an explanation? if (ActivityCompat.shouldShowRequestPermissionRationale(Monkey2Activity.instance(), Manifest.permission.READ_EXTERNAL_STORAGE)) { // Show an explanation to the user *asynchronously* -- don't block // this thread waiting for the user's response! After the user // sees the explanation, try again to request the permission. } else { // No explanation needed; request the permission ActivityCompat.requestPermissions(Monkey2Activity.instance(), new String[]{Manifest.permission.READ_EXTERNAL_STORAGE}, MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE);   // MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE is an // app-defined int constant. The callback method gets the // result of the request. } } else { // Permission has already been granted f = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES); }

Edit: Also this in addition:

Java

public void onRequestPermissionsResult(int requestCode, String permissions[], int[] grantResults) { switch (requestCode) { case MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE: { // If request is cancelled, the result arrays are empty. if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) { // permission was granted, yay! Do the // READ_EXTERNAL_STORAGE-related task you need to do. } else { // permission denied, boo! Disable the // functionality that depends on this permission. } return; } // other 'case' lines to check for other // permissions this app might request. } }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20

public void onRequestPermissionsResult(int requestCode,    String permissions[], int[] grantResults) { switch (requestCode) { case MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE: { // If request is cancelled, the result arrays are empty. if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) { // permission was granted, yay! Do the // READ_EXTERNAL_STORAGE-related task you need to do. } else { // permission denied, boo! Disable the // functionality that depends on this permission. } return; }   // other 'case' lines to check for other // permissions this app might request. } }

 

Has anyone a working solution?

Working solution should ask the user, if the user agrees to app’s writing to external storage.

edit: Link to original code: https://developer.android.com/training/permissions/requesting#java

[NalleParticipant]

I made a new code, this little code (needs some improvement) seems to work.

It prompts the user (system feature) if the app may write to external storage, after permission, when the permission is granted, the picture is saved to Pictures folder!

Java

if( name.equals( "internal" ) ){ f=Monkey2Activity.instance().getFilesDir(); }else if( name.equals( "external" ) ){ f=Monkey2Activity.instance().getExternalFilesDir( null ); }else if( name.equals( "pictures" ) ){ String[] permissions = {Manifest.permission.WRITE_EXTERNAL_STORAGE}; com.monkey2.lib.Monkey2Permissions.requestPermissions(permissions, WRITE_REQUEST_CODE); f= Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_PICTURES ); } if( f!=null ) return f.getAbsolutePath()+"/"; return ""; } public static String onRequestPermissionsResult(int requestCode, String permissions[], int[] grantResults) { switch (requestCode) { case WRITE_REQUEST_CODE: { // If request is cancelled, the result arrays are empty. if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) { // permission was granted, yay! Do the // read external storage-related task you need to do. return Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_PICTURES ).getAbsolutePath()+"/"; } else { // permission denied, boo! Disable the // functionality that depends on this permission. return "NO_PERMISSION"; } } // other 'case' lines to check for other // permissions this app might request. } return null; }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39

if( name.equals( "internal" ) ){      f=Monkey2Activity.instance().getFilesDir();     }else if( name.equals( "external" ) ){      f=Monkey2Activity.instance().getExternalFilesDir( null );     }else if( name.equals( "pictures" ) ){               String[] permissions = {Manifest.permission.WRITE_EXTERNAL_STORAGE};             com.monkey2.lib.Monkey2Permissions.requestPermissions(permissions, WRITE_REQUEST_CODE);      f= Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_PICTURES ); }   if( f!=null ) return f.getAbsolutePath()+"/";          return "";     }       public static String onRequestPermissionsResult(int requestCode,                                            String permissions[], int[] grantResults) {         switch (requestCode) {             case WRITE_REQUEST_CODE: {                 // If request is cancelled, the result arrays are empty.                 if (grantResults.length > 0                         && grantResults[0] == PackageManager.PERMISSION_GRANTED) {                     // permission was granted, yay! Do the                     // read external storage-related task you need to do.                     return Environment.getExternalStoragePublicDirectory( Environment.DIRECTORY_PICTURES ).getAbsolutePath()+"/";                 } else {                     // permission denied, boo! Disable the                     // functionality that depends on this permission.                     return "NO_PERMISSION";                 }             }               // other 'case' lines to check for other             // permissions this app might request.         }         return null;     }

We should add proper code to Monkey2 modules to get more Android features like Camera.

[NalleParticipant]

I found this old thread: http://monkeycoder.co.nz/forums/topic/android-permissions/

The permissions can be asked simply in nice Monkey2 code.

Though, I had at first problem with the following line:

RequestPermissions(permissions,Lambda( results:Int[] )

Error : Can’t find overload for ‘RequestPermissions’ with argument types (monkey.types.String[],Void(monkey.types.Int[]))

If it is changed to: RequestPermissions( permissions,Lambda( results:ResultType[] ) it can be compiled.

[Author]

Posts