Bug: Full Screen at the start

[therevillsParticipant]

When I execute the following code in Windows the screen isnt centered in full screen mode, if I press alt-enter to enter window mode it ends full screen and displays the window in the middle of the screen and then full screen is okay:

Monkey

[crayon-5cba15ab05cc1202403875 inline="true" ] Namespace myapp #Import "<std>" #Import "<mojo>" Using std.. Using mojo.. Const Size:=New Vec2i( 512,480 ) Class MyWindow Extends Window Method New() Super.New( "My Window",1027,768,WindowFlags.Resizable ) Layout="letterbox" BeginFullscreen() End Method OnRender( canvas:Canvas ) Override App.RequestRender() ClearColor = Color.Black canvas.DrawText( "Hello World",Width/2,Height/2,.5,.5 ) End Method OnKeyEvent( event:KeyEvent ) Override If event.Type=EventType.KeyDown And event.Key=Key.Enter And event.Modifiers & Modifier.Alt Fullscreen=Not Fullscreen Endif End Method OnMeasure:Vec2i() Override Return Size End End Function Main() New AppInstance New MyWindow App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55

[crayon-5cba15ab05cc1202403875 inline="true" ] Namespace myapp   #Import "<std>" #Import "<mojo>"   Using std.. Using mojo..   Const Size:=New Vec2i( 512,480 )   Class MyWindow Extends Window   Method New() Super.New( "My Window",1027,768,WindowFlags.Resizable ) Layout="letterbox" BeginFullscreen() End   Method OnRender( canvas:Canvas ) Override App.RequestRender() ClearColor = Color.Black canvas.DrawText( "Hello World",Width/2,Height/2,.5,.5 ) End Method OnKeyEvent( event:KeyEvent ) Override If event.Type=EventType.KeyDown And event.Key=Key.Enter And event.Modifiers & Modifier.Alt Fullscreen=Not Fullscreen Endif End Method OnMeasure:Vec2i() Override Return Size End End   Function Main()   New AppInstance New MyWindow App.Run() End

[/crayon]

[DruggedBunnyParticipant]

Confirmed same here — 1.1.0.7 itch.io version.

Screenshot shows uncleared grey area, too, which goes away when windowed/re-fullscreened.

Attachments:

1. 

   noncentered.jpg
   

[nerobotParticipant]

I suppose it’s incorrect to set screen mode inside of constuctor.

Better way to do it when window done with layout.

Monkey

Method New() Super.New( "My Window",1027,768,WindowFlags.Resizable ) Layout="letterbox" End Method OnRender( canvas:Canvas ) Override App.RequestRender() Global justStarted:=True If justStarted justStarted=False BeginFullscreen() 'Return 'maybe better to skip this frame? Endif ClearColor = Color.Black canvas.DrawText( "Hello World",Width/2,Height/2,.5,.5 ) End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21

Method New() Super.New( "My Window",1027,768,WindowFlags.Resizable )   Layout="letterbox" End   Method OnRender( canvas:Canvas ) Override   App.RequestRender()   Global justStarted:=True If justStarted justStarted=False BeginFullscreen() 'Return 'maybe better to skip this frame? Endif   ClearColor = Color.Black canvas.DrawText( "Hello World",Width/2,Height/2,.5,.5 )   End

[Mark SiblyKeymaster]

Hmm, seems like it should work to me and could be an SDL thing. Will have a look.

[Mark SiblyKeymaster]

I think it’s an SDL/windows thing. This fixes it for me:

Monkey

App.Idle+=Lambda() BeginFullscreen() End

1 2 3 4

App.Idle+=Lambda()    BeginFullscreen() End

(Note: you should be able to just go ‘App.Idle+=BeginFullscreen’ but that doesn’t work right now due to a bug I just fixed!)

This effectively delays the call to BeginFullscreen until the next ‘batch’ of OS events has been processed. I’m not 100% sure why this necessary but I will keep looking.Worse case, I can just implement this ‘delay’ actually inside BeginFullscreen.

[therevillsParticipant]

@nerobot – yeah that was my first thought, but its fugly and it would be so much nicer to do it in the CTOR.

@Mark – look forward to the fix

[Author]

Posts