Cant overload Get in StringMap

[therevillsParticipant]

Example:

Monkey

#Import "<std>" Using std.. Function Main() Local sb := New ScreenBank sb.AddScreen(New TitleScreen("title")) End Class TitleScreen Extends Screen Method New(name:String) Super.New(name) End End Class Screen Field name:String Method New(name:String) Self.name = name End End Class ScreenBank Extends StringMap<Screen> Method AddScreen(screen:Screen) Set(screen.name.ToUpper(), screen) End Method Get:Screen(name:String) Override name = name.ToUpper() Local s:Screen = Super.Get(name) If s = Null Then Print("Screen '" + name + "' not found in the ScreenBank") Return s End Method ToString:String() Local rv:String = "" For Local key:String = Eachin Self.Keys rv += key + "~n" Next Return rv End End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45

#Import "<std>"   Using std..   Function Main() Local sb := New ScreenBank sb.AddScreen(New TitleScreen("title")) End   Class TitleScreen Extends Screen Method New(name:String) Super.New(name) End End   Class Screen Field name:String Method New(name:String) Self.name = name End End   Class ScreenBank Extends StringMap<Screen> Method AddScreen(screen:Screen) Set(screen.name.ToUpper(), screen) End Method Get:Screen(name:String) Override name = name.ToUpper()   Local s:Screen = Super.Get(name) If s = Null Then Print("Screen '" + name + "' not found in the ScreenBank") Return s End Method ToString:String() Local rv:String = "" For Local key:String = Eachin Self.Keys rv += key + "~n" Next Return rv End End

Error : Method ‘Get:Screen(string)’ overrides a non-virtual superclass method

[Mark SiblyKeymaster]

Map.Get is final and cannot be overriden.

IMO, best approach is for ScreenBank to have an internal _map field and present it’s own interface, but you could also add a GetScreen method if you really want to extend Map.

[therevillsParticipant]

Thanks for the reply Mark, I had already implemented the GetScreen method before I posted. In MX1 we could override Map.Get, any reason why you have decided to make it final in MX2?

[Mark SiblyKeymaster]

> In MX1 we could override Map.Get, any reason why you have decided to make it final in MX2?

Basically because I think it’s a better design. You can read some of the arguments for and against virtual methods vs final methods and why I prefer final unless there’s a good reason to make some virtual here:

http://www.monkey-x.com/Community/posts.php?topic=10392&page=1

[Author]

Posts