Closing a Window

[sicilicaParticipant]

Is there no way to close a Window without killing the AppInstance? There don’t seem to be any SDL_DestroyWindow calls anywhere that I can find, even.

Or maybe I’m just going about things the wrong way. How is everyone handling changing resolutions? At this point, the only thing I can think of would be to have a persistent “game state” object that you create in Main, then create an AppInstance and Window within some loop, and then call Terminate on that app and make a new one that uses the same state object if you even need to change resolution, switch windowed/fullscreen, etc. But… that seems like a pretty bizarre way to handle things, and I question whether that will be sanitary for things like std.time.Millisecs and so on.

Edit: Actually, that doesn’t even work, since Terminate calls libc.exit instead of continuing after the blocking App.Run call. Is this just impossible because Mark didn’t get around to writing SDL cleanup code? I guess none of this would work at all outside of desktop, but is noone trying to develop something commercial?

[DaYParticipant]

you could run in console mode and use createwindow function in mojo module just use global pointers to store the new window hwnd and then terminate the global appInstance and as its console it should not close the full app just the hwnd.

[nerobotParticipant]

How is everyone handling changing resolutions?

You can change window size on the fly, but with some extra code right now (it’s easy to make it a part of Window class).

Code:

Monkey

Funcrion ResizeWindow( wnd:Window,size:Vec2i )   SDL_SetWindowSize( wnd.SDLWindow,size.x,size.y )   wnd.SendWindowEvent( New WindowEvent( EventType.WindowResized,wnd ) ) End

1 2 3 4

Funcrion ResizeWindow( wnd:Window,size:Vec2i )   SDL_SetWindowSize( wnd.SDLWindow,size.x,size.y )   wnd.SendWindowEvent( New WindowEvent( EventType.WindowResized,wnd ) ) End

Additional import is required:

Monkey

#Import "<sdl2>" Using sdl2..

1 2	#Import "<sdl2>" Using sdl2..

Usage:

Monkey

ResizeWindow( App.ActiveWindow,New Vec2i(800,600) )

1	ResizeWindow( App.ActiveWindow,New Vec2i(800,600) )

 

Also there is a SDL_HideWindow() method inside of sdl2 module.

Maybe it’s that you are searching for (instead of DestroyWindow).

[sicilicaParticipant]

Running in console mode – wouldn’t that not get you access to SDL, though? Still would like to be using SDL for input and rendering and everything. Maybe I’m wrong here, but getting the WinAPI handle of a manually created window seems like the wrong approach.

SDL_HideWindow and SDL_DestroyWindow aren’t quite the same, no.

It looks like the sdl2 module exports SDL_SetWindowBordered and SDL_SetWindowFullscreen, among others, so maybe the solution is just to run SDL commands manually. In that case I would have to hack mojo though – mojo.app.Window._sdlWindow is private. While I’ve posted quite a bit in the past about wanting more direct access to OpenGL/SDL directly, in this case for simple 2D I do plan on actually using mojo, is all. Oh, there is actually a getter for the SDL window, nevermind. I should’ve read your code more carefully.

Is there a reason that more of this functionality isn’t already exposed by the Window class? This was all so easy by the time I started using monkey1, and I don’t think I was super late to the party. Maybe the worst part is that 90% of the methods on these classes are hidden. I get that Mark wants to wait to expose stuff that isn’t finalized, but it means I have to spend a lot of time looking through the actual source for all these modules in order to be able to actually do anything productive with them at all. It was all I could do to figure out how to get an actual timestamp for SeedRnd:

Monkey

SeedRnd(libc.tolong(libc.time(Null)))

1	SeedRnd(libc.tolong(libc.time(Null)))

All of the time_t and tm_t structs, and all of libc, aren’t even documented – but from the looks of things it would’ve been really hard to get an actual timestamp from std.time.Time even after calling std.time.Time.Now to get the system time in the first place.

[DaYParticipant]

Monkey

[crayon-5cba1573c3429959834040 inline="true" ] Namespace myConsoleApp #Import "<std>" #Import "<libc>" #Import "<reflection>" #import "<mojo>" Using std.. Using libc.. Using reflection.. Using mojo.. class appwindow Extends Window Method New() Super.New("Game", 640, 480) End Method End Class 'here is the main function which is called. and the simplest text "hello world" is outputted to the console Function Main() Print "Hello World" Global pAppinstance1:= New AppInstance Global pApp1:= New appwindow Global pAppinstance2:= New AppInstance Global pApp2:= New appwindow App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29

[crayon-5cba1573c3429959834040 inline="true" ] Namespace myConsoleApp   #Import "<std>" #Import "<libc>" #Import "<reflection>" #import "<mojo>"   Using std.. Using libc.. Using reflection.. Using mojo..   class appwindow Extends Window       Method New()              Super.New("Game", 640, 480)       End Method End Class   'here is the main function which is called. and the simplest text "hello world" is outputted to the console Function Main() Print "Hello World" Global pAppinstance1:= New AppInstance Global pApp1:= New appwindow Global pAppinstance2:= New AppInstance Global pApp2:= New appwindow   App.Run() End

[/crayon]

as you can see you can create instances and multi windows from the console its the route im trying to pass instance to a externel lib. its a bit hackish but mx2 is still being developed.

[sicilicaParticipant]

The fact that you have two AppInstance’s isn’t doing anything for you here, unless I’m crazy. When you call App.Run(), it’s executing on pAppinstance2, which starts an SDL event loop. Both windows work because they aren’t tied directly to the AppInstance; both pAppinstance1 and pAppinstance2 should have access to both windows when they call Window.VisibleWindows().

I don’t know what you’re trying to do here, but I have a lot of trouble believing that that could possibly help anything, and it certainly doesn’t give you any extra ability to close windows individually or to exit that SDL event loop and re-enter a new one (via App.Terminate or whatever).

I’m reasonably confident that using SDL commands directly is the only solution right now.

[DaYParticipant]

i used app.run to show that you can create instance in console mode obv you would need to overide the window attributes you just create ur own app.run not the default.

the other way would be to create a cpp class that handles the SYS WINDOW directly so you just hook into the window exteranly.

could you not extend the app.cpp in mojo?

[nerobotParticipant]

Is there a reason that more of this functionality isn’t already exposed by the Window class?

The main idea here is to extend base minimal functionality by real needs – to minimize overcoding.

Also don’t forget that mx2 is very newly language. Our real using and reature requesting make it better and better.

—————————————–

Not need to create many app instances, but create a few windows.

And create many windows isn’t a problem – it works.

The problem is terminating whole app when closing any window.

I looked into sources of Window class and found that (private method):

Monkey

#rem monkeydoc Window event handler. Called when the window is sent a window event. #end Method OnWindowEvent( event:WindowEvent ) Virtual Select event.Type Case EventType.WindowClose App.Terminate() Case EventType.WindowResized App.RequestRender() 'Should maybe do this regardless? Case EventType.WindowGainedFocus App.RequestRender() 'Need to do this for KDE on linux? End End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22

#rem monkeydoc Window event handler.   Called when the window is sent a window event.   #end Method OnWindowEvent( event:WindowEvent ) Virtual   Select event.Type Case EventType.WindowClose App.Terminate() Case EventType.WindowResized App.RequestRender() 'Should maybe do this regardless? Case EventType.WindowGainedFocus App.RequestRender() 'Need to do this for KDE on linux? End End

As you can see, there is

Monkey

Case EventType.WindowClose App.Terminate()

1 2 3

Case EventType.WindowClose          App.Terminate()

that doesn’t check windows count, and terminate app by closing any window.

I added that as issue: https://github.com/blitz-research/monkey2/issues/163

[Mark SiblyKeymaster]

Currently, mojo is designed very much around ‘one permanent window’ style game coding. Multiple windows are very untested (although the basic framework for support is in there and they will eventually happen) and yes, closing window=closing app, something that will also change in future.

handling changing resolutions?

The Window.BeginFullscreen() and Window.EndFullscreen() methods allow you to dynamically enter/leave fullscreen mode at runtime. With no params, BeginFullscreen enters ‘desktop mode’ fullscreen, or you can specify width,height,hertz to actually change display mode. Note you can also provide a virtual resolution via OnMeasure:Vec2i() so desktop mode fullscreen is often fine.

See bananas/spacehimps for a demo of Alt-Enter fullscreen toggling. See bananas/viewlayout for a demo of virtual resolution.

There’s still no way to enum display modes cleanly though (excluding SDL) – coming soon-ish.

To manually change position/size of a window (in ‘desktop’ coords) use the Window.Frame property.

In general, avoid using SDL_* calls if there’s a ‘mojo’ way to do something. SDL_Resize will probably work, but only because mojo currently polls window size for the sake of some platforms. I’d rather not expose this level of mesiness though (ie: In future it may not, or it may not on some platforms etc) so if there’s mojo way to do something, please use that as it should be ‘just work’. And if it doesn’t, or mojo doesn’t have some feature you’re having to resort to SDL for, let me know or better, post an issue at github.

[impixiParticipant]

There’s a bug in the Window.BeginFullscreen method. I posted an issue on Github…

When it’s fixed the following *rough* example should work. It gets your primary display’s supported modes and allows you to switch through them at run time:

Monkey

[crayon-5cba1573d094b886798143 inline="true" ]#Import "<std>" #Import "<sdl2>" #Import "<mojo>" Using std.. Using sdl2.. Using mojo.. Function Main() New AppInstance New MyWindow App.Run() End Class MyWindow Extends Window Field _curScreenMode:ScreenMode Field _curScreenModeStr:String Method New( title:String="Simple mojo app",width:Int=640,height:Int=480,flags:WindowFlags=Null ) Super.New( title,width,height,flags ) 'In this example, assuming mojo is using SDL display id = 0. ScreenMode.GetAll(0) ScreenMode.DebugPrintAll() If ScreenMode.Stack.Length <= 0 Print "ERROR: Could not find a valid screen mode." App.Terminate() End SetScreenMode(0) End Method SetScreenMode:Void(idx:int) If Fullscreen Then EndFullscreen() If idx < 0 Or idx >= ScreenMode.Stack.Length Then idx = 0 _curScreenMode = ScreenMode.Stack[idx] _curScreenModeStr = _curScreenMode.ToString() BeginFullscreen(_curScreenMode.Width, _curScreenMode.Height, _curScreenMode.Rate) App.RequestRender() End Method OnRender( canvas:Canvas ) Override App.RequestRender() canvas.DrawText("[TAB] - toggle fullscreen, [LEFT] [RIGHT] change screen mode.", Width / 2, Height / 4, 0.5, 0.5) canvas.DrawText(_curScreenModeStr, Width / 2, Height / 2, 0.5, 0.5) canvas.Flush() End Method OnKeyEvent:Void(event:KeyEvent) Override If event.Type = EventType.KeyDown Select event.Key Case Key.Escape App.Terminate() Case Key.Tab If Fullscreen Then EndFullscreen() Else SetScreenMode(_curScreenMode.ModeId) Case Key.Left SetScreenMode(_curScreenMode.ModeId - 1) Case Key.Right SetScreenMode(_curScreenMode.ModeId + 1) End Endif End End Class ScreenMode 'TODO: DPI information for each display? Public Global Stack:Stack<ScreenMode> Function GetAll:Void(displayId:Int = -1) Stack = New Stack<ScreenMode> Local numDisplays := SDL_GetNumVideoDisplays() For Local i:Int = 0 Until numDisplays 'Only include modes matvhing the specified displayId 'otherwise if < 0 then inlclude all modes for all detected displays. If displayId >= 0 And i <> displayId Then Continue Local displayName := String.FromCString(SDL_GetDisplayName(i)) Local numModes := SDL_GetNumDisplayModes(i) For Local j := 0 Until numModes Local displayMode:SDL_DisplayMode Local displayModePtr:SDL_DisplayMode Ptr = Varptr displayMode SDL_GetDisplayMode(i, j, displayModePtr) Stack.Push(New ScreenMode(i, j, displayMode)) Next Next End Function DebugPrintAll:Void() For Local mode := Eachin Stack Print mode.ToString() Next End '---------- Private Field _displayId:Int Field _modeId:Int Field _mode:SDL_DisplayMode Public Method New(displayId:Int, modeId:Int, mode:SDL_DisplayMode) _displayId = displayId _modeId = modeId _mode = mode End Property DisplayId:Int() Return _displayId End Property ModeId:Int() Return _modeId End Property Width:Int() Return _mode.w End Property Height:Int() Return _mode.h End Property Rate:Int() Return _mode.refresh_rate End Method ToString:String() Local str := "(" + _displayId + ") " + String.FromCString(SDL_GetDisplayName(_displayId)) str += " -- [" + _modeId + "] " + _mode.w + "x" + _mode.h + " @ " + _mode.refresh_rate + "hz" Return str End End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163

[crayon-5cba1573d094b886798143 inline="true" ]#Import "<std>" #Import "<sdl2>" #Import "<mojo>"   Using std.. Using sdl2.. Using mojo..   Function Main() New AppInstance New MyWindow App.Run() End   Class MyWindow Extends Window   Field _curScreenMode:ScreenMode Field _curScreenModeStr:String   Method New( title:String="Simple mojo app",width:Int=640,height:Int=480,flags:WindowFlags=Null )   Super.New( title,width,height,flags ) 'In this example, assuming mojo is using SDL display id = 0. ScreenMode.GetAll(0) ScreenMode.DebugPrintAll()   If ScreenMode.Stack.Length <= 0 Print "ERROR: Could not find a valid screen mode." App.Terminate() End SetScreenMode(0) End   Method SetScreenMode:Void(idx:int) If Fullscreen Then EndFullscreen()   If idx < 0 Or idx >= ScreenMode.Stack.Length Then idx = 0 _curScreenMode = ScreenMode.Stack[idx] _curScreenModeStr = _curScreenMode.ToString() BeginFullscreen(_curScreenMode.Width, _curScreenMode.Height, _curScreenMode.Rate)   App.RequestRender() End   Method OnRender( canvas:Canvas ) Override App.RequestRender() canvas.DrawText("[TAB] - toggle fullscreen, [LEFT] [RIGHT] change screen mode.", Width / 2, Height / 4, 0.5, 0.5) canvas.DrawText(_curScreenModeStr, Width / 2, Height / 2, 0.5, 0.5) canvas.Flush() End Method OnKeyEvent:Void(event:KeyEvent) Override If event.Type = EventType.KeyDown   Select event.Key Case Key.Escape App.Terminate() Case Key.Tab If Fullscreen Then EndFullscreen() Else SetScreenMode(_curScreenMode.ModeId) Case Key.Left SetScreenMode(_curScreenMode.ModeId - 1) Case Key.Right SetScreenMode(_curScreenMode.ModeId + 1)   End Endif End End   Class ScreenMode 'TODO: DPI information for each display? Public Global Stack:Stack<ScreenMode> Function GetAll:Void(displayId:Int = -1) Stack = New Stack<ScreenMode> Local numDisplays := SDL_GetNumVideoDisplays() For Local i:Int = 0 Until numDisplays 'Only include modes matvhing the specified displayId 'otherwise if < 0 then inlclude all modes for all detected displays. If displayId >= 0 And i <> displayId Then Continue Local displayName := String.FromCString(SDL_GetDisplayName(i)) Local numModes := SDL_GetNumDisplayModes(i) For Local j := 0 Until numModes Local displayMode:SDL_DisplayMode Local displayModePtr:SDL_DisplayMode Ptr = Varptr displayMode SDL_GetDisplayMode(i, j, displayModePtr) Stack.Push(New ScreenMode(i, j, displayMode)) Next Next End Function DebugPrintAll:Void() For Local mode := Eachin Stack Print mode.ToString() Next End '---------- Private Field _displayId:Int Field _modeId:Int Field _mode:SDL_DisplayMode Public Method New(displayId:Int, modeId:Int, mode:SDL_DisplayMode) _displayId = displayId _modeId = modeId _mode = mode End Property DisplayId:Int() Return _displayId End Property ModeId:Int() Return _modeId End Property Width:Int() Return _mode.w End Property Height:Int() Return _mode.h End Property Rate:Int() Return _mode.refresh_rate End Method ToString:String() Local str := "(" + _displayId + ") " + String.FromCString(SDL_GetDisplayName(_displayId)) str += " -- [" + _modeId + "] " + _mode.w + "x" + _mode.h + " @ " + _mode.refresh_rate + "hz" Return str End End

[/crayon]

[Mark SiblyKeymaster]

…thanks for that Impixi, fixing now.

And BeginFullscreen isn’t even docced yet! Fixing that too…in general, if you notice something @hidden in the docs that looks like it shouldn’t be, please let me know.

[Author]

Posts