Continue Line

[nobuyukiParticipant]

I don’t like line continuation characters at all.  If there’d be only one change to make, I’d request that “+” qualify as a continuation character, or make all operators qualify.  Don’t know how messy that would be, but I’d presume that using “..” will be unfun for parsers and/or preclude using it in the monkey1 way for slicing (is that even a thing anymore?)

[therevillsParticipant]

Is there a format to split an “IF” statement over multiple lines?

[Mark SiblyKeymaster]

Not currently, I haven’t felt the need so far for anything beyond the current scheme of allowing line splitting after ‘(‘, ‘,’ and ‘[‘. That’s just the way I like to code I guess – if a line get so long it’s wider than a page, I like to break it into bits. Ditto with functions longer than a page(ish).

But that’s just me. The ‘..’ token is currently unused and I’d be OK with adding that for line ‘continuation as it’s clean and simple and makes it obvious that you are in fact splitting a line.

[therevillsParticipant]

Good! Thought I was missing something and I was trying everything to get it to work

In MonkeyX1 I had:

Monkey

[crayon-5cb9d03c71e19271175762 inline="true" ] if game.level.getCollisionTile(x - image.w2 + amount, tempY + image.h2 - amountY) > 0 or game.level.getCollisionTile(x + image.w2 - amount, tempY + image.h2 -amountY) > 0 or game.level.getCollisionTile(x, tempY + image.h2 - amountY) > 0 then

1 2 3 4 5

[crayon-5cb9d03c71e19271175762 inline="true" ] if game.level.getCollisionTile(x - image.w2 + amount, tempY + image.h2 - amountY) > 0 or game.level.getCollisionTile(x + image.w2 - amount, tempY + image.h2 -amountY) > 0 or game.level.getCollisionTile(x, tempY + image.h2 - amountY) > 0 then

[/crayon]

But in Monkey2 its currently:
If _level.GetCollisionTile(tempX - w2 , position.y + h2 - 1 ) = 0 And _level.GetCollisionTile(tempX - w2 , position.y - h2) = 0 And _level.GetCollisionTile(tempX - w2 , position.y) = 0

(hmmm that is meant to be one long line…)

So its a bit long to read nicely…

[Mark SiblyKeymaster]

In the meantime, you could break long ‘And’ If statements into multiple block Ifs, eg:

Monkey

If _level.GetCollisionTile(tempX - w2 , position.y + h2 - 1 ) = 0 If _level.GetCollisionTile(tempX - w2 , position.y - h2) = 0 If _level.GetCollisionTile(tempX - w2 , position.y) = 0 Endif Endif Endif

1 2 3 4 5 6 7

If _level.GetCollisionTile(tempX - w2 , position.y + h2 - 1 ) = 0    If _level.GetCollisionTile(tempX - w2 , position.y - h2) = 0       If _level.GetCollisionTile(tempX - w2 , position.y) = 0       Endif    Endif Endif

This is what I tend to do – I like having just one statement per line (as you might have guessed).

[therevillsParticipant]

Yeah, but I needed an ElseIf for all the conditions

Monkey

[crayon-5cb9d03c7ac82860558344 inline="true" ] If _level.GetCollisionTile(tempX - w2 , position.y + h2 - 1 ) = 0 And _level.GetCollisionTile(tempX - w2 , position.y - h2) = 0 And _level.GetCollisionTile(tempX - w2 , position.y) = 0 position.x = tempX Else position.x = Round((position.x - w2) / _level.TileSize) * _level.TileSize + w2 End

1 2 3 4 5 6

[crayon-5cb9d03c7ac82860558344 inline="true" ] If _level.GetCollisionTile(tempX - w2 , position.y + h2 - 1 ) = 0 And _level.GetCollisionTile(tempX - w2 , position.y - h2) = 0 And _level.GetCollisionTile(tempX - w2 , position.y) = 0 position.x = tempX Else position.x = Round((position.x - w2) / _level.TileSize) * _level.TileSize + w2 End

[/crayon]

In one place I did split it up like so:

Monkey

[crayon-5cb9d03c7ac88890595387 inline="true" ] Local tileData:Int[] = New Int[3] tileData[0] = _level.GetCollisionTile(position.x - w2 + amount, tempY + h2 - amountY) tileData[1] = _level.GetCollisionTile(position.x + w2 - amount, tempY + h2 - amountY) tileData[2] = _level.GetCollisionTile(position.x, tempY + h2 - amountY) If tileData[0] > 0 Or tileData[1] > 0 Or tileData[2] > 0 deltaValue.y = 0 _jumping = false position.y = Round((tempY + h2) / _level.TileSize) * _level.TileSize - h2 SetupStandAnimation() If tileData[0] = 92 Or tileData[0] = 93 Or tileData[1] = 92 Or tileData[1] = 93 Or tileData[2] = 92 Or tileData[2] = 93 SetupDieAnimation() deltaValue.y = -430 End Else position.y = tempY End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22

[crayon-5cb9d03c7ac88890595387 inline="true" ] Local tileData:Int[] = New Int[3] tileData[0] = _level.GetCollisionTile(position.x - w2 + amount, tempY + h2 - amountY) tileData[1] = _level.GetCollisionTile(position.x + w2 - amount, tempY + h2 - amountY) tileData[2] = _level.GetCollisionTile(position.x, tempY + h2 - amountY) If tileData[0] > 0 Or tileData[1] > 0 Or tileData[2] > 0 deltaValue.y = 0 _jumping = false position.y = Round((tempY + h2) / _level.TileSize) * _level.TileSize - h2 SetupStandAnimation() If tileData[0] = 92 Or tileData[0] = 93 Or tileData[1] = 92 Or tileData[1] = 93 Or tileData[2] = 92 Or tileData[2] = 93 SetupDieAnimation() deltaValue.y = -430 End Else position.y = tempY End

[/crayon]

[AdamStrangeParticipant]

add stuff, but don’t break stuff.

[Mark SiblyKeymaster]

add stuff, but don’t break stuff.

Definitely! EOL handling is strangely tricky, but think I have it covered this time around.

[therevillsParticipant]

My preference would be to use “And” / “Or” as the line continuation instead of .. if possible

[EdzUpParticipant]

I vote for the ‘..’ to split lines, strings should just be added to itself ‘MyString += “My text’ sort of thing.

[therevillsParticipant]

“..” isn’t intuitive though and seems like going backwards to me as Monkey 1 had And / Or.

[abakoboParticipant]

“..” and “And” and “Or” !?
All of them would be usefull..

[Author]

Posts