do "Node" work the same in monkey2 as in monkey1?

[JesseParticipant]

I have been trying to get this code to work for a while:

Monkey

#import "<std>" Using std.. Global carStore:Store<StoreObject> = New Store<StoreObject>(50) Global list:List<StoreObject> = New List<StoreObject> Function Main() For Local i:Int = 0 Until 20 Local car := carStore.GetItem() list.AddLast(car) Next Local link := list.FirstNode() While link Local storeObject :=Cast<StoreObject>(link.Value) link = link.Succ Wend End function Class Store<T> Field last:T Field total:Int Method New() End Method Method New(count:Int) Fill(count) End Method Method Fill:Void(total:Int) For Local i:Int = 0 Until total Local c:T = New T() c._pred = last last = c Next Self.total = total End Method Method Count:Int() Return total End Method Method GetItem:T() If last Local c:T = last last = Cast<T>(last._pred) c._pred = Null total -= 1 Return c Endif Return New T() End Method Method ReturnItem:Void(obj:T) obj._succ = Null obj._pred = last last = obj total += 1 End Method End Class Class StoreObject Field _pred:StoreObject Field _succ:StoreObject Method New() End method Function Separate:Void(obj:StoreObject) If obj._pred If obj._succ obj._pred._succ = obj._succ obj._succ._pred = obj._pred Else obj._pred._succ = Null Endif Elseif obj._succ obj._succ._pred = Null Endif End Function End Class

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88

#import "<std>" Using std..   Global carStore:Store<StoreObject> = New Store<StoreObject>(50) Global list:List<StoreObject> = New List<StoreObject>     Function Main() For Local i:Int = 0 Until 20 Local car := carStore.GetItem() list.AddLast(car) Next Local link := list.FirstNode() While link Local storeObject :=Cast<StoreObject>(link.Value) link = link.Succ Wend End function   Class Store<T> Field last:T Field total:Int Method New() End Method Method New(count:Int) Fill(count) End Method   Method Fill:Void(total:Int) For Local i:Int = 0 Until total Local c:T = New T() c._pred = last last = c Next Self.total = total End Method Method Count:Int() Return total End Method Method GetItem:T() If last Local c:T = last last = Cast<T>(last._pred) c._pred = Null total -= 1 Return c Endif Return New T() End Method Method ReturnItem:Void(obj:T) obj._succ = Null obj._pred = last last = obj total += 1 End Method End Class   Class StoreObject Field _pred:StoreObject Field _succ:StoreObject Method New() End method Function Separate:Void(obj:StoreObject) If obj._pred If obj._succ obj._pred._succ = obj._succ obj._succ._pred = obj._pred Else obj._pred._succ = Null Endif Elseif obj._succ obj._succ._pred = Null Endif End Function End Class

but it goes into an endless loop. I am not sure if that’s a bug or I am not doing it right?

it works fine in monkey1 but not here.

[peterigzParticipant]

This might be a better way of doing it now:

Monkey

Function Main() For Local i:Int = 0 Until 20 Local car := carStore.GetItem() list.AddLast(car) Next Local items:=list.All() While Not items.AtEnd Local link:=items.Current Local storeObject :=Cast<StoreObject>(link) items.Bump() Wend End function

1 2 3 4 5 6 7 8 9 10 11 12 13

Function Main() For Local i:Int = 0 Until 20 Local car := carStore.GetItem() list.AddLast(car) Next Local items:=list.All() While Not items.AtEnd Local link:=items.Current Local storeObject :=Cast<StoreObject>(link) items.Bump() Wend End function

[JesseParticipant]

OK Thanks Peter. I don’t get the need of Pred and Succ anymore. I guess I have a lot of re coding to do now.

Personally I don’t think that’s a better way. i hate the fact that it goes trough a lot of processes in the background. I think the direct approach was better.

[JesseParticipant]

I alternatively figured it out with a minor change:

Monkey

Function Main() For Local i:Int = 0 Until 20 Local car := carStore.GetItem() list.AddLast(car) Next Local link := list.FirstNode() While link.Value <> Null Print "ok" Local storeObject :=Cast<StoreObject>(link.Value) link = link.Succ Wend End function

1 2 3 4 5 6 7 8 9 10 11 12 13 14

Function Main() For Local i:Int = 0 Until 20 Local car := carStore.GetItem() list.AddLast(car) Next Local link := list.FirstNode() While link.Value <> Null Print "ok" Local storeObject :=Cast<StoreObject>(link.Value) link = link.Succ Wend End function

this works as expected.

[peterigzParticipant]

I’ll have to try that if it’s quicker. The other method is safe if you need to add and remove things from the list while you’re looping through but only as opposed to using a foreach, so maybe using it directly like that is slightly faster. But then given how exotic the c++ compiler seems to be these days it’s anyone’s guess!

[Author]

Posts