Fail to compile

[JesseParticipant]

I can’t figure this error out. The code translate with out problems but when it compiles, the c compiler complains about an error:

Monkey

Function Main() Local v1:Collision = New HitBox(new PVector2D(7,56),30,40,50,48) Local v2:Collision = New HitCircle(new PVector2D(28,17),10,15,20) v1.Render() v2.Render() End function Class PVector2D Field x:Float Field y:Float Method New() End Method Method New(x:Float,y:Float) Self.x = x Self.y = y End Method Method Set:Void(x:Float,y:Float) Self.x = x Self.y = y End Method End Class Class Collision Abstract Field pos:PVector2D Field off:PVector2D Method New() off = New PVector2D End Method Method Set:Void(pos:PVector2D,ox:Float,oy:Float,width:Float,height:Float) Abstract Method Set:Void(pos:PVector2D,ox:Float,oy:Float,radius:Float) Abstract Method Collided:Bool(col:Collision) Abstract Method Render() Abstract End Class Class HitBox Extends Collision Field width:Float Field height:Float Method New() End Method Method New(p:PVector2D,x:Float,y:Float,width:Float,height:Float) Set(p,x,y,width,height) End Method Method Set:Void(pos:PVector2D,ox:Float,oy:Float,width:float,height:float) Override Self.pos = pos off.Set(ox,oy) Self.width = width Self.height = height End Method Method Collided:Bool(bx:Collision) Override Local box := cast<HitBox>(bx) Local b1x1:Float = pos.x + off.x Local b1y1:Float = pos.y + off.y Local b1x2:Float = pos.x + width Local b1y2:Float = pos.y + height Local b2x1:Float = box.pos.x + box.off.x Local b2y1:Float = box.pos.y + box.off.y Local b2x2:Float = box.pos.x + box.width Local b2y2:Float = box.pos.y + box.height If b1x1 > b2x2 Return False If b1x2 < b2x1 Return False If b1y1 > b2y2 Return False If b1y2 < b2y1 Return False Return True End Method Method Render:Void() Override Print pos.y End Method End Class Class HitCircle Extends Collision Field radius:Float Method New(pos:PVector2D,ox:Float,oy:Float,radius:Float) Set(pos,ox,oy,radius) End Method Method Set(pos:PVector2D,ox:Float,oy:Float,radius:Float=0) Override Self.pos = pos off.Set(ox,oy) Self.radius = radius End Method Method Collided:Bool(bx:Collision) Override Local box := Cast<HitBox>(bx) If box Then Return Rectangle(box) Local cir := Cast<HitCircle>(bx) If cir Then Return Circle(cir) Return False End Method Method Circle:Bool(cir:HitCircle) Local totRadius:Float Local vx:Float = pos.x - cir.pos.x Local vy:Float = pos.y - cir.pos.y totRadius = Self.radius+cir.radius If (vx*vx+vy*vy) < totRadius*totRadius Return True Return false End Method Method Rectangle:Bool(rect:HitBox) Local vx:Float = rect.width/2 Local vy:Float = rect.height/2 Local radius:Float = Sqrt(vx*vx + vy*vy) Local totRadius := Self.radius + radius Local nx:Float = pos.x - rect.pos.x Local ny:Float = pos.y - rect.pos.y If totRadius*totRadius < (nx*nx + ny*ny) Return False Return True End Method Method Render:void() Override Print pos.x End Method End Class

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134

Function Main() Local v1:Collision = New HitBox(new PVector2D(7,56),30,40,50,48) Local v2:Collision = New HitCircle(new PVector2D(28,17),10,15,20) v1.Render() v2.Render() End function   Class PVector2D Field x:Float Field y:Float Method New() End Method Method New(x:Float,y:Float) Self.x = x Self.y = y End Method Method Set:Void(x:Float,y:Float) Self.x = x Self.y = y End Method End Class       Class Collision Abstract Field pos:PVector2D Field off:PVector2D Method New() off = New PVector2D End Method Method Set:Void(pos:PVector2D,ox:Float,oy:Float,width:Float,height:Float) Abstract Method Set:Void(pos:PVector2D,ox:Float,oy:Float,radius:Float) Abstract Method Collided:Bool(col:Collision) Abstract Method Render() Abstract End Class     Class HitBox Extends Collision Field width:Float Field height:Float       Method New()       End Method    Method New(p:PVector2D,x:Float,y:Float,width:Float,height:Float)     Set(p,x,y,width,height) End Method    Method Set:Void(pos:PVector2D,ox:Float,oy:Float,width:float,height:float) Override Self.pos = pos off.Set(ox,oy) Self.width = width Self.height = height End Method      Method Collided:Bool(bx:Collision) Override    Local box := cast<HitBox>(bx)      Local b1x1:Float = pos.x + off.x      Local b1y1:Float = pos.y + off.y      Local b1x2:Float = pos.x + width      Local b1y2:Float = pos.y + height      Local b2x1:Float = box.pos.x + box.off.x      Local b2y1:Float = box.pos.y + box.off.y      Local b2x2:Float = box.pos.x + box.width      Local b2y2:Float = box.pos.y + box.height      If b1x1 > b2x2 Return False      If b1x2 < b2x1 Return False      If b1y1 > b2y2 Return False      If b1y2 < b2y1 Return False     Return True   End Method        Method Render:Void() Override Print pos.y End Method    End Class     Class HitCircle Extends Collision Field radius:Float Method New(pos:PVector2D,ox:Float,oy:Float,radius:Float) Set(pos,ox,oy,radius) End Method Method Set(pos:PVector2D,ox:Float,oy:Float,radius:Float=0) Override Self.pos = pos off.Set(ox,oy) Self.radius = radius     End Method      Method Collided:Bool(bx:Collision) Override    Local box := Cast<HitBox>(bx) If box Then Return Rectangle(box) Local cir := Cast<HitCircle>(bx) If cir Then Return Circle(cir) Return False End Method    Method Circle:Bool(cir:HitCircle)    Local totRadius:Float    Local vx:Float = pos.x - cir.pos.x    Local vy:Float = pos.y - cir.pos.y    totRadius = Self.radius+cir.radius       If (vx*vx+vy*vy) < totRadius*totRadius Return True    Return false End Method    Method Rectangle:Bool(rect:HitBox)    Local vx:Float = rect.width/2    Local vy:Float = rect.height/2 Local radius:Float = Sqrt(vx*vx + vy*vy) Local totRadius := Self.radius + radius Local nx:Float = pos.x - rect.pos.x Local ny:Float = pos.y - rect.pos.y If totRadius*totRadius < (nx*nx + ny*ny) Return False Return True End Method Method Render:void() Override Print pos.x End Method End Class

it translate fine but when it compiles the c compiler complains and gives me an error:

<quote>

mx2cc version 1.0.0

***** Building app ‘/Users/legend/Desktop/monkeypatrol/src/testlist.monkey2’ *****

Parsing…
Semanting…
Translating…
Compiling….
Build error: System command ‘g++ -std=c++11 -Wno-deprecated-declarations -Wno-tautological-pointer-compare -Wno-undefined-bool-conversion -Wno-int-to-void-pointer-cast -Wno-inconsistent-missing-override -Wno-logical-op-parentheses -Wno-parentheses-equality -O0 -I”/Users/legend/monkey2/modules/monkey/native” -c -o “/Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_0testlist.cpp.o” “/Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.cpp”‘ failed.

g++ -std=c++11 -Wno-deprecated-declarations -Wno-tautological-pointer-compare -Wno-undefined-bool-conversion -Wno-int-to-void-pointer-cast -Wno-inconsistent-missing-override -Wno-logical-op-parentheses -Wno-parentheses-equality -O0 -I”/Users/legend/monkey2/modules/monkey/native” -c -o “/Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_0testlist.cpp.o” “/Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.cpp”

In file included from /Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.cpp:2:
In file included from /Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.h:5:
In file included from /Users/legend/monkey2/modules/monkey/native/bbmonkey.h:13:
/Users/legend/monkey2/modules/monkey/native/bbobject.h:48:11: error: allocating an object of abstract class type ‘t_default_HitBox’
T *p=new T( a… );
^
/Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.cpp:26:35: note: in instantiation of function template specialization ‘bbGCNew<t_default_HitBox, t_default_PVector2D *, float, float, float, float>’ requested here
f0.l_v1=((t_default_Collision*)(bbGCNew<t_default_HitBox>(f0.t0=bbGCNew<t_default_PVector2D>(7.0f,56.0f),30.0f,40.0f,50.0f,48.0f)));
^
/Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.h:48:16: note: unimplemented pure virtual method ‘m_Set’ in ‘t_default_HitBox’
virtual void m_Set(t_default_PVector2D* l_pos,bbFloat l_ox,bbFloat l_oy,bbFloat l_radius)=0;
^
In file included from /Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.cpp:2:
In file included from /Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.h:5:
In file included from /Users/legend/monkey2/modules/monkey/native/bbmonkey.h:13:
/Users/legend/monkey2/modules/monkey/native/bbobject.h:48:11: error: allocating an object of abstract class type ‘t_default_HitCircle’
T *p=new T( a… );
^
/Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.cpp:29:35: note: in instantiation of function template specialization ‘bbGCNew<t_default_HitCircle, t_default_PVector2D *, float, float, float>’ requested here
f0.l_v2=((t_default_Collision*)(bbGCNew<t_default_HitCircle>(f0.t0=bbGCNew<t_default_PVector2D>(28.0f,17.0f),10.0f,15.0f,20.0f)));
^
/Users/legend/Desktop/monkeypatrol/src/testlist.buildv1.0.0/build_cache/desktop_debug_macos/testlist_testlist.h:49:16: note: unimplemented pure virtual method ‘m_Set’ in ‘t_default_HitCircle’
virtual void m_Set(t_default_PVector2D* l_pos,bbFloat l_ox,bbFloat l_oy,bbFloat l_width,bbFloat l_height)=0;
^
2 errors generated.
***** Fatal mx2cc error *****

Build error.

</quote>

[olejrParticipant]

Don’t you have to implement every one of those abstract methods in (both of) those inherited classes?

Random pick from a google search:

“abstract classes are used to enforce methods that need to be overridden in the derived classes, thus avoiding potential runtime errors.”

[JesseParticipant]

Thanks Olejr! that appeared to have solved it.

My question now is. Shouldn’t monkey be able to detect that?

[therevillsParticipant]

Yes MX2 should have detected that – raise a bug over on GitHub

[JesseParticipant]

Will do. Thanks.

[Author]

Posts