Faster way to read in pixels?

[therevillsParticipant]

Currently I’m doing the following:

Monkey

tileSet = LoadSpriteSheet(tileSetPath, tileCount, tileWidth, tileHeight) tileSetMask = New Int[tileCount, tileWidth, tileHeight] For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) For Local y := 0 To px.Height - 1 For Local x := 0 To px.Width - 1 Local color:Color = px.GetPixel(x, y) If color.A > 0 tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21

tileSet = LoadSpriteSheet(tileSetPath, tileCount, tileWidth, tileHeight)   tileSetMask = New Int[tileCount, tileWidth, tileHeight] For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport)   For Local y := 0 To px.Height - 1 For Local x := 0 To px.Width - 1 Local color:Color = px.GetPixel(x, y) If color.A > 0 tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next

The tileset is an array of images (16×16), just 32 of them at the moment and I can see the delay already… is there a better / faster way?

Cheers,
Steve

[abakoboParticipant]

I would start to try with someting like that (not tested) (might create problems with lighnting and image shaders..?):

Monkey

For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pptr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1   If pptr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next

But I would also try to work with pixmaps until the last moment and as few canvas work as possible (using PastePixmap at the end can be usefull sometimes). I think it is generally faster but i’m not shure about that (and what about lighnint and shaders integrity). Not faster for drawing plain bitmaps/inmages to the target render/mojocanvas I guess…

If you can, try to use an array of Pixmaps instead of array of Images and then use pointer to read/write directly in the memory (like in the example) without using methods (even functions ?) when you are in an intensive loop spot. Reading/Writing pix per pix can be intense.
There’s also a shader approach as an option (more technical but might use GPU’s parallel computing ability, with pure mx2 you have no (parallel)multi-threading).

[nerobotParticipant]

Note: GetPixel() and GetPixelARGB() look at format of pixmap to return correct value.

[scurtyParticipant]

Not sure why you’re creating a canvas and then copying the viewport pixmap of it.
You can just reference the tile in the sprite sheet. Copying a pixmap in a loop is a bit taxing.
Idk. xD

[impixiParticipant]

I’d probably do it like this:

* Load the sprite sheet/atlas into a pixmap.
* Create the masks in one hit and store them in a single I8 pixmap.
* Utilize the Pixmap Data pointers for performance reasons.
* Hope that Mark doesn’t say it is “unsafe” to do it like that.

Example (provide your own suitable PNG file):

Monkey

#Import "<std>" #Import "<mojo>" #Import "spritesheet2.png" Using std.. Using mojo.. Function Main() New AppInstance New MyWindow App.Run() End Class MyWindow Extends Window Method New( title:String="Simple mojo app",width:Int=1024,height:Int=768,flags:WindowFlags=Null ) Super.New( title,width,height,flags ) tileSet = New TileSet("asset::spritesheet2.png", 32, 32) End Method OnRender( canvas:Canvas ) Override App.RequestRender() canvas.DrawImage(tileSet.imgAtlas, 0, 0) canvas.DrawImage(tileSet.imgAtlasMask, tileSet.imgAtlas.Width, 0) canvas.Flush() End Field tileSet:TileSet End '============================== Class TileSet Public Method New(url:String, tileWidth:Int, tileHeight:Int) Local pmAtlas := Pixmap.Load(url, PixelFormat.Unknown) If Not pmAtlas Then RuntimeError("Could not load spritesheet: " + url) Local tileCount := (pmAtlas.Width / tileWidth) * (pmAtlas.Height / tileHeight) Local pmAtlasMask := New Pixmap(pmAtlas.Width, pmAtlas.Height, PixelFormat.I8) Local pmAtlasDataPtr:UByte Ptr = pmAtlas.Data + Cast<UByte>(pmAtlas.Depth - 1) Local pmAtlasMaskDataPtr:UByte Ptr = pmAtlasMask.Data + Cast<UByte>(pmAtlasMask.Depth - 1) Local pidx:ULong = 0 While pidx < (pmAtlas.Width * pmAtlas.Height) If pmAtlasDataPtr[0] > 0 pmAtlasMaskDataPtr[0] = 255 Else pmAtlasMaskDataPtr[0] = 0 Endif pmAtlasDataPtr += Cast<UByte>(pmAtlas.Depth) pmAtlasMaskDataPtr += Cast<UByte>(pmAtlasMask.Depth) pidx += 1 Wend imgAtlas = Image.Load(url) imgAtlasMask = New Image(pmAtlasMask) pmAtlas.Discard() End Field imgAtlas:Image Field imgAtlasMask:Image End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82

#Import "<std>" #Import "<mojo>"   #Import "spritesheet2.png"   Using std.. Using mojo..   Function Main() New AppInstance New MyWindow App.Run() End   Class MyWindow Extends Window   Method New( title:String="Simple mojo app",width:Int=1024,height:Int=768,flags:WindowFlags=Null ) Super.New( title,width,height,flags ) tileSet = New TileSet("asset::spritesheet2.png", 32, 32)   End   Method OnRender( canvas:Canvas ) Override App.RequestRender() canvas.DrawImage(tileSet.imgAtlas, 0, 0) canvas.DrawImage(tileSet.imgAtlasMask, tileSet.imgAtlas.Width, 0) canvas.Flush() End Field tileSet:TileSet End   '==============================   Class TileSet Public   Method New(url:String, tileWidth:Int, tileHeight:Int) Local pmAtlas := Pixmap.Load(url, PixelFormat.Unknown) If Not pmAtlas Then RuntimeError("Could not load spritesheet: " + url) Local tileCount := (pmAtlas.Width / tileWidth) * (pmAtlas.Height / tileHeight) Local pmAtlasMask := New Pixmap(pmAtlas.Width, pmAtlas.Height, PixelFormat.I8)   Local pmAtlasDataPtr:UByte Ptr = pmAtlas.Data + Cast<UByte>(pmAtlas.Depth - 1) Local pmAtlasMaskDataPtr:UByte Ptr = pmAtlasMask.Data + Cast<UByte>(pmAtlasMask.Depth - 1) Local pidx:ULong = 0 While pidx < (pmAtlas.Width * pmAtlas.Height)   If pmAtlasDataPtr[0] > 0 pmAtlasMaskDataPtr[0] = 255 Else pmAtlasMaskDataPtr[0] = 0 Endif pmAtlasDataPtr += Cast<UByte>(pmAtlas.Depth) pmAtlasMaskDataPtr += Cast<UByte>(pmAtlasMask.Depth) pidx += 1 Wend imgAtlas = Image.Load(url) imgAtlasMask = New Image(pmAtlasMask) pmAtlas.Discard() End Field imgAtlas:Image Field imgAtlasMask:Image   End

Okay, I’m back to “retirement”…

.

[therevillsParticipant]

Thanks guys! I’ll run some bench marking to see what is faster, I was considering of doing it “offline” too by creating a simple app which reads in the pixel data and spit it out to a JSON file.

@scurty

Not sure why you’re creating a canvas and then copying the viewport pixmap of it.

To allow me to read the pixel data from an Image, do you know another way?

[therevillsParticipant]

Okay bench marking is done

Debug Timing

Monkey

OriginalVersion = 381ms OriginalVersion = 381002μs AbakoboVersion = 382ms AbakoboVersion = 382499μs impixiVersion = 5ms impixiVersion = 5000μs NewVersion = 2ms NewVersion = 2499μs

1 2 3 4 5 6 7 8 9 10

OriginalVersion  = 381ms OriginalVersion  = 381002μs AbakoboVersion   = 382ms AbakoboVersion   = 382499μs impixiVersion    = 5ms impixiVersion    = 5000μs NewVersion       = 2ms NewVersion       = 2499μs

Release Timing

Monkey

OriginalVersion = 20ms OriginalVersion = 20000μs AbakoboVersion = 18ms AbakoboVersion = 18022μs impixiVersion = 1ms impixiVersion = 501μs NewVersion = 0ms NewVersion = 499μs

1 2 3 4 5 6 7 8 9 10

OriginalVersion  = 20ms OriginalVersion  = 20000μs AbakoboVersion   = 18ms AbakoboVersion   = 18022μs impixiVersion    = 1ms impixiVersion    = 501μs NewVersion       = 0ms NewVersion       = 499μs

And here is the full code:

Monkey

Namespace myapp #Import "<std>" #Import "<mojo>" #Import "assets/" Using std.. Using mojo.. Const Size:=New Vec2i( 320,200 ) Class MyWindow Extends Window Field tileSet:Image[] Field tileSetMask:Int[,,] Field tileSetClass:TileSet Field tileSetClass2:TileSet2 Method New() Super.New( "My Window",1024,768,WindowFlags.Resizable ) Window.ClearColor = Color.Black Layout="letterbox" tileSet = LoadSpriteSheet("tileset.png", 32, 16, 16) tileSetMask = New Int[32, 16, 16] Local s := Millisecs() Local n := Microsecs() OriginalVersion() Print "OriginalVersion = " +(Millisecs()-s) Print "OriginalVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() AbakoboVersion() Print "AbakoboVersion = " +(Millisecs()-s) Print "AbakoboVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass = New TileSet("asset::tileset.png", 16, 16) Print "impixiVersion = " +(Millisecs()-s) Print "impixiVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass2 = New TileSet2("tileset.png", 32, 16, 16) Print "NewVersion = " +(Millisecs()-s) Print "NewVersion = " +(Microsecs()-n) End Method OnRender( canvas:Canvas ) Override canvas.TextureFilteringEnabled = False App.RequestRender() canvas.DrawImage(tileSetClass.imgAtlas, 0, 0) canvas.DrawImage(tileSetClass.imgAtlasMask, tileSetClass.imgAtlas.Width, 0) Local drawTileIndex:Int = 29 For Local y := 0 To 16 - 1 For Local x := 0 To 16 - 1 If drawTileIndex > - 1 If tileSetClass2.tileSetMask[drawTileIndex, x, y] > 0 canvas.Color = Color.Orange canvas.DrawRect(x + 150 , y + 150, 1, 1) canvas.Color = Color.White End End End End End Method OnMeasure:Vec2i() Override Return Size End Method AbakoboVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pixPtr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End Method OriginalVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) For Local y := 0 To px.Height - 1 For Local x := 0 To px.Width - 1 Local color:Color = px.GetPixel(x, y) If color.A > 0 tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End End Class TileSet Public Method New(url:String, tileWidth:Int, tileHeight:Int) Local pmAtlas := Pixmap.Load(url, PixelFormat.Unknown) If Not pmAtlas Then RuntimeError("Could not load spritesheet: " + url) Local tileCount := (pmAtlas.Width / tileWidth) * (pmAtlas.Height / tileHeight) Local pmAtlasMask := New Pixmap(pmAtlas.Width, pmAtlas.Height, PixelFormat.I8) Local pmAtlasDataPtr:UByte Ptr = pmAtlas.Data + Cast<UByte>(pmAtlas.Depth - 1) Local pmAtlasMaskDataPtr:UByte Ptr = pmAtlasMask.Data + Cast<UByte>(pmAtlasMask.Depth - 1) Local pidx:ULong = 0 While pidx < (pmAtlas.Width * pmAtlas.Height) If pmAtlasDataPtr[0] > 0 pmAtlasMaskDataPtr[0] = 255 Else pmAtlasMaskDataPtr[0] = 0 Endif pmAtlasDataPtr += Cast<UByte>(pmAtlas.Depth) pmAtlasMaskDataPtr += Cast<UByte>(pmAtlasMask.Depth) pidx += 1 Wend imgAtlas = Image.Load(url) imgAtlasMask = New Image(pmAtlasMask) pmAtlas.Discard() End Field imgAtlas:Image Field imgAtlasMask:Image End Class TileSet2 Field tileSetMask:Int[,,] Field tileSet:Image[] Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) For Local k := 0 To cellHeight - 1 For Local j := 0 To cellWidth - 1 Local color:Color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If color.A > 0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End Next atlasImg = Null tileSet = imgs End End Function LoadSpriteSheet:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::") Local atlasTexture := Texture.Load(prefix + path, Null ) Assert( atlasTexture, " ~n ~nGameGraphics: Image " + path + " not found.~n ~n" ) Local imgs := New Image[ numFrames ] Local atlasImg := New Image( atlasTexture ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) Next atlasImg = Null Return imgs End Function Main() New AppInstance New MyWindow App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234

Namespace myapp   #Import "<std>" #Import "<mojo>" #Import "assets/"   Using std.. Using mojo..   Const Size:=New Vec2i( 320,200 )   Class MyWindow Extends Window Field tileSet:Image[] Field tileSetMask:Int[,,] Field tileSetClass:TileSet Field tileSetClass2:TileSet2 Method New() Super.New( "My Window",1024,768,WindowFlags.Resizable ) Window.ClearColor = Color.Black Layout="letterbox" tileSet = LoadSpriteSheet("tileset.png", 32, 16, 16) tileSetMask = New Int[32, 16, 16] Local s := Millisecs() Local n := Microsecs() OriginalVersion() Print "OriginalVersion  = " +(Millisecs()-s) Print "OriginalVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() AbakoboVersion() Print "AbakoboVersion = " +(Millisecs()-s) Print "AbakoboVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass = New TileSet("asset::tileset.png", 16, 16) Print "impixiVersion   = " +(Millisecs()-s) Print "impixiVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass2 = New TileSet2("tileset.png", 32, 16, 16) Print "NewVersion    = " +(Millisecs()-s) Print "NewVersion  = " +(Microsecs()-n) End   Method OnRender( canvas:Canvas ) Override canvas.TextureFilteringEnabled = False App.RequestRender() canvas.DrawImage(tileSetClass.imgAtlas, 0, 0) canvas.DrawImage(tileSetClass.imgAtlasMask, tileSetClass.imgAtlas.Width, 0) Local drawTileIndex:Int = 29 For Local y := 0 To 16 - 1 For Local x := 0 To 16 - 1 If drawTileIndex > - 1 If tileSetClass2.tileSetMask[drawTileIndex, x, y] > 0 canvas.Color = Color.Orange canvas.DrawRect(x + 150 , y + 150, 1, 1) canvas.Color = Color.White End End End End End Method OnMeasure:Vec2i() Override Return Size End Method AbakoboVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pixPtr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End Method OriginalVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) For Local y := 0 To px.Height - 1 For Local x := 0 To px.Width - 1 Local color:Color = px.GetPixel(x, y) If color.A > 0 tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End End   Class TileSet Public Method New(url:String, tileWidth:Int, tileHeight:Int) Local pmAtlas := Pixmap.Load(url, PixelFormat.Unknown) If Not pmAtlas Then RuntimeError("Could not load spritesheet: " + url) Local tileCount := (pmAtlas.Width / tileWidth) * (pmAtlas.Height / tileHeight) Local pmAtlasMask := New Pixmap(pmAtlas.Width, pmAtlas.Height, PixelFormat.I8) Local pmAtlasDataPtr:UByte Ptr = pmAtlas.Data + Cast<UByte>(pmAtlas.Depth - 1) Local pmAtlasMaskDataPtr:UByte Ptr = pmAtlasMask.Data + Cast<UByte>(pmAtlasMask.Depth - 1) Local pidx:ULong = 0 While pidx < (pmAtlas.Width * pmAtlas.Height) If pmAtlasDataPtr[0] > 0 pmAtlasMaskDataPtr[0] = 255 Else pmAtlasMaskDataPtr[0] = 0 Endif pmAtlasDataPtr += Cast<UByte>(pmAtlas.Depth) pmAtlasMaskDataPtr += Cast<UByte>(pmAtlasMask.Depth) pidx += 1 Wend imgAtlas = Image.Load(url) imgAtlasMask = New Image(pmAtlasMask) pmAtlas.Discard() End Field imgAtlas:Image Field imgAtlasMask:Image   End   Class TileSet2 Field tileSetMask:Int[,,] Field tileSet:Image[]   Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) For Local k := 0 To cellHeight - 1 For Local j := 0 To cellWidth - 1 Local color:Color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If color.A > 0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End Next atlasImg = Null tileSet = imgs End End   Function LoadSpriteSheet:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::") Local atlasTexture := Texture.Load(prefix + path, Null ) Assert( atlasTexture, " ~n ~nGameGraphics: Image " + path + " not found.~n ~n" ) Local imgs := New Image[ numFrames ] Local atlasImg := New Image( atlasTexture ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) Next atlasImg = Null Return imgs End   Function Main() New AppInstance New MyWindow App.Run() End

[abakoboParticipant]

OriginalVersion = 20ms
OriginalVersion = 20000μs
AbakoboVersion = 18ms
AbakoboVersion = 18022μs

Mmm! Direct pointer usage was not a great gain (but still a gain ? or just cache work? ;). It was the key to speed in a Julia set fractal generator..
Not using Canvas operation was the major key for shure!

Note that Image and Pixmap (extends Ressource) are not GCed so you you have to .Discard() them before replacing/loosing them or you’ll leak memory. But as the are not GCed Mark won’t tell it’s not safe to point to them!?

[abakoboParticipant]

Some small pimping..

now debug:

Monkey

OriginalVersion = 67 OriginalVersion = 67176 AbakoboVersion = 65 AbakoboVersion = 65788 impixiVersion = 4 impixiVersion = 3503 NewVersion = 2 NewVersion = 2501 Tileset3 = 2 Tileset3 = 2002 Tileset4 = 1 Tileset4 = 501 Total microsecs for 100 loops : orig: 6746617 abak: 6623185 impi: 356210 tileset2: 236657 tileset3: 189626 tileset4: 64550

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

OriginalVersion  = 67 OriginalVersion  = 67176 AbakoboVersion = 65 AbakoboVersion  = 65788 impixiVersion   = 4 impixiVersion  = 3503 NewVersion    = 2 NewVersion  = 2501 Tileset3    = 2 Tileset3  = 2002 Tileset4  = 1 Tileset4  = 501 Total microsecs for 100 loops : orig: 6746617 abak: 6623185 impi: 356210 tileset2: 236657 tileset3: 189626 tileset4: 64550

Release:

Monkey

OriginalVersion = 28 OriginalVersion = 27316 AbakoboVersion = 29 AbakoboVersion = 29003 impixiVersion = 1 impixiVersion = 1004 NewVersion = 0 NewVersion = 500 Tileset3 = 1 Tileset3 = 500 Tileset4 = 0 Tileset4 = 0 Total microsecs after 100 loops: orig: 2945291 abak: 2924291 impi: 101610 tileset2: 76025 tileset3: 45032 tileset4: 26521

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19

OriginalVersion  = 28 OriginalVersion  = 27316 AbakoboVersion = 29 AbakoboVersion  = 29003 impixiVersion   = 1 impixiVersion  = 1004 NewVersion    = 0 NewVersion  = 500 Tileset3    = 1 Tileset3  = 500 Tileset4  = 0 Tileset4  = 0 Total microsecs after 100 loops: orig: 2945291 abak: 2924291 impi: 101610 tileset2: 76025 tileset3: 45032 tileset4: 26521

For the “new” Tileset class I loaded a Padded png (545*18)

Tileset2 is the original “NewVersion”
Tileset3 is just moving color declaration outise of the loop. sometimes it has no/bad effect depending on how the loop is looped (100 times a list of each one or a list of 100 times each one)
Tileset4 uses Pointer to read into memory (sometimes returns 0 microsec (or 500 or 501!?) not shure it work ok but looks like.

Monkey

Namespace myapp #Import "<std>" #Import "<mojo>" #Import "assets/" Using std.. Using mojo.. Const Size:=New Vec2i( 320,200 ) Class MyWindow Extends Window Field tileSet:Image[] Field tileSetMask:Int[,,] Field tileSetClass:TileSet Field tileSetClass2:TileSet2 Field tileSetClass3:TileSet3 Field tileSetClass4:TileSet4 Method New() Super.New( "My Window",1024,768,WindowFlags.Resizable ) Window.ClearColor = Color.Black Layout="letterbox" tileSet = LoadSpriteSheet("tileset.png", 32, 16, 16) tileSetMask = New Int[32, 16, 16] Local s := Millisecs() Local n := Microsecs() Local averageFloor:=100 Local orig: Long Local abak: Long Local impi: Long Local new1: Long Local new2: Long Local new3: Long For Local averageCount:=1 To averageFloor s = Millisecs() n = Microsecs() OriginalVersion() orig+=Microsecs()-n Print "OriginalVersion = " +(Millisecs()-s) Print "OriginalVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() AbakoboVersion() abak+=Microsecs()-n Print "AbakoboVersion = " +(Millisecs()-s) Print "AbakoboVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass = New TileSet("asset::tileset.png", 16, 16) impi+=Microsecs()-n Print "impixiVersion = " +(Millisecs()-s) Print "impixiVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass2 = New TileSet2("tilesetpad.png", 32, 16, 16) new1+=Microsecs()-n Print "NewVersion = " +(Millisecs()-s) Print "NewVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass3 = New TileSet3("tilesetpad.png", 32, 16, 16) new2+=Microsecs()-n Print "Tileset3 = " +(Millisecs()-s) Print "Tileset3 = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass4 = New TileSet4("tilesetpad.png", 32, 16, 16) new3+=Microsecs()-n Print "Tileset4 = " +(Millisecs()-s) Print "Tileset4 = " +(Microsecs()-n) Print averageCount+" percent done." Print averageCount+" percent done." Print averageCount+" percent done." Print averageCount+" percent done." Print averageCount+" percent done." Next Print "orig: "+orig Print "abak: "+abak Print "impi: "+impi Print "tileset2: "+new1 Print "tileset3: "+new2 Print "tileset4: "+new3 End Method OnRender( canvas:Canvas ) Override canvas.TextureFilteringEnabled = False App.RequestRender() canvas.DrawImage(tileSetClass.imgAtlas, 0, 0) canvas.DrawImage(tileSetClass.imgAtlasMask, tileSetClass.imgAtlas.Width, 0) Local drawTileIndex:Int = 29 For Local y := 0 To 16 - 1 For Local x := 0 To 16 - 1 If drawTileIndex > - 1 If tileSetClass2.tileSetMask[drawTileIndex, x, y] > 0 canvas.Color = Color.Orange canvas.DrawRect(x + 150 , y + 150, 1, 1) canvas.Color = Color.White End End End End End Method OnMeasure:Vec2i() Override Return Size End Method AbakoboVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pixPtr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End Method OriginalVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) For Local y := 0 To px.Height - 1 For Local x := 0 To px.Width - 1 Local color:Color = px.GetPixel(x, y) If color.A > 0 tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End End Class TileSet Public Method New(url:String, tileWidth:Int, tileHeight:Int) Local pmAtlas := Pixmap.Load(url, PixelFormat.Unknown) If Not pmAtlas Then RuntimeError("Could not load spritesheet: " + url) Local tileCount := (pmAtlas.Width / tileWidth) * (pmAtlas.Height / tileHeight) Local pmAtlasMask := New Pixmap(pmAtlas.Width, pmAtlas.Height, PixelFormat.I8) Local pmAtlasDataPtr:UByte Ptr = pmAtlas.Data + Cast<UByte>(pmAtlas.Depth - 1) Local pmAtlasMaskDataPtr:UByte Ptr = pmAtlasMask.Data + Cast<UByte>(pmAtlasMask.Depth - 1) Local pidx:ULong = 0 While pidx < (pmAtlas.Width * pmAtlas.Height) If pmAtlasDataPtr[0] > 0 pmAtlasMaskDataPtr[0] = 255 Else pmAtlasMaskDataPtr[0] = 0 Endif pmAtlasDataPtr += Cast<UByte>(pmAtlas.Depth) pmAtlasMaskDataPtr += Cast<UByte>(pmAtlasMask.Depth) pidx += 1 Wend imgAtlas = Image.Load(url) imgAtlasMask = New Image(pmAtlasMask) pmAtlas.Discard() End Field imgAtlas:Image Field imgAtlasMask:Image End Class TileSet2 Field tileSetMask:Int[,,] Field tileSet:Image[] Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) For Local k := 0 To cellHeight - 1 For Local j := 0 To cellWidth - 1 Local color:Color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If color.A > 0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End Next atlasImg = Null tileSet = imgs End End Class TileSet3 Field tileSetMask:Int[,,] Field tileSet:Image[] Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) If pixmap.Format<>PixelFormat.RGBA8 Print "wrong pixel format need RGBA8" Else tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) Local color:Color For Local k := 0 To cellHeight - 1 For Local j := 0 To cellWidth - 1 color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If color.A > 0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End Next atlasImg = Null tileSet = imgs End End End Class TileSet4 Field tileSetMask:Int[,,] Field tileSet:Image[] Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) If pixmap.Format<>PixelFormat.RGBA8 Print "wrong pixel format need RGBA8" Else tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) 'Local color:Color Local pixPtr:UInt Ptr For Local k := 0 To cellHeight - 1 pixPtr=Cast<UInt Ptr>( pixmap.PixelPtr( x,y+k ) ) For Local j := 0 To cellWidth - 1 'color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If pixPtr[j]&$FF000000>0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End #rem Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pixPtr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End #End Next atlasImg = Null tileSet = imgs End End End Function LoadSpriteSheet:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::") Local atlasTexture := Texture.Load(prefix + path, Null ) Assert( atlasTexture, " ~n ~nGameGraphics: Image " + path + " not found.~n ~n" ) Local imgs := New Image[ numFrames ] Local atlasImg := New Image( atlasTexture ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) Next atlasImg = Null Return imgs End Function Main() New AppInstance New MyWindow App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416

Namespace myapp #Import "<std>" #Import "<mojo>" #Import "assets/" Using std.. Using mojo.. Const Size:=New Vec2i( 320,200 ) Class MyWindow Extends Window Field tileSet:Image[] Field tileSetMask:Int[,,] Field tileSetClass:TileSet Field tileSetClass2:TileSet2 Field tileSetClass3:TileSet3 Field tileSetClass4:TileSet4 Method New() Super.New( "My Window",1024,768,WindowFlags.Resizable ) Window.ClearColor = Color.Black Layout="letterbox" tileSet = LoadSpriteSheet("tileset.png", 32, 16, 16) tileSetMask = New Int[32, 16, 16] Local s := Millisecs() Local n := Microsecs() Local averageFloor:=100 Local orig: Long Local abak: Long Local impi: Long Local new1: Long Local new2: Long Local new3: Long For Local averageCount:=1 To averageFloor s = Millisecs() n = Microsecs() OriginalVersion() orig+=Microsecs()-n Print "OriginalVersion  = " +(Millisecs()-s) Print "OriginalVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() AbakoboVersion() abak+=Microsecs()-n Print "AbakoboVersion = " +(Millisecs()-s) Print "AbakoboVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass = New TileSet("asset::tileset.png", 16, 16) impi+=Microsecs()-n Print "impixiVersion   = " +(Millisecs()-s) Print "impixiVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass2 = New TileSet2("tilesetpad.png", 32, 16, 16) new1+=Microsecs()-n Print "NewVersion    = " +(Millisecs()-s) Print "NewVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass3 = New TileSet3("tilesetpad.png", 32, 16, 16) new2+=Microsecs()-n Print "Tileset3    = " +(Millisecs()-s) Print "Tileset3  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass4 = New TileSet4("tilesetpad.png", 32, 16, 16) new3+=Microsecs()-n Print "Tileset4  = " +(Millisecs()-s) Print "Tileset4  = " +(Microsecs()-n)    Print averageCount+" percent done."    Print averageCount+" percent done."    Print averageCount+" percent done."    Print averageCount+" percent done."    Print averageCount+" percent done." Next Print "orig: "+orig Print "abak: "+abak Print "impi: "+impi Print "tileset2: "+new1 Print "tileset3: "+new2 Print "tileset4: "+new3 End Method OnRender( canvas:Canvas ) Override canvas.TextureFilteringEnabled = False App.RequestRender() canvas.DrawImage(tileSetClass.imgAtlas, 0, 0) canvas.DrawImage(tileSetClass.imgAtlasMask, tileSetClass.imgAtlas.Width, 0) Local drawTileIndex:Int = 29 For Local y := 0 To 16 - 1 For Local x := 0 To 16 - 1 If drawTileIndex > - 1 If tileSetClass2.tileSetMask[drawTileIndex, x, y] > 0 canvas.Color = Color.Orange canvas.DrawRect(x + 150 , y + 150, 1, 1) canvas.Color = Color.White End End End End End Method OnMeasure:Vec2i() Override Return Size End Method AbakoboVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pixPtr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End Method OriginalVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) For Local y := 0 To px.Height - 1 For Local x := 0 To px.Width - 1 Local color:Color = px.GetPixel(x, y) If color.A > 0 tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End End Class TileSet Public Method New(url:String, tileWidth:Int, tileHeight:Int) Local pmAtlas := Pixmap.Load(url, PixelFormat.Unknown) If Not pmAtlas Then RuntimeError("Could not load spritesheet: " + url) Local tileCount := (pmAtlas.Width / tileWidth) * (pmAtlas.Height / tileHeight) Local pmAtlasMask := New Pixmap(pmAtlas.Width, pmAtlas.Height, PixelFormat.I8) Local pmAtlasDataPtr:UByte Ptr = pmAtlas.Data + Cast<UByte>(pmAtlas.Depth - 1) Local pmAtlasMaskDataPtr:UByte Ptr = pmAtlasMask.Data + Cast<UByte>(pmAtlasMask.Depth - 1) Local pidx:ULong = 0 While pidx < (pmAtlas.Width * pmAtlas.Height) If pmAtlasDataPtr[0] > 0 pmAtlasMaskDataPtr[0] = 255 Else pmAtlasMaskDataPtr[0] = 0 Endif pmAtlasDataPtr += Cast<UByte>(pmAtlas.Depth) pmAtlasMaskDataPtr += Cast<UByte>(pmAtlasMask.Depth) pidx += 1 Wend imgAtlas = Image.Load(url) imgAtlasMask = New Image(pmAtlasMask) pmAtlas.Discard() End Field imgAtlas:Image Field imgAtlasMask:Image End Class TileSet2 Field tileSetMask:Int[,,] Field tileSet:Image[] Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) For Local k := 0 To cellHeight - 1 For Local j := 0 To cellWidth - 1 Local color:Color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If color.A > 0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End Next atlasImg = Null tileSet = imgs End End Class TileSet3 Field tileSetMask:Int[,,] Field tileSet:Image[] Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) If pixmap.Format<>PixelFormat.RGBA8 Print "wrong pixel format need RGBA8" Else tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) Local color:Color For Local k := 0 To cellHeight - 1 For Local j := 0 To cellWidth - 1 color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If color.A > 0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End Next atlasImg = Null tileSet = imgs End End End Class TileSet4 Field tileSetMask:Int[,,] Field tileSet:Image[] Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) If pixmap.Format<>PixelFormat.RGBA8 Print "wrong pixel format need RGBA8" Else tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) 'Local color:Color Local pixPtr:UInt Ptr For Local k := 0 To cellHeight - 1 pixPtr=Cast<UInt Ptr>( pixmap.PixelPtr( x,y+k ) ) For Local j := 0 To cellWidth - 1 'color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If pixPtr[j]&$FF000000>0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End #rem Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pixPtr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End #End Next atlasImg = Null tileSet = imgs End End End Function LoadSpriteSheet:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::") Local atlasTexture := Texture.Load(prefix + path, Null ) Assert( atlasTexture, " ~n ~nGameGraphics: Image " + path + " not found.~n ~n" ) Local imgs := New Image[ numFrames ] Local atlasImg := New Image( atlasTexture ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) Next atlasImg = Null Return imgs End Function Main() New AppInstance New MyWindow App.Run() End

Attachments:

1. 

   tilesetpad.png
   

2. 

   tileset.png
   

[therevillsParticipant]

Thanks Abakobo!

Note that Image and Pixmap (extends Ressource) are not GCed so you you have to .Discard() them before replacing/loosing them or you’ll leak memory. But as the are not GCed Mark won’t tell it’s not safe to point to them!?

Hmmm, I thought I read Mark had changed the GC…

Edit:
On Mark’s Blog:

This means it’s not strictly necessary to use Discard to cleanup resources any more, GC will eventually do it for you. GCCollect() is still slow so Discard is recommended in realtime situations, but on the whole it should be possible to write apps without worrying about using Discard at all now.

Monkey2 v1.1.05 now available!

[abakoboParticipant]

Hmmm, I thought I read Mark had changed the GC…

Oops my bad, was not aware of that! Might be unsafe to play with pointers then. Using a very local pointer should do the trick though.

[therevillsParticipant]

No worries! Sometimes its hard to keep up with all the changes – thanks for helping!

[Author]

Posts