Fragment shader fails with additional uniform

[DruggedBunnyParticipant]

I’m trying to produce a minimal sample for experimenting with fragment shaders, at the moment just darkening the existing pixels.

I’ve stripped down BloomShader to the bare minimum and it works fine, but as soon as I add my own uniform, I end up with a white screen (grey with the 0.1 * rgb shader applied).

What am I doing wrong here? Shader and code below, but runnable version attached…

*** Note the two ENABLE_ME comments! This is when it fails… ****

Monkey

[crayon-5cb9a3c6c4afd611347066 inline="true" ] //@renderpasses 0 uniform sampler2D m_SourceTexture; uniform vec2 m_SourceTextureSize; uniform vec2 m_SourceTextureScale; uniform float m_MousePos; varying vec2 v_TexCoord0; //@vertex attribute vec2 a_Position; //0...1 (1=viewport size) void main(){ v_TexCoord0 = a_Position * m_SourceTextureScale; gl_Position=vec4( a_Position * 2.0 - 1.0,-1.0,1.0 ); } //@fragment void main(){ vec3 pixels = texture2D (m_SourceTexture, v_TexCoord0).rgb; gl_FragColor = vec4 (pixels * 0.1, 1.0); // gl_FragColor = vec4 (1.0, 0.0, 1.0, 1.0); }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33

[crayon-5cb9a3c6c4afd611347066 inline="true" ]   //@renderpasses 0   uniform sampler2D m_SourceTexture; uniform vec2 m_SourceTextureSize; uniform vec2 m_SourceTextureScale; uniform float m_MousePos;   varying vec2 v_TexCoord0;   //@vertex   attribute vec2 a_Position; //0...1 (1=viewport size)   void main(){   v_TexCoord0 = a_Position * m_SourceTextureScale;   gl_Position=vec4( a_Position * 2.0 - 1.0,-1.0,1.0 ); }   //@fragment   void main(){   vec3 pixels = texture2D (m_SourceTexture, v_TexCoord0).rgb;   gl_FragColor = vec4 (pixels * 0.1, 1.0);   // gl_FragColor = vec4 (1.0, 0.0, 1.0, 1.0); }

[/crayon]

Monkey

[crayon-5cb9a3c6c4b03018449219 inline="true" ] #Import "<std>" #Import "<mojo3d>" #Import "assets/" Using std.. Using mojo.. Using mojo3d.. ' ---------------------------------------- ' Application name... ' ---------------------------------------- Global AppName:String = "My 3D Game" Class MagentaEffect Extends PostEffect Method New (passes:Int = 1) _shader = Shader.Open ("base") _uniforms = New UniformBlock (3) ' DISABLE_ME ' _uniforms = New UniformBlock (4) ' ENABLE_ME Passes = passes End Property Passes:Int () Return _passes Setter (passes:Int) _passes = passes End Protected Method OnRender () Override Local rsize:Vec2i = Device.Viewport.Size Local rtarget:RenderTarget = Device.RenderTarget Local rtexture:Texture = rtarget.GetColorTexture (0) If Not _target0 Or rsize.x > _target0.Size.x Or rsize.y > _target0.Size.y _texture0?.Discard () _target0?.Discard () _texture0 = New Texture (rsize.x, rsize.y, rtexture.Format, TextureFlags.Dynamic | TextureFlags.Filter) _target0 = New RenderTarget (New Texture [] (_texture0), Null) Endif Device.Shader = _shader Device.BindUniformBlock (_uniforms) Local target:RenderTarget = _target0 Local source:Texture = rtexture _uniforms.SetTexture ("SourceTexture", source) _uniforms.SetVec2f ("SourceTextureSize", source.Size) _uniforms.SetVec2f ("SourceTextureScale", Cast <Vec2f> (rsize) / Cast <Vec2f> (source.Size)) '_uniforms.SetFloat ("MousePos", 1.0) ' ENABLE_ME Device.BlendMode = BlendMode.Opaque Device.RenderPass = 0 RenderQuad () End Private Field _shader:Shader Field _uniforms:UniformBlock Field _passes:Int=4 Field _texture0:Texture Field _target0:RenderTarget End Class Game Extends Window Const SHIFT_BOOST:Float = 5.0 Field camera_boost:Float = 1.0 ' Basic 3D scene requirements... Field scene:Scene Field camera:Camera Field light:Light ' Test cube... Field cube:Model Field cubemesh:Mesh Field cubematerial:Material Field magenta:MagentaEffect Method New (title:String, width:Int, height:Int, flags:WindowFlags) Super.New (title, width, height, flags) scene = Scene.GetCurrent () ' Important! camera = New Camera ' Camera settings... camera.Near = 0.1 ' Camera position... camera.Move (0, 0, -2) camera.Rotate (0, 0, 0) light = New Light light.Move (-10, 10, -10) light.Rotate (0, 0, 0) cubemesh = Mesh.CreateBox (New Boxf (-0.5, -0.5, -0.5, 0.5, 0.5, 0.5)) ' 1 x 1 x 1 cubematerial = New PbrMaterial (Color.Lime) Cast <PbrMaterial> (cubematerial).EmissiveFactor = Color.Lime Cast <PbrMaterial> (cubematerial).MetalnessFactor = 1.0 cube = New Model (cubemesh, cubematerial) cube.Rotate (0, 45, 0) Print AppDir () magenta = New MagentaEffect (0) scene.AddPostEffect (magenta) End Method UpdateGame:Void () End Method OnRender (canvas:Canvas) Override ProcessInput () UpdateGame () cube.Rotate (0.0, 1.0, 0.0) ' Tell app to draw frame when ready... RequestRender () ' Render scene to canvas (passed to OnRender by mojo), from camera... scene.Render (canvas) End Method ProcessInput:Void () If Keyboard.KeyHit (Key.Space) Then light.CastsShadow = Not light.CastsShadow If Keyboard.KeyDown (Key.LeftShift) camera_boost = SHIFT_BOOST Else camera_boost = 1.0 Endif If Keyboard.KeyHit (Key.Escape) Then App.Terminate () If Keyboard.KeyDown (Key.A) camera.Move (0.0, 0.0, 0.1 * camera_boost) Endif If Keyboard.KeyDown (Key.Z) camera.Move (0.0, 0.0, -0.1 * camera_boost) Endif If Keyboard.KeyDown (Key.Left) camera.Rotate (0.0, 1.0, 0.0) Endif If Keyboard.KeyDown (Key.Right) camera.Rotate (0.0, -1.0, 0.0) Endif If Keyboard.KeyDown (Key.Up) camera.Rotate (1.0, 0.0, 0.0, True) Endif If Keyboard.KeyDown (Key.Down) camera.Rotate (-1.0, 0.0, 0.0, true) Endif End End Function Main () ' Windowed mode... Local width:Int = 640 Local height:Int = 480 Local flags:WindowFlags = WindowFlags.Center ' Full-screen mode (comment out above)... ' Local width:Int = 1920 ' Local height:Int = 1080 ' Local flags:WindowFlags = WindowFlags.Fullscreen New AppInstance New Game (AppName, width, height, flags) App.Run () End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227

[crayon-5cb9a3c6c4b03018449219 inline="true" ]   #Import "<std>" #Import "<mojo3d>" #Import "assets/"   Using std.. Using mojo.. Using mojo3d..   ' ---------------------------------------- ' Application name... ' ----------------------------------------   Global AppName:String = "My 3D Game"   Class MagentaEffect Extends PostEffect   Method New (passes:Int = 1) _shader = Shader.Open ("base") _uniforms = New UniformBlock (3) ' DISABLE_ME ' _uniforms = New UniformBlock (4) ' ENABLE_ME Passes = passes End Property Passes:Int () Return _passes Setter (passes:Int) _passes = passes End Protected Method OnRender () Override Local rsize:Vec2i = Device.Viewport.Size Local rtarget:RenderTarget = Device.RenderTarget Local rtexture:Texture = rtarget.GetColorTexture (0) If Not _target0 Or rsize.x > _target0.Size.x Or rsize.y > _target0.Size.y _texture0?.Discard () _target0?.Discard () _texture0 = New Texture (rsize.x, rsize.y, rtexture.Format, TextureFlags.Dynamic | TextureFlags.Filter) _target0 = New RenderTarget (New Texture [] (_texture0), Null) Endif   Device.Shader = _shader Device.BindUniformBlock (_uniforms)   Local target:RenderTarget = _target0 Local source:Texture = rtexture _uniforms.SetTexture ("SourceTexture", source) _uniforms.SetVec2f ("SourceTextureSize", source.Size) _uniforms.SetVec2f ("SourceTextureScale", Cast <Vec2f> (rsize) / Cast <Vec2f> (source.Size))   '_uniforms.SetFloat ("MousePos", 1.0) ' ENABLE_ME Device.BlendMode = BlendMode.Opaque Device.RenderPass = 0 RenderQuad () End Private Field _shader:Shader Field _uniforms:UniformBlock Field _passes:Int=4 Field _texture0:Texture Field _target0:RenderTarget End   Class Game Extends Window Const SHIFT_BOOST:Float = 5.0 Field camera_boost:Float = 1.0 ' Basic 3D scene requirements... Field scene:Scene Field camera:Camera Field light:Light ' Test cube... Field cube:Model Field cubemesh:Mesh Field cubematerial:Material Field magenta:MagentaEffect Method New (title:String, width:Int, height:Int, flags:WindowFlags) Super.New (title, width, height, flags) scene = Scene.GetCurrent () ' Important! camera = New Camera ' Camera settings... camera.Near = 0.1 ' Camera position... camera.Move (0, 0, -2) camera.Rotate (0, 0, 0) light = New Light light.Move (-10, 10, -10) light.Rotate (0, 0, 0) cubemesh = Mesh.CreateBox (New Boxf (-0.5, -0.5, -0.5, 0.5, 0.5, 0.5)) ' 1 x 1 x 1 cubematerial = New PbrMaterial (Color.Lime) Cast <PbrMaterial> (cubematerial).EmissiveFactor = Color.Lime Cast <PbrMaterial> (cubematerial).MetalnessFactor = 1.0 cube = New Model (cubemesh, cubematerial) cube.Rotate (0, 45, 0) Print AppDir () magenta = New MagentaEffect (0) scene.AddPostEffect (magenta) End Method UpdateGame:Void () End Method OnRender (canvas:Canvas) Override ProcessInput () UpdateGame () cube.Rotate (0.0, 1.0, 0.0) ' Tell app to draw frame when ready... RequestRender () ' Render scene to canvas (passed to OnRender by mojo), from camera... scene.Render (canvas)   End   Method ProcessInput:Void ()   If Keyboard.KeyHit (Key.Space) Then light.CastsShadow = Not light.CastsShadow   If Keyboard.KeyDown (Key.LeftShift) camera_boost = SHIFT_BOOST Else camera_boost = 1.0 Endif If Keyboard.KeyHit (Key.Escape) Then App.Terminate () If Keyboard.KeyDown (Key.A) camera.Move (0.0, 0.0, 0.1 * camera_boost) Endif If Keyboard.KeyDown (Key.Z) camera.Move (0.0, 0.0, -0.1 * camera_boost) Endif If Keyboard.KeyDown (Key.Left) camera.Rotate (0.0, 1.0, 0.0) Endif If Keyboard.KeyDown (Key.Right) camera.Rotate (0.0, -1.0, 0.0) Endif If Keyboard.KeyDown (Key.Up) camera.Rotate (1.0, 0.0, 0.0, True) Endif If Keyboard.KeyDown (Key.Down) camera.Rotate (-1.0, 0.0, 0.0, true) Endif   End   End Function Main () ' Windowed mode... Local width:Int = 640 Local height:Int = 480 Local flags:WindowFlags = WindowFlags.Center ' Full-screen mode (comment out above)... ' Local width:Int = 1920 ' Local height:Int = 1080 ' Local flags:WindowFlags = WindowFlags.Fullscreen New AppInstance New Game (AppName, width, height, flags) App.Run () End

[/crayon]

Attachments:

1. glsl.zip

[Mark SiblyKeymaster]

Hi,

You should leave the ctor arg to new UniformBlock as 3. Why did you change this to 4? With it set to 4 I get a runtime error trying to bind SourceTexture.

This arg refers to the ‘type’ of uniform block being created, where ‘3’ means ‘material’ uniforms, so they get a ‘m_’ prefix. Other uniform types include ‘render’ which have an ‘r_’ prefix and instance which has an ‘i_’ prefix etc. There is no real logic to these I’m just making them up as I go. It’s highly likely there will end up being lighting and scene uniform block types too with “l_” and “s_” prefixes (maybe) and all these uniform block types will eventually get enumed preventing lots of confusion here. The base class of PostEffect should probably be the one creating the uniform block anyway, but the PostEffect system is way underdeveoped and I’m really just experimenting with the shaders right now so it’s likely to stay this way for a while.

Anyway, leaving ctor uniform block type as 3 and SetFloat mousepos enabled I can run the demo and get the same dodgy greenish cube, but shader isn’t using mouse pos yet so that’s what I’d expect.

[DruggedBunnyParticipant]

Hi Mark, I was kinda guessing that it related to the number of uniforms in the block! As in, for each SetFloat, SetVec3f, etc, I’d need another entry in the ‘block’. Obviously misunderstood this!

Number 3 happened to tie in with:

Monkey

[crayon-5cb9a3c6cff21990143966 inline="true" ] _uniforms.SetTexture ("SourceTexture", source) _uniforms.SetVec2f ("SourceTextureSize", source.Size) _uniforms.SetVec2f ("SourceTextureScale", Cast <Vec2f> (rsize) / Cast <Vec2f> (source.Size))

1 2 3 4 5 6

[crayon-5cb9a3c6cff21990143966 inline="true" ]   _uniforms.SetTexture ("SourceTexture", source) _uniforms.SetVec2f ("SourceTextureSize", source.Size) _uniforms.SetVec2f ("SourceTextureScale", Cast <Vec2f> (rsize) / Cast <Vec2f> (source.Size))

[/crayon]

Setting to 3 does indeed work! (Yes, dodgy green cube/no mouse position is expected at this point.)

Thanks for the explanation.

[DruggedBunnyParticipant]

That’s what I was after! Working nicely.

Monkey

[crayon-5cb9a3c6d2437794671083 inline="true" ] //@renderpasses 0 uniform sampler2D m_SourceTexture; uniform vec2 m_SourceTextureSize; uniform vec2 m_SourceTextureScale; uniform float m_MousePos; varying vec2 v_TexCoord0; //@vertex attribute vec2 a_Position; //0...1 (1=viewport size) void main(){ v_TexCoord0 = a_Position * m_SourceTextureScale; gl_Position=vec4( a_Position * 2.0 - 1.0,-1.0,1.0 ); } //@fragment void main(){ vec3 pixels = texture2D (m_SourceTexture, v_TexCoord0).rgb; gl_FragColor = vec4 (pixels * m_MousePos, 1.0); }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32

[crayon-5cb9a3c6d2437794671083 inline="true" ]   //@renderpasses 0   uniform sampler2D m_SourceTexture; uniform vec2 m_SourceTextureSize; uniform vec2 m_SourceTextureScale; uniform float m_MousePos;   varying vec2 v_TexCoord0;   //@vertex   attribute vec2 a_Position; //0...1 (1=viewport size)   void main(){   v_TexCoord0 = a_Position * m_SourceTextureScale;   gl_Position=vec4( a_Position * 2.0 - 1.0,-1.0,1.0 ); }   //@fragment   void main(){   vec3 pixels = texture2D (m_SourceTexture, v_TexCoord0).rgb;   gl_FragColor = vec4 (pixels * m_MousePos, 1.0);   }

[/crayon]

Monkey

[crayon-5cb9a3c6d243c354161628 inline="true" ] #Import "<std>" #Import "<mojo3d>" #Import "assets/" Using std.. Using mojo.. Using mojo3d.. ' ---------------------------------------- ' Application name... ' ---------------------------------------- Global AppName:String = "My 3D Game" Class MagentaEffect Extends PostEffect Method New (passes:Int = 1) _shader = Shader.Open ("base") _uniforms = New UniformBlock (3) ' DISABLE_ME ' _uniforms = New UniformBlock (4) ' ENABLE_ME ' Passes = passes End 'Property Passes:Int () ' Return _passes 'Setter (passes:Int) ' _passes = passes 'End Protected Method OnRender () Override Local rsize:Vec2i = Device.Viewport.Size Local rtarget:RenderTarget = Device.RenderTarget Local rtexture:Texture = rtarget.GetColorTexture (0) If Not _target0 Or rsize.x > _target0.Size.x Or rsize.y > _target0.Size.y _texture0?.Discard () _target0?.Discard () _texture0 = New Texture (rsize.x, rsize.y, rtexture.Format, TextureFlags.Dynamic | TextureFlags.Filter) _target0 = New RenderTarget (New Texture [] (_texture0), Null) Endif Device.Shader = _shader Device.BindUniformBlock (_uniforms) Local target:RenderTarget = _target0 Local source:Texture = rtexture _uniforms.SetTexture ("SourceTexture", source) _uniforms.SetVec2f ("SourceTextureSize", source.Size) _uniforms.SetVec2f ("SourceTextureScale", Cast <Vec2f> (rsize) / Cast <Vec2f> (source.Size)) _uniforms.SetFloat ("MousePos", Float (Mouse.Y) / Device.Viewport.Height) Device.BlendMode = BlendMode.Opaque Device.RenderPass = 0 RenderQuad () End Private Field _shader:Shader Field _uniforms:UniformBlock 'Field _passes:Int=4 Field _texture0:Texture Field _target0:RenderTarget End Class Game Extends Window Const SHIFT_BOOST:Float = 5.0 Field camera_boost:Float = 1.0 ' Basic 3D scene requirements... Field scene:Scene Field camera:Camera Field light:Light ' Test cube... Field cube:Model Field cubemesh:Mesh Field cubematerial:Material Field magenta:MagentaEffect Method New (title:String, width:Int, height:Int, flags:WindowFlags) Super.New (title, width, height, flags) scene = Scene.GetCurrent () ' Important! camera = New Camera ' Camera settings... camera.Near = 0.1 ' Camera position... camera.Move (0, 0, -2) camera.Rotate (0, 0, 0) light = New Light light.Move (-10, 10, -10) light.Rotate (0, 0, 0) cubemesh = Mesh.CreateBox (New Boxf (-0.5, -0.5, -0.5, 0.5, 0.5, 0.5)) ' 1 x 1 x 1 cubematerial = New PbrMaterial (Color.Lime) Cast <PbrMaterial> (cubematerial).EmissiveFactor = Color.Lime Cast <PbrMaterial> (cubematerial).MetalnessFactor = 1.0 cube = New Model (cubemesh, cubematerial) cube.Rotate (0, 45, 0) Print AppDir () magenta = New MagentaEffect (0) scene.AddPostEffect (magenta) End Method UpdateGame:Void () End Method OnRender (canvas:Canvas) Override ProcessInput () UpdateGame () cube.Rotate (0.0, 1.0, 0.0) ' Tell app to draw frame when ready... RequestRender () ' Render scene to canvas (passed to OnRender by mojo), from camera... scene.Render (canvas) canvas.DrawText ("Mouse up/down to change brightness", 0, 0) End Method ProcessInput:Void () If Keyboard.KeyHit (Key.Space) Then light.CastsShadow = Not light.CastsShadow If Keyboard.KeyDown (Key.LeftShift) camera_boost = SHIFT_BOOST Else camera_boost = 1.0 Endif If Keyboard.KeyHit (Key.Escape) Then App.Terminate () If Keyboard.KeyDown (Key.A) camera.Move (0.0, 0.0, 0.1 * camera_boost) Endif If Keyboard.KeyDown (Key.Z) camera.Move (0.0, 0.0, -0.1 * camera_boost) Endif If Keyboard.KeyDown (Key.Left) camera.Rotate (0.0, 1.0, 0.0) Endif If Keyboard.KeyDown (Key.Right) camera.Rotate (0.0, -1.0, 0.0) Endif If Keyboard.KeyDown (Key.Up) camera.Rotate (1.0, 0.0, 0.0, True) Endif If Keyboard.KeyDown (Key.Down) camera.Rotate (-1.0, 0.0, 0.0, true) Endif End End Function Main () ' Windowed mode... Local width:Int = 640 Local height:Int = 480 Local flags:WindowFlags = WindowFlags.Center ' Full-screen mode (comment out above)... ' Local width:Int = 1920 ' Local height:Int = 1080 ' Local flags:WindowFlags = WindowFlags.Fullscreen New AppInstance New Game (AppName, width, height, flags) App.Run () End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230

[crayon-5cb9a3c6d243c354161628 inline="true" ]   #Import "<std>" #Import "<mojo3d>" #Import "assets/"   Using std.. Using mojo.. Using mojo3d..   ' ---------------------------------------- ' Application name... ' ----------------------------------------   Global AppName:String = "My 3D Game"   Class MagentaEffect Extends PostEffect   Method New (passes:Int = 1) _shader = Shader.Open ("base") _uniforms = New UniformBlock (3) ' DISABLE_ME ' _uniforms = New UniformBlock (4) ' ENABLE_ME ' Passes = passes End 'Property Passes:Int () ' Return _passes 'Setter (passes:Int) ' _passes = passes 'End Protected Method OnRender () Override Local rsize:Vec2i = Device.Viewport.Size Local rtarget:RenderTarget = Device.RenderTarget Local rtexture:Texture = rtarget.GetColorTexture (0) If Not _target0 Or rsize.x > _target0.Size.x Or rsize.y > _target0.Size.y _texture0?.Discard () _target0?.Discard () _texture0 = New Texture (rsize.x, rsize.y, rtexture.Format, TextureFlags.Dynamic | TextureFlags.Filter) _target0 = New RenderTarget (New Texture [] (_texture0), Null) Endif   Device.Shader = _shader Device.BindUniformBlock (_uniforms)   Local target:RenderTarget = _target0 Local source:Texture = rtexture _uniforms.SetTexture ("SourceTexture", source) _uniforms.SetVec2f ("SourceTextureSize", source.Size) _uniforms.SetVec2f ("SourceTextureScale", Cast <Vec2f> (rsize) / Cast <Vec2f> (source.Size))   _uniforms.SetFloat ("MousePos", Float (Mouse.Y) / Device.Viewport.Height)   Device.BlendMode = BlendMode.Opaque Device.RenderPass = 0 RenderQuad () End Private Field _shader:Shader Field _uniforms:UniformBlock 'Field _passes:Int=4 Field _texture0:Texture Field _target0:RenderTarget End   Class Game Extends Window Const SHIFT_BOOST:Float = 5.0 Field camera_boost:Float = 1.0 ' Basic 3D scene requirements... Field scene:Scene Field camera:Camera Field light:Light ' Test cube... Field cube:Model Field cubemesh:Mesh Field cubematerial:Material Field magenta:MagentaEffect Method New (title:String, width:Int, height:Int, flags:WindowFlags) Super.New (title, width, height, flags) scene = Scene.GetCurrent () ' Important! camera = New Camera ' Camera settings... camera.Near = 0.1 ' Camera position... camera.Move (0, 0, -2) camera.Rotate (0, 0, 0) light = New Light light.Move (-10, 10, -10) light.Rotate (0, 0, 0) cubemesh = Mesh.CreateBox (New Boxf (-0.5, -0.5, -0.5, 0.5, 0.5, 0.5)) ' 1 x 1 x 1 cubematerial = New PbrMaterial (Color.Lime) Cast <PbrMaterial> (cubematerial).EmissiveFactor = Color.Lime Cast <PbrMaterial> (cubematerial).MetalnessFactor = 1.0 cube = New Model (cubemesh, cubematerial) cube.Rotate (0, 45, 0) Print AppDir () magenta = New MagentaEffect (0) scene.AddPostEffect (magenta) End Method UpdateGame:Void () End Method OnRender (canvas:Canvas) Override ProcessInput () UpdateGame () cube.Rotate (0.0, 1.0, 0.0) ' Tell app to draw frame when ready... RequestRender () ' Render scene to canvas (passed to OnRender by mojo), from camera... scene.Render (canvas)   canvas.DrawText ("Mouse up/down to change brightness", 0, 0) End   Method ProcessInput:Void ()   If Keyboard.KeyHit (Key.Space) Then light.CastsShadow = Not light.CastsShadow   If Keyboard.KeyDown (Key.LeftShift) camera_boost = SHIFT_BOOST Else camera_boost = 1.0 Endif If Keyboard.KeyHit (Key.Escape) Then App.Terminate () If Keyboard.KeyDown (Key.A) camera.Move (0.0, 0.0, 0.1 * camera_boost) Endif If Keyboard.KeyDown (Key.Z) camera.Move (0.0, 0.0, -0.1 * camera_boost) Endif If Keyboard.KeyDown (Key.Left) camera.Rotate (0.0, 1.0, 0.0) Endif If Keyboard.KeyDown (Key.Right) camera.Rotate (0.0, -1.0, 0.0) Endif If Keyboard.KeyDown (Key.Up) camera.Rotate (1.0, 0.0, 0.0, True) Endif If Keyboard.KeyDown (Key.Down) camera.Rotate (-1.0, 0.0, 0.0, true) Endif   End   End Function Main () ' Windowed mode... Local width:Int = 640 Local height:Int = 480 Local flags:WindowFlags = WindowFlags.Center ' Full-screen mode (comment out above)... ' Local width:Int = 1920 ' Local height:Int = 1080 ' Local flags:WindowFlags = WindowFlags.Fullscreen New AppInstance New Game (AppName, width, height, flags) App.Run () End

[/crayon]

[DruggedBunnyParticipant]

EDIT: Skip this and cut to the chase, below!

This appears to be a general GLSL query, rather than MX2-specific, so anyone with some background welcome, doesn’t have to be Mark!

I’m trying to get an old greyscale shader working, whereby an integer Mode uniform is passed to set the greyscale algorithm used.

This used to work (in OpenB3D):

Monkey

[crayon-5cb9a3c6dae70214967998 inline="true" ] switch (int(mode)) // NB. Used to be a float! Tried changing back to this, but no difference... { case 0: // Default RGB break; case 1: // Lightness rgb = (max(max(pixel.r, pixel.g), pixel.b) + min(min(pixel.r, pixel.g), pixel.b)) / 2.0; pixel.r = rgb; pixel.g = rgb; pixel.b = rgb; break; ...etc

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22

[crayon-5cb9a3c6dae70214967998 inline="true" ]   switch (int(mode)) // NB. Used to be a float! Tried changing back to this, but no difference... { case 0: // Default RGB break; case 1: // Lightness rgb = (max(max(pixel.r, pixel.g), pixel.b) + min(min(pixel.r, pixel.g), pixel.b)) / 2.0; pixel.r = rgb; pixel.g = rgb; pixel.b = rgb; break; ...etc

[/crayon]

Note the break lines.

… but now it seems as if it always exits the switch at the first break, regardless of the value of m_Mode!

For example, this always exits at case 0 (no greyscale applied) if I enable the break within that case, even if m_Mode is set to 1 or above (ie. it shouldn’t even hit case 0):

Monkey

[crayon-5cb9a3c6dae76139005252 inline="true" ] switch (m_Mode) { case 0: // Default RGB //break; // Disabled, jumps through to case 3 // (as if going through all cases and // simply ending up there) // Enabled, always skips the rest, even // though m_Mode is set to higher value! case 1: // Lightness rgb = (max(max(pixel.r, pixel.g), pixel.b) + min(min(pixel.r, pixel.g), pixel.b)) / 2.0; pixel.r = rgb; pixel.g = rgb; pixel.b = rgb; //break; case 2: // Average rgb = (pixel.r + pixel.g + pixel.b) / 3.0; pixel.r = rgb; pixel.g = rgb; pixel.b = rgb; //break; case 3: // Luminosity rgb = (pixel.r * 0.21) + (pixel.g * 0.72) + (pixel.b * 0.07); pixel.r = rgb; pixel.g = rgb; pixel.b = rgb; pixel = vec3 (1.0, 0.0, 0.0); // *** TEST - RED PIXELS *** }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53

[crayon-5cb9a3c6dae76139005252 inline="true" ]   switch (m_Mode) { case 0: // Default RGB //break; // Disabled, jumps through to case 3 // (as if going through all cases and // simply ending up there) // Enabled, always skips the rest, even // though m_Mode is set to higher value!   case 1: // Lightness rgb = (max(max(pixel.r, pixel.g), pixel.b) + min(min(pixel.r, pixel.g), pixel.b)) / 2.0; pixel.r = rgb; pixel.g = rgb; pixel.b = rgb; //break; case 2: // Average rgb = (pixel.r + pixel.g + pixel.b) / 3.0; pixel.r = rgb; pixel.g = rgb; pixel.b = rgb;   //break; case 3: // Luminosity rgb = (pixel.r * 0.21) + (pixel.g * 0.72) + (pixel.b * 0.07); pixel.r = rgb; pixel.g = rgb; pixel.b = rgb;   pixel = vec3 (1.0, 0.0, 0.0); // *** TEST - RED PIXELS *** }

[/crayon]

Yet without the break, it seems to end up at the last breaking case (the final case if there is no earlier break). So with no breaks enabled, the screen always ends up red (per the last line there), even if m_Mode is < 3.

Example is attached — anyone got any idea what’s going wrong here? Is it some later GLSL spec that works differently?? How do I get it to just select a path based on m_Mode?

Note that m_Mode is set by this line (0-3, where 0 is normal RGB), and it can then be changed via -/+ on the main keyboard:

Monkey

[crayon-5cb9a3c6dae7a664488845 inline="true" ] greyscale = New GreyscaleEffect (1)

1 2 3 4

[crayon-5cb9a3c6dae7a664488845 inline="true" ]   greyscale = New GreyscaleEffect (1)

[/crayon]

Help!

Attachments:

1. greyscale.zip

[DruggedBunnyParticipant]

It seems my m_Mode value isn’t being received by the shader… what am I doing wrong here?

Even explicitly calling…

Monkey

[crayon-5cb9a3c6e027a090276622 inline="true" ] uniforms.SetInt ("Mode", 1)

1 2 3 4

[crayon-5cb9a3c6e027a090276622 inline="true" ]   uniforms.SetInt ("Mode", 1)

[/crayon]

… results in m_Mode apparently being zero. This still produces a black screen instead of the magenta I’d expect:

Monkey

[crayon-5cb9a3c6e027f575028998 inline="true" ] ... uniform int m_Mode; ... //@fragment void main(){ vec3 pixel = texture2D (m_SourceTexture, v_TexCoord0).rgb; if (m_Mode == 1) { gl_FragColor = vec4(1.0, 0.0, 1.0, 1.0); } }

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20

[crayon-5cb9a3c6e027f575028998 inline="true" ]   ... uniform int m_Mode;   ...   //@fragment   void main(){   vec3 pixel = texture2D (m_SourceTexture, v_TexCoord0).rgb;   if (m_Mode == 1) { gl_FragColor = vec4(1.0, 0.0, 1.0, 1.0); }   }

[/crayon]

Runnable version attached…

Attachments:

1. uniformzero.zip

[DruggedBunnyParticipant]

EDIT: To see that fail more clearly, amend the shader check to:

Monkey

[crayon-5cb9a3c6e2fcc148672618 inline="true" ] if (m_Mode == 0)

1 2 3 4

[crayon-5cb9a3c6e2fcc148672618 inline="true" ]   if (m_Mode == 0)

[/crayon]

… which results in magenta, even though m_Mode should be 1, it is in fact 0.

I assume I’m doing something stupid!

[GwenelParticipant]

This gives an error for me, but maybe that gives a away a clue for you or someone else

“GL_VERSION=2.1 ATI 10.4.14
Renderer is using deferred rendering”

[DruggedBunnyParticipant]

I don’t think that’s an error, I get that too, it’s just mojo3d printing out version info while WIP, I believe.

[DruggedBunnyParticipant]

I’m still stuck on this — trying to set an int in the shader, in the existing uniform block, it’s always 0 on the GLSL side. (Have tried checking for both m_Mode and i_Mode!)

I’ve been trying to add another UniformBlock, but I get the impression that’s not the way to handle it. (Am I right in thinking you just have to set the largest data type that’s going to be passed?)

Tried a new UniformBlock using both types 1 (scalar) and 9 (int), but scalar causes textures not to be found (think because it effectively replaces the existing block ?), while int just crashes when I try to call SetInt.

(Assume scalar is same as float?)

So I’m back to what I posted above (see code), which just passes 0 all the time!

[Mark SiblyKeymaster]

Looks like a bug in mx2’s handling of int uniforms – possible fix now pushed to develop.

Also, you never seem to use debug mode! I know it’s a bit rough, but many of your issues always cause some kind of debug error for me which makes them quite easy to find…

[DruggedBunnyParticipant]

I don’t generally use Debug because it usually crashes Ted to desktop on ‘7, depending on what you click. (I admit I’m a Print debugger that uses Debug rarely anyway.)

I’ll try remember to use it before posting bug reports!

Will give SetInt a whirl today, many thanks.

By the way, the debug crash error was traced by Ferdi to some degree (but see later comment from same):

Is your Ted2Go crashing in Window 7 when debugging?

I’d come to a similar conclusion on an epic 6-hour debugger-debug session, but it seemed to be failing in the underlying C++ call for WriteStdIn, and as far as I could tell was being called correctly, so sort of lost the trail at that, and I knew you didn’t have 7 to be able to follow it up.

[Author]

Posts