Image Filtering

[peterigzParticipant]

I’ve noticed that images rendered in monkey2 seem a little more blurry then I’m used to like there’s too much filtering going on. I’ve tried with and without the filter and mipmap flags when loading the image but it doesn’t seem to make any difference. Also setting TextureFilteringEnabled to false on the canvas doesn’t seem to make a difference either. See below for image to compare with Blitzmax which I think looks a lot better and “cripser”. You may not think there’s much difference but it is quite apparent to me

(left is monkey2)

Is there anything I can check or try to get things looking more crisper?

[wiebowParticipant]

TextureFilteringEnabled set to false should make a huge difference. You need to call it at each render though.

[peterigzParticipant]

I have nice crispy particles again, I found the reason but I’m still a bit confused. I have a function to load a sprite with frames of animation:

Monkey

Function LoadFrames:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, padded:Bool = False, flags:TextureFlags = TextureFlags.Filter|TextureFlags.Mipmap, shader:Shader = Null)

1	Function LoadFrames:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, padded:Bool = False, flags:TextureFlags = TextureFlags.Filter|TextureFlags.Mipmap, shader:Shader = Null)

So if I call that function with:

Monkey

shape.image = tlShape.LoadFrames(url, frames, width, height, flags)

1	shape.image = tlShape.LoadFrames(url, frames, width, height, flags)

Where flags is set to “TextureFlags.Filter” only, it seemed to just go ahead and assign both flags anyway, which is odd, I’m not sure why as it gets overridden properly inside the mojo lib.

So I’ve fixed it to just set one filter by default:

Monkey

Function LoadFrames:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, padded:Bool = False, flags:TextureFlags = TextureFlags.Filter, shader:Shader = Null)

1	Function LoadFrames:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, padded:Bool = False, flags:TextureFlags = TextureFlags.Filter, shader:Shader = Null)

[Simon ArmstrongParticipant]

I have had issues with monkey2 flag handling on Pi. I wonder if they are related.

This code gives different output on Mac and Pi (b=1 on Pi).

 

Monkey

enum Bits One=1 Ugly=$80000000 end function Main() print "hello" print int(Bits.One) print int(Bits.Ugly) local a:=Bits.One local b:=(a&Bits.Ugly)<>null print b End

1 2 3 4 5 6 7 8 9 10 11 12 13 14

enum Bits One=1 Ugly=$80000000 end   function Main() print "hello" print int(Bits.One) print int(Bits.Ugly) local a:=Bits.One local b:=(a&Bits.Ugly)<>null print b End

[coconParticipant]

This might be a case of OpenGL library issue (changing the texture state somewhere).

(search something like: SDL textures appear blurred)

https://www.opengl.org/discussion_boards/showthread.php/166337-Blurred-textures-need-it-sharp

[Mark SiblyKeymaster]

> shape.image = tlShape.LoadFrames(url, frames, width, height, flags)

You’re missing the ‘padding’ param. Should implicit enum->bool be disallowed?

If that’s not it, can you post the lib code?

[peterigzParticipant]

You’re missing the ‘padding’ param. Should implicit enum->bool be disallowed?

Doh! That was the reason, can’t believe I missed that! I should know by now to look for the obvious thing first, thanks

[ImmutableOctetParticipant]

@Mark Sibly: Yeah, that may be a wise choice.

Although, I really have to question why enumerators can even be implicitly casted to integers. It can’t be done the other way around, so shouldn’t you have to add an explicit cast here as well? That would kill two birds with one stone.

[Author]

Posts