Is Rect.Centered() Correct ?

[DiffrenzyKeymaster]

Monkey

Function CenterThis:Rectf(me:Rectf, r:Rectf ) Local x:=(me.Width-r.Width)/2+me.min.x Local y:=(me.Height-r.Height)/2+me.min.y Return New Rectf( x,y,x+r.Width,y+r.Height ) End Function CenterOther:Rectf(me:Rectf, r:Rectf ) Local x:=(r.Width-me.Width)/2+r.min.x Local y:=(r.Height-me.Height)/2+r.min.y Return New Rectf( x,y,x+me.Width,y+me.Height ) End

1 2 3 4 5 6 7 8 9 10 11 12

Function CenterThis:Rectf(me:Rectf, r:Rectf ) Local x:=(me.Width-r.Width)/2+me.min.x Local y:=(me.Height-r.Height)/2+me.min.y Return New Rectf( x,y,x+r.Width,y+r.Height ) End     Function CenterOther:Rectf(me:Rectf, r:Rectf ) Local x:=(r.Width-me.Width)/2+r.min.x Local y:=(r.Height-me.Height)/2+r.min.y Return New Rectf( x,y,x+me.Width,y+me.Height ) End

Gives what I expect to be the result, which in turn would make Rect.Centered (based on CenterThis) :

Monkey

Method Centered:Rect( r:Rect ) Local x:=(Width-r.Width)/2+min.x Local y:=(Height-r.Height)/2+min.y Return New Rect( x,y,x+r.Width,y+r.Height ) End

1 2 3 4 5

Method Centered:Rect( r:Rect ) Local x:=(Width-r.Width)/2+min.x Local y:=(Height-r.Height)/2+min.y Return New Rect( x,y,x+r.Width,y+r.Height ) End

[DiffrenzyKeymaster]

.

[Mark SiblyKeymaster]

I think it’s right – centering a rect doesn’t change its size, just it’s location.

[DiffrenzyKeymaster]

Monkey

I think it’s right – centering a rect doesn’t change its size, just it’s location.

1	I think it’s right – centering a rect doesn’t change its size, just it’s location.

which is why it need to return r’s size not Self.Width and Height I think

[Mark SiblyKeymaster]

That *would* change self’s size though, it’d change it to r’s size!

Monkey

#Import "<std>" Using std.. Function Main() Local r1:=New Recti( 0,0,20,30 ) Print r1.Size Local r2:=New Recti( 100,100,140,160 ) r1=r1.Centered( r2 ) 'center r1 within r2 - only moves it. Print r1.Size 'same size! End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17

#Import "<std>"   Using std..   Function Main()   Local r1:=New Recti( 0,0,20,30 ) Print r1.Size Local r2:=New Recti( 100,100,140,160 ) r1=r1.Centered( r2 ) 'center r1 within r2 - only moves it. Print r1.Size 'same size! End

[DiffrenzyKeymaster]

Same size, but wrong location!

Print r1.Left  ( this should be 100 + (40-20)/2  = 110 but is 10 )
Print r1.Top ( this should be 100 + (60-30)/2  = 115 but is 15 )

[EDITED]

[Mark SiblyKeymaster]

> Same size, but wrong location!

Ha, yes! Will fix.

[DiffrenzyKeymaster]

Great, thanks

[Author]

Posts