Maybe something wrong with Generics?

[JesseParticipant]

the Code below was working with the previous version of Mx2 but now it doesn’t recognize the generic class new.  As I am no expert I don’t know if it’s my code or a bug with generics. by the way tha’s Mark’s Deque module:

 

Monkey

Class Deque<T> Field _data:T[] Field _capacity:int Field _first:Int Field _last:Int Method New() _data = New T[4] End Method New( arr:T[] ) _data=arr _capacity=_data.Length _last=_capacity End Method Clear:Void() If _first<=_last For Local i:=_first Until _last _data[i]=NIL Next Else For Local i:=0 Until _last _data[i]=NIL Next For Local i := _first Until _capacity _data[i]=NIL Next Endif _first=0 _last=0 End Method Length:Int() If _last>=_first Return _last-_first Return _capacity-_first+_last End Method IsEmpty:Bool() Return _first=_last End Method ToArray:T[]() Local data:T[] = new T[Length()] If _first<=_last For Local i:=_first Until _last data[i-_first]=_data[i] Next Else Local n:=_capacity-_first For Local i:=0 Until n data[i]=_data[_first+i] Next For Local i:=0 Until _last data[n+i]=_data[i] Next Endif Return data End Method ObjectEnumerator:Enumerator<T>() Return New Enumerator<T>( Self ) End Method Get:T( index:Int ) #If CONFIG="debug" If index<0 Or index>=Length Error "Illegal deque index" #Endif Return _data[(index+_first)Mod _capacity] End Method Set:Void( index:Int,value:T ) #If CONFIG="debug" If index<0 Or index>=Length Error "Illegal deque index" #Endif _data[(index+_first)Mod _capacity]=value End Method PushFirst:Void( value:T ) If Length()+1>=_capacity Grow() _first-=1 If _first<0 _first=_capacity-1 _data[_first]=value End Method PushLast:Void( value:T ) If Length()+1>=_capacity Grow() _data[_last]=value _last+=1 If _last=_capacity _last=0 End Method PopFirst:T() #If CONFIG="debug" If IsEmpty Error "Illegal operation on empty deque" #Endif Local v:=_data[_first] _data[_first]=NIL _first+=1 If _first=_capacity _first=0 Return v End Method PopLast:T() #If CONFIG="debug" If IsEmpty Error "Illegal operation on empty deque" #Endif If _last=0 _last=_capacity _last-=1 Local v:=_data[_last] _data[_last]=NIL Return v End Method First:T() #If CONFIG="debug" If IsEmpty Error "Illegal operation on empty deque" #Endif Return _data[_first] End Method Last:T() #If CONFIG="debug" If IsEmpty Error "Illegal operation on empty deque" #Endif Return _data[(_last-1)Mod _capacity] End Private Global NIL:T Method Grow:Void() Local data:=New T[_capacity*2+10] If _first<=_last For Local i:=_first Until _last data[i-_first]=_data[i] Next _last-=_first _first=0 Else Local n:=_capacity-_first For Local i:=0 Until n data[i]=_data[_first+i] Next For Local i:=0 Until _last data[n+i]=_data[i] Next _last+=n _first=0 Endif _capacity=data.Length _data=data End End Class Enumerator<T> Method New( deque:Deque<T> ) _deque=deque End Method HasNext:Bool() Return _index<_deque.Length()-1 End Method NextObject:T() _index+=1 Return _deque.Get( _index ) End Private Field _deque:Deque<T> Field _index:Int=-1 End Class IntDeque Extends Deque<Int> Method New() End Method New( data:Int[] ) Super.New( data ) End End Class FloatDeque Extends Deque<Float> Method New() End Method New( data:Float[] ) Super.New( data ) End End Class StringDeque Extends Deque<String> Method New() End Method New( data:String[] ) Super.New( data ) End End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213

Class Deque<T> Field _data:T[] Field _capacity:int Field _first:Int Field _last:Int   Method New() _data = New T[4] End Method New( arr:T[] ) _data=arr _capacity=_data.Length _last=_capacity End   Method Clear:Void() If _first<=_last For Local i:=_first Until _last _data[i]=NIL Next Else For Local i:=0 Until _last _data[i]=NIL Next For Local i := _first Until _capacity _data[i]=NIL Next Endif _first=0 _last=0 End Method Length:Int() If _last>=_first Return _last-_first Return _capacity-_first+_last End Method IsEmpty:Bool() Return _first=_last End Method ToArray:T[]() Local data:T[] = new T[Length()] If _first<=_last For Local i:=_first Until _last data[i-_first]=_data[i] Next Else Local n:=_capacity-_first For Local i:=0 Until n data[i]=_data[_first+i] Next For Local i:=0 Until _last data[n+i]=_data[i] Next Endif Return data End Method ObjectEnumerator:Enumerator<T>() Return New Enumerator<T>( Self ) End Method Get:T( index:Int ) #If CONFIG="debug" If index<0 Or index>=Length Error "Illegal deque index" #Endif Return _data[(index+_first)Mod _capacity] End Method Set:Void( index:Int,value:T ) #If CONFIG="debug" If index<0 Or index>=Length Error "Illegal deque index" #Endif _data[(index+_first)Mod _capacity]=value End Method PushFirst:Void( value:T ) If Length()+1>=_capacity Grow() _first-=1 If _first<0 _first=_capacity-1 _data[_first]=value End Method PushLast:Void( value:T ) If Length()+1>=_capacity Grow() _data[_last]=value _last+=1 If _last=_capacity _last=0 End Method PopFirst:T() #If CONFIG="debug" If IsEmpty Error "Illegal operation on empty deque" #Endif Local v:=_data[_first] _data[_first]=NIL _first+=1 If _first=_capacity _first=0 Return v End Method PopLast:T() #If CONFIG="debug" If IsEmpty Error "Illegal operation on empty deque" #Endif If _last=0 _last=_capacity _last-=1 Local v:=_data[_last] _data[_last]=NIL Return v End Method First:T() #If CONFIG="debug" If IsEmpty Error "Illegal operation on empty deque" #Endif Return _data[_first] End Method Last:T() #If CONFIG="debug" If IsEmpty Error "Illegal operation on empty deque" #Endif Return _data[(_last-1)Mod _capacity] End Private Global NIL:T Method Grow:Void() Local data:=New T[_capacity*2+10] If _first<=_last For Local i:=_first Until _last data[i-_first]=_data[i] Next _last-=_first _first=0 Else Local n:=_capacity-_first For Local i:=0 Until n data[i]=_data[_first+i] Next For Local i:=0 Until _last data[n+i]=_data[i] Next _last+=n _first=0 Endif _capacity=data.Length _data=data End   End   Class Enumerator<T>   Method New( deque:Deque<T> ) _deque=deque End Method HasNext:Bool() Return _index<_deque.Length()-1 End Method NextObject:T() _index+=1 Return _deque.Get( _index ) End Private Field _deque:Deque<T> Field _index:Int=-1   End   Class IntDeque Extends Deque<Int>   Method New() End Method New( data:Int[] ) Super.New( data ) End   End   Class FloatDeque Extends Deque<Float>   Method New() End Method New( data:Float[] ) Super.New( data ) End   End   Class StringDeque Extends Deque<String>   Method New() End Method New( data:String[] ) Super.New( data ) End   End

[Mark SiblyKeymaster]

What error do you get?

How do I reproduce the error?

Also, there’s a version of Deque coming to std soon..

[JesseParticipant]

Sorry Mark it tells me method super.new() in the extended type is undeclared:

/Users/ayoitseve/Desktop/monkeypatrol/src/deque.monkey2 [209] : Error : Can’t find overload for ‘new(…)’ with argument types (string[])
/Users/ayoitseve/Desktop/monkeypatrol/src/deque.monkey2 [198] : Error : Can’t find overload for ‘new(…)’ with argument types (float[])
/Users/ayoitseve/Desktop/monkeypatrol/src/deque.monkey2 [187] : Error : Can’t find overload for ‘new(…)’ with argument types (int[])

[JesseParticipant]

I am trying to isolate the code to post it but everything seems to work good. I can’t duplicate the error with the code I wrote. It’s working fine. I can’t understand is why the error now and why in those files because I am not using Int, Float or string Deque and it shouldn’t be a reason to point out those errors.

[JesseParticipant]

well, I deleted the int, float and string classes and I was able to keep using the module. But I still don’t know why the error. as all I did was just remove those three classes and it worked. no other code edit on any of the other files.

[Author]

Posts