Mojox textview, selecting with shift behaviour

[coconParticipant]

Holding Shift and clicking in order to select text, seems to work only the key repeat events.

You can see the behaviour here:
https://1drv.ms/v/s!AquVr9J7xRcsgXjK6aEadQLY1AHJ

[nerobotParticipant]

I think we get double click logic here.

Try to click slower.

[coconParticipant]

Yes, the reason is that the boolean condition that would allow the fix happen, is valid only for repeat events. Specifically is the way that modifier keys are processed.

Monkey

textview.monkey2 - line 1201 Method OnContentMouseEvent( event:MouseEvent ) Override Select event.Type Case EventType.MouseDown Select event.Clicks Case 1 _cursor=CharAtPoint( event.Location ) ' This one... If Not (event.Modifiers & Modifier.Shift) _anchor=_cursor

1 2 3 4 5 6 7 8 9 10

textview.monkey2 - line 1201 Method OnContentMouseEvent( event:MouseEvent ) Override Select event.Type Case EventType.MouseDown Select event.Clicks Case 1 _cursor=CharAtPoint( event.Location ) ' This one... If Not (event.Modifiers & Modifier.Shift) _anchor=_cursor

After examining these *.monkey2 files in order to understand the inner workings: view, window, app, textview. The best fix for this problem, is this one.

Monkey

' Previous Implementation ' If Not (event.Modifiers & Modifier.Shift) _anchor=_cursor ' New One If Keyboard.KeyDown(Key.LeftShift) Or Keyboard.KeyDown(Key.RightShift) ' nothing Else _anchor=_cursor End

1 2 3 4 5 6 7 8 9

' Previous Implementation ' If Not (event.Modifiers & Modifier.Shift) _anchor=_cursor ' New One If Keyboard.KeyDown(Key.LeftShift) Or Keyboard.KeyDown(Key.RightShift) ' nothing Else _anchor=_cursor End

Unfortunately I have to bypass the event mechanism and do a dirty hack (ignore the event checks) and rely on the Keyboard class. I am not proud of the solution, but it will work for now, until I find something else better better.

 

P.S. Some notes on this subject _________________________________________________

Regarding the proper “textview solution” would be fixed like this: app.monkey2 line 720

Monkey

If kevent->repeat_ SendKeyEvent( EventType.KeyRepeat ) Else SendKeyEvent( EventType.KeyDown ) Endif

1 2 3 4 5

If kevent->repeat_ SendKeyEvent( EventType.KeyRepeat ) Else SendKeyEvent( EventType.KeyDown ) Endif

Either by creating a new important event KeyPress (which captures both states of Down and Repeat) or the significance of Key.Repeat would be changed (changing it’s bitwise value) if it makes any sense to do so:

Monkey

If kevent->repeat_ SendKeyEvent( EventType.Down & EventType.KeyRepeat )

1	If kevent->repeat_ SendKeyEvent( EventType.Down & EventType.KeyRepeat )

I don’t know if these proposals are good or not but I though it a good opportunity to throw the ideas, and see what happens.

[Author]

Posts