Need help converting monkey 1 to monkey 2 code.

[JesseParticipant]

I am trying to convert this code to monkey 2 but I can’t figure out how to do it correctly it works in monkey 1:

Monkey

[crayon-5cba87f315338877711170 inline="true" ]'******************************************************* '* Store * '******************************************************* Class Store<T> Field last:T Field total:Int Method New() End Method Method New(count:Int) Fill(count) End Method Method Fill:Void(total:Int) For Local i:Int = 0 Until total Local c:T = New T() c._pred = last last = c Next Self.total = total End Method Method Count:Int() Return total End Method Method GetItem:T() If last Local c:T = last last = Cast(last._pred) c._pred = Null total -= 1 Return c Endif Return New T() End Method Method ReturnItem:Void(obj:T) obj._succ = Null obj._pred = last last = obj total += 1 End Method End Class

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50

[crayon-5cba87f315338877711170 inline="true" ]'******************************************************* '* Store * '*******************************************************   Class Store<T> Field last:T Field total:Int   Method New() End Method   Method New(count:Int) Fill(count) End Method   Method Fill:Void(total:Int) For Local i:Int = 0 Until total Local c:T = New T() c._pred = last last = c Next Self.total = total End Method   Method Count:Int() Return total End Method   Method GetItem:T() If last Local c:T = last last = Cast(last._pred) c._pred = Null total -= 1 Return c Endif   Return New T() End Method   Method ReturnItem:Void(obj:T) obj._succ = Null obj._pred = last last = obj total += 1 End Method   End Class

[/crayon]

 

I get this errors trying to compile it:

/Users/legend/Desktop/patrol 2/store.monkey2 [32] : Error : Identifier ‘T’ not found
/Users/legend/Desktop/patrol 2/store.monkey2 [38] : Error : Can’t find overload for ‘new(…)’ with argument types ()
/Users/legend/Desktop/patrol 2/store.monkey2 [29] : Error : Missing return statement
/Users/legend/Desktop/patrol 2/store.monkey2 [18] : Error : Can’t find overload for ‘new(…)’ with argument types ()
/Users/legend/Desktop/patrol 2/store.monkey2 [19] : Error : Identifier ‘c’ not found
/Users/legend/Desktop/patrol 2/store.monkey2 [20] : Error : Identifier ‘c’ not found
//Users/legend/Desktop/patrol 2/store.monkey2 [9] : Error : Missing return statement
/Users/legend/Desktop/patrol 2/store.monkey2 [32] : Error : Identifier ‘T’ not found
/Users/legend/Desktop/patrol 2/store.monkey2 [38] : Error : Can’t find overload for ‘new(…)’ with argument types ()
/Users/legend/Desktop/patrol 2/store.monkey2 [29] : Error : Missing return statement
/Users/legend/Desktop/patrol 2/store.monkey2 [18] : Error : Can’t find overload for ‘new(…)’ with argument types ()
/Users/legend/Desktop/patrol 2/store.monkey2 [19] : Error : Identifier ‘c’ not found
/Users/legend/Desktop/patrol 2/store.monkey2 [20] : Error : Identifier ‘c’ not found

 

 

still trying to figure out how to post code here.

[peterigzParticipant]

Are you wanting T to be a generic type? I think you’re just missing the <T> after the class declaration..

Monkey

Class Store<T>

1	Class Store<T>

[JesseParticipant]

I don’t know how that got removed.  I do have it on my original code. apparently in the process of figuring out how to post code here it got removed. So the error happen with the “<T>” in place.

[impixiParticipant]

Explicit casting in MX2 is different than MX1. This line:

last = T(last._pred)

Should be:

last = Cast<T>(last._pred)

The following should compile without errors (I haven’t checked for any logic errors though):

Monkey

[crayon-5cba87f31eaf2318920743 inline="true" ] #import "<std>" Function Main:Void() local store := New Store<Item>(20) End Class Item Field _pred:Item Field _succ:Item End Class Store<T> Field last:T Field total:Int Method New(count:Int) Fill(count) End Method Method Fill:Void(total:Int) For Local i:Int = 0 Until total Local c:T = New T() c._pred = last last = c Next Self.total = total End Method Count:Int() Return total End Method GetItem:T() If last Local c:T = last last = Cast<T>(last._pred) c._pred = Null total -= 1 Return c Endif Return New T() End Method ReturnItem:Void(obj:T) obj._succ = Null obj._pred = last last = obj total += 1 End End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58

[crayon-5cba87f31eaf2318920743 inline="true" ] #import "<std>"   Function Main:Void()   local store := New Store<Item>(20) End   Class Item Field _pred:Item Field _succ:Item End   Class Store<T> Field last:T Field total:Int   Method New(count:Int) Fill(count) End Method Method Fill:Void(total:Int) For Local i:Int = 0 Until total Local c:T = New T() c._pred = last last = c Next Self.total = total End Method Count:Int() Return total End Method GetItem:T() If last Local c:T = last last = Cast<T>(last._pred) c._pred = Null total -= 1 Return c Endif Return New T() End Method ReturnItem:Void(obj:T) obj._succ = Null obj._pred = last last = obj total += 1 End End

[/crayon]

[JesseParticipant]

thanks Impixi. I was wondering about the casting thing. that solved several errors. but I still get these errors (on my code):

/Users/legend/Desktop/patrol 2/store.monkey2 [38] : Error : Can’t find overload for ‘new(…)’ with argument types ()
/Users/legend/Desktop/patrol 2/store.monkey2 [29] : Error : Missing return statement
/Users/legend/Desktop/patrol 2/store.monkey2 [18] : Error : Can’t find overload for ‘new(…)’ with argument types ()
/Users/legend/Desktop/patrol 2/store.monkey2 [19] : Error : Identifier ‘c’ not found
/Users/legend/Desktop/patrol 2/store.monkey2 [20] : Error : Identifier ‘c’ not found

[impixiParticipant]

What’s your code for creating a new Store instance?

[JesseParticipant]

it uses this as a base for all my objects:

Monkey

Class StoreObject Field _pred:StoreObject Field _succ:StoreObject Function Separate:Void(obj:StoreObject) If obj._pred If obj._succ obj._pred._succ = obj._succ obj._succ._pred = obj._pred Else obj._pred._succ = Null Endif Elseif obj._succ obj._succ._pred = Null Endif End Function End Class

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20

Class StoreObject Field _pred:StoreObject Field _succ:StoreObject Function Separate:Void(obj:StoreObject) If obj._pred If obj._succ obj._pred._succ = obj._succ obj._succ._pred = obj._pred Else obj._pred._succ = Null Endif Elseif obj._succ obj._succ._pred = Null Endif End Function End Class

I create instance of it the same way you did in your example. it works fine in monkey1 but I can’t figure this errors out.

[impixiParticipant]

If you’re making use of inheritance there are issues relating to constructor “chaining” – might be related to your errors?

There’s a forum topic about it:
http://monkey2.monkey-x.com/forums/topic/referencing-new/

You might need to rework your underlying architecture a little bit to make it play nice with MX2…

[JesseParticipant]

I don’t think that’s the issue. the problem seems to be when creating an instance of generic such as:

</p><p>new T().</p><p>

[JesseParticipant]

well I isolated the code and it seems to work fine. it has to be from other files that are accessing it.

 

Thanks Impixi for your help.

[JesseParticipant]

Well, I kept getting an error when create stores of new classes and I couldn’t figure out what the problem was until now. it appears that I have to create a simple new method on the “T” class or it fails to compile. I am posting this for anybody that runs into this problem.

[Author]

Posts