PixMap->Image bug

[jondecker76Participant]

I’ve been trying to work with a PixMap then load it as an image to display on the screen.  After trying everything with my current project, I decided to make something very simple to see what is going on:

Monkey

Namespace myapp #Import "<std>" #Import "<mojo>" Using std.. Using mojo.. Class MyWindow Extends Window Method OnRender( canvas:Canvas ) Override global i:Int Local pm:=New Pixmap(640, 480, PixelFormat.RGB24) pm.Clear(New Color(Rnd(0,255),Rnd(0,255),Rnd(0,255),1)) Local img:=New Image(pm,TextureFlags.Dynamic) canvas.DrawImage(img,0,0) App.RequestRender() End End Function Main() New AppInstance New MyWindow App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33

Namespace myapp   #Import "<std>" #Import "<mojo>"   Using std.. Using mojo..   Class MyWindow Extends Window   Method OnRender( canvas:Canvas ) Override     global i:Int       Local pm:=New Pixmap(640, 480, PixelFormat.RGB24)    pm.Clear(New Color(Rnd(0,255),Rnd(0,255),Rnd(0,255),1))    Local img:=New Image(pm,TextureFlags.Dynamic)       canvas.DrawImage(img,0,0)    App.RequestRender() End End   Function Main()   New AppInstance New MyWindow App.Run() End

This will bomb out with an error

Invalidate PixelFormat
{{!DEBUG!}}

[PakzParticipant]

Same error here to.

Your clear color part. Is it not so that monkey has colors between 0.0 and 1.0? I changed that and it did not work either.

 

edit:

If you remove the textureflags.dynamic part then it does work.

[jondecker76Participant]

Good point – I actually didn’t know that that the Color class worked in 0.0 to 1.0 for the R G B aspects, the documentation wasn’t clear.  But looking at color.monkey2 I can see you’re right.  Either way,  there seems to be a problem converting from pixmap colorspace to Image colorspace somewhere in the mojo code

[PakzParticipant]

I modified the code a bit and it slows the computer down a lot. Maybe a memory leak?

In release mode it slows to a crawl.

Monkey

#Import "<std>" #Import "<mojo>" Using std.. Using mojo.. Class MyWindow Extends Window Method OnRender( canvas:Canvas ) Override If Keyboard.KeyReleased(Key.Escape) Then App.Terminate() App.RequestRender() ' create a pixmap Local pixmap:=New Pixmap(640, 480) ' clear the pixmap pixmap.Clear(New Color(Rnd(0,1),Rnd(0,1),Rnd(0,1),1)) 'create a image with from the pixmap Local img:=New Image(pixmap) ' draw the image canvas.DrawImage(img,0,0) canvas.Color = Color.Black canvas.DrawRect(0,0,320,20) canvas.Color = Color.White canvas.DrawText("FPS:"+App.FPS,0,0) End Method End Class Function Main() New AppInstance New MyWindow App.Run() End Function

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35

#Import "<std>" #Import "<mojo>" Using std.. Using mojo.. Class MyWindow Extends Window Method OnRender( canvas:Canvas ) Override If Keyboard.KeyReleased(Key.Escape) Then App.Terminate() App.RequestRender()       ' create a pixmap    Local pixmap:=New Pixmap(640, 480)    ' clear the pixmap    pixmap.Clear(New Color(Rnd(0,1),Rnd(0,1),Rnd(0,1),1))    'create a image with from the pixmap    Local img:=New Image(pixmap)    ' draw the image    canvas.DrawImage(img,0,0)    canvas.Color = Color.Black    canvas.DrawRect(0,0,320,20)    canvas.Color = Color.White    canvas.DrawText("FPS:"+App.FPS,0,0) End Method End Class Function Main() New AppInstance New MyWindow App.Run() End Function

 

 

How do you paste code?

[JesseParticipant]

How do you paste code?

Click on the “<>” above the posting box. Just enter the code don’t click on anything  and press Add.

[PakzParticipant]

Thanks. I put the code in the codebox.

[JesseParticipant]

I don’t think it’s a good idea to create a pixmap and an image from the pixmap every frame specially of that size. Creating the pixmap, clearing it, and converting it to an image are very intense operations.

[EthernautParticipant]

I don’t think it’s a good idea to create a pixmap and an image from the pixmap every frame specially of that size

Agreed, if all you want to do is draw to a texture, try using an Image Canvas. There’s an example in the Bananas folder.

https://github.com/blitz-research/monkey2/blob/master/bananas/rendertoimage/rendertoimage.monkey2

Also, make sure you use the TextureFlags.Dynamic flag on that texture when drawing to an image canvas that is updated every frame.

[PakzParticipant]

It is just a test. Should locals not be freed automatically when the function is exited?

i thought i did something similar with monkey 1 and that worked without slowing down.

the texture flag gave a compile error as was in the first post here.

[Mark SiblyKeymaster]

>Should locals not be freed automatically when the function is exited?

You need to image.Discard() images when you’ve finished with them.

This will be partially automated in future so you’ll be able to discard ‘groups’ of resources with one call, but for now images should be discarded manually.

Some people think GC should deal with this, but I disagree. VRAM is precious and I don’t think it’s a good idea to trust the release of VRAM to the vaguaries of the GC system. In fact, this is a pretty good example of why – the app wont actually be consuming that much system ram, so it may well have alloced a LOT of VRAM by the time it gets around to GC-ing – by which time it may be too late.

[Author]

Posts