quick help mods

[Simon ArmstrongParticipant]

After getting frustrated with quick help (F1 key in Ted2) I modified the source in the hope of improvement. Testing now.

This patch makes monkey std and mojo modules have priority and a period is prepended to the search term.

Hard coded keywords and more advanced context sensitive module filter would be nice.

Monkey

diff --git a/src/ted2/helptree.monkey2 b/src/ted2/helptree.monkey2 index 57d01b0..cd13a7a 100644 --- a/src/ted2/helptree.monkey2 +++ b/src/ted2/helptree.monkey2 @@ -6,6 +6,11 @@ Private Function EnumModules:String[]() Local mods:=New StringStack + + mods.Add("monkey") + mods.Add("std") + mods.Add("mojo") + mods.Add("mojox") For Local f:=Eachin LoadDir( "modules" ) @@ -19,8 +24,8 @@ Function EnumModules:String[]() If Not obj Continue Local jname:=obj["module"] - If Not jname Or Not Cast<JsonString>( jname ) Continue - + If Not jname Or Not Cast<JsonString>( jname ) Or mods.Contains(jname.ToString()) Continue + mods.Push( jname.ToString() ) Next @@ -125,8 +130,10 @@ Class HelpTree Extends TreeView Local page:=data["page"].ToString() - tree._index[page.ToLower()]=Self - + Local key:=page.ToLower() + tree._index[key]=Self + tree._contents.Push(key) + _page=page Endif @@ -160,14 +167,16 @@ Class HelpTree Extends TreeView text=text.ToLower() _matches.Clear() + + Local term:="."+text Local selected:=New Map<Node,Bool> - For Local it:=Eachin _index + For Local key:=Eachin _contents - If Not it.Key.Contains( text ) Continue - - Local node:=it.Value + If Not key.Contains( term ) Continue + + Local node:=_index[key] _matches.Push( node ) @@ -254,5 +263,7 @@ Class HelpTree Extends TreeView Field _selected:=New Map<Node,Bool> Field _index:=New Map<String,Node> + + Field _contents:=New Stack<String> End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70

diff --git a/src/ted2/helptree.monkey2 b/src/ted2/helptree.monkey2 index 57d01b0..cd13a7a 100644 --- a/src/ted2/helptree.monkey2 +++ b/src/ted2/helptree.monkey2 @@ -6,6 +6,11 @@ Private Function EnumModules:String[]()           Local mods:=New StringStack + +       mods.Add("monkey") +       mods.Add("std") +       mods.Add("mojo") +       mods.Add("mojox")           For Local f:=Eachin LoadDir( "modules" )   @@ -19,8 +24,8 @@ Function EnumModules:String[]()                 If Not obj Continue                   Local jname:=obj["module"] -               If Not jname Or Not Cast<JsonString>( jname ) Continue - +               If Not jname Or Not Cast<JsonString>( jname ) Or mods.Contains(jname.ToString()) Continue +                 mods.Push( jname.ToString() )           Next @@ -125,8 +130,10 @@ Class HelpTree Extends TreeView                                   Local page:=data["page"].ToString()   -                               tree._index[page.ToLower()]=Self - +                               Local key:=page.ToLower() +                               tree._index[key]=Self +                               tree._contents.Push(key) +                                 _page=page                         Endif   @@ -160,14 +167,16 @@ Class HelpTree Extends TreeView                 text=text.ToLower()                   _matches.Clear() + +               Local term:="."+text                   Local selected:=New Map<Node,Bool>   -               For Local it:=Eachin _index +               For Local key:=Eachin _contents   -                       If Not it.Key.Contains( text ) Continue - -                       Local node:=it.Value +                       If Not key.Contains( term ) Continue + +                       Local node:=_index[key]                           _matches.Push( node )   @@ -254,5 +263,7 @@ Class HelpTree Extends TreeView         Field _selected:=New Map<Node,Bool>           Field _index:=New Map<String,Node> + +       Field _contents:=New Stack<String>   End

[Simon ArmstrongParticipant]

Hmm, in hindsight just prepending period to text variable should fix quick help.

[Author]

Posts