Monkey 2Ted21 github update – Monkey 2

AdamStrange — Mon, 01 Aug 2016 05:49:08 +0000

This is my first attempt, so it all might go Pete Tong…

https://github.com/StrangeIsMyName/monkey2

in the src/ you will find ted21

modules/mojo/graphics/canvas.monkey2

modules/mojo/input/keyboard.monkey2

modules/mojo/input/keycodes.monkey2

Let me know how you get on. Everything works, but I’m not yet giving it a release number

]]>

DruggedBunny — Mon, 01 Aug 2016 11:38:50 +0000

Is this the correct release, Adam? I’ve download and built src/ted2 (there’s no ted21), and it looks the same as the original.

Ignore: some sort of weirdness with Github Desktop, I think — I see that on visiting the project page, ted21 is there, but not in my newly-gitted version, for some reason, sorry! EDIT: Yep, Github Desktop lists both blitz-research/monkey2 and strangeismyname/monkey2, but both link to the same physical monkey2 folder with no ted21! Grrr.

]]>

AdamStrange — Mon, 01 Aug 2016 11:55:38 +0000

so, have you got it?

]]>

DruggedBunny — Mon, 01 Aug 2016 12:17:20 +0000

Yep, just tried to build ted21, but it gives me this:

mx2cc version 1.0.2

***** Building app 'C:/Users/James/Desktop/monkey2-master/src/ted21/ted21.monkey2' *****

Parsing...
Semanting...
C:/Users/James/Desktop/monkey2-master/src/ted21/mojox/action.monkey2 [101] : Error : Type 'mojo.input.Modifier' has no member named 'Command'
C:/Users/James/Desktop/monkey2-master/src/ted21/mainwindow.monkey2 [840] : Error : Identifier 'NODEKIND_WINDOWCLOSE' not found
C:/Users/James/Desktop/monkey2-master/src/ted21/mojox/textview.monkey2 [1657] : Error : Type 'mojo.input.Modifier' has no member named 'Command'

mx2cc version 1.0.2

***** Building app 'C:/Users/James/Desktop/monkey2-master/src/ted21/ted21.monkey2' *****

Parsing...

Semanting...

C:/Users/James/Desktop/monkey2-master/src/ted21/mojox/action.monkey2 [101] : Error : Type 'mojo.input.Modifier' has no member named 'Command'

C:/Users/James/Desktop/monkey2-master/src/ted21/mainwindow.monkey2 [840] : Error : Identifier 'NODEKIND_WINDOWCLOSE' not found

C:/Users/James/Desktop/monkey2-master/src/ted21/mojox/textview.monkey2 [1657] : Error : Type 'mojo.input.Modifier' has no member named 'Command'

It highlights mojox/action.monkey2:

	Property HotKeyLabel:String()
		If Not _hotKey Return ""
		
		Local label:=""
		If _hotKeyMods & Modifier.Shift label+="Shift"
		If _hotKeyMods & Modifier.Control label+="+Ctrl"
		If _hotKeyMods & Modifier.Alt label+="+Alt"
		If _hotKeyMods & Modifier.Command label+="+Cmd"
		label+="+"+Keyboard.KeyName( _hotKey )
		If label.StartsWith( "+" ) label=label.Slice( 1 )
		Return label
	End

Property HotKeyLabel:String()

If Not _hotKey Return ""

Local label:=""

If _hotKeyMods & Modifier.Shift label+="Shift"

If _hotKeyMods & Modifier.Control label+="+Ctrl"

If _hotKeyMods & Modifier.Alt label+="+Alt"

If _hotKeyMods & Modifier.Command label+="+Cmd"

label+="+"+Keyboard.KeyName( _hotKey )

If label.StartsWith( "+" ) label=label.Slice( 1 )

Return label

End

Specifically:

If _hotKeyMods & Modifier.Command label+="+Cmd"

1	If _hotKeyMods & Modifier.Command label+="+Cmd"

I’ve basically done rebuildall.bat, then run the standard-built ted, opened ted21.monkey2 and built. Should I be doing anything else before trying to build it?

]]>

AdamStrange — Mon, 01 Aug 2016 12:49:43 +0000

ok. looks like there might be a missing line in mojo/input/keycodes.monkey2

i’ve updated the github with this file

the line you need to add is the last line of the final enum (directly after Gui=..):

Command= LeftGui|RightGui

You then need to ./rebuildmods

]]>

DruggedBunny — Mon, 01 Aug 2016 13:12:04 +0000

I’m now getting this:

mx2cc version 1.0.2

***** Building app 'C:/Users/James/Desktop/monkey2-master/src/ted21/ted21.monkey2' *****

Parsing...
Semanting...
C:/Users/James/Desktop/monkey2-master/src/ted21/mainwindow.monkey2 [840] : Error : Identifier 'NODEKIND_WINDOWCLOSE' not found

mx2cc version 1.0.2

***** Building app 'C:/Users/James/Desktop/monkey2-master/src/ted21/ted21.monkey2' *****

Parsing...

Semanting...

C:/Users/James/Desktop/monkey2-master/src/ted21/mainwindow.monkey2 [840] : Error : Identifier 'NODEKIND_WINDOWCLOSE' not found

… in mainwindow.monkey2, line 840:

		_fileMenu.AddAction( _fileClose, NODEKIND_WINDOWCLOSE )

1	_fileMenu.AddAction( _fileClose, NODEKIND_WINDOWCLOSE )

Same as the first try, so I guess NODEKIND_WINDOWCLOSE needs defining somewhere too!

EDIT: Realised you build on Mac, which makes sense — it’s within the #If __HOSTOS__=”macos” else block!

]]>

AdamStrange — Mon, 01 Aug 2016 13:33:08 +0000

mmm, interesting, but getting better.

ok I upped a new version of ted21, so just download and see how it compiles now?

I’m going to get to the bottom of this for you 🙂

]]>

AdamStrange — Mon, 01 Aug 2016 13:35:00 +0000

ok. Change this line 840 to

_fileMenu.AddAction( _fileClose, NODEKIND_WINDOWSCLOSE )

There was an S missing! – my bad!

]]>

DruggedBunny — Mon, 01 Aug 2016 14:13:56 +0000

That’s building/running now, looking good!

Some random observations:

Liking the standard basic editor stuff like double-clicking a word to select it, and implementation of Ctrl + cursors, but I notice that Ctrl + left/right cursors jumps to start/end of line. Think that’s Mac behaviour, but on Windows I’d expect it to jump to the previous/next word, selecting if Shift also held. (Home/End do start/end of line on Windows.)

I don’t really get what the blue/purple file icons actually do in the Code tab, sort of show/hide stuff, but not sure what exactly — reckon mojox needs some tooltips! The green square and orange spanner don’t seem to do anything, but perhaps I just don’t have the right kind of code opened — I know the last one is lambdas…

Not sure if deliberate, but the code shows red DebugStop symbols on every line after the last line of code; also, you can play around with turning these on and off, and sometimes end up with a DebugStop but no red symbol. (Eg. Randomly turning on and off the first two red symbols seems to get it into this state.)

Icons along the top are a bit blurry, maybe just need filtering turned off?

Great update, though.

]]>

DruggedBunny — Mon, 01 Aug 2016 14:19:10 +0000

Just noticed the build progress bar, that’s really cool!

Also just noticed that if I drag the window to one side (as I normally do, so it fills half the screen horizontally), the “Application built” text and line numbering overlap each other really messily. I’d suggest either just showing the executable name, rather than full path, or cutting it off where the line numbering starts. (Or both.)

Just resize the window to simulate, of course…

]]>