Unexpected Output Decimal to Binary/Hex

[scurtyParticipant]

So I’m trying to convert a Decimal value to Binary and Hex and I guess I don’t have the correct algorithm setup. Or maybe something else is up. This code translated into GML(Game Maker Language) seems to work as expected.

Monkey

Namespace Application Import "<std>" Using std.. Function DecimalToHex:String(integer:Int) Local dic:String = "0123456789ABCDEF" Local hex:String = "" Local dec:Int = integer If(Not dec) Then hex = "00" While(dec) Local bits := dec & $ff Local hi := dic[bits / 16 + 1] Local lo := dic[bits Mod 16 + 1] hex = hi + lo + hex dec = dec Shr 8 Wend Return hex End Function DecimalToBin:String(integer:Int) Local dec := integer Local dic:String = "01" Local bin:String = "" If(Not dec) Then bin = "0" While(dec) bin = dic[(dec & 1) + 1] + bin dec = dec Shr 1 Wend Return bin End Function Main:Int() Print(DecimalToHex(1)) Print(DecimalToBin(1)) Return 0 End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57

Namespace Application   Import "<std>"   Using std..   Function DecimalToHex:String(integer:Int)   Local dic:String = "0123456789ABCDEF" Local hex:String = "" Local dec:Int = integer If(Not dec) Then hex = "00" While(dec) Local bits := dec & $ff Local hi := dic[bits / 16 + 1] Local lo := dic[bits Mod 16 + 1] hex = hi + lo + hex dec = dec Shr 8   Wend Return hex   End   Function DecimalToBin:String(integer:Int)   Local dec := integer Local dic:String = "01" Local bin:String = "" If(Not dec) Then bin = "0" While(dec) bin = dic[(dec & 1) + 1] + bin dec = dec Shr 1 Wend Return bin   End     Function Main:Int()     Print(DecimalToHex(1)) Print(DecimalToBin(1))   Return 0   End

It outputs 99 for the Hex Function and 45 for the Bin Function. Any ideas?

[JesseParticipant]

Monkey

[crayon-5cba8b0f36c99589456733 inline="true" ]port "<std>" Using std.. Function DecimalToHex:String(dec:Int) If(Not dec) Then Return "00" Local dic:String = "0123456789ABCDEF" Local hex:String = "" While(dec) Local bits := dec & $f Local hi := String.FromChar(dic[bits]) hex = hi + hex dec = dec Shr 4 Wend Return hex End Function DecimalToBin:String(dec:Int) If(Not dec) Then Return "0" Local bin:String = "" While(dec) bin = String(dec & 1) + bin dec = dec Shr 1 Wend Return bin End Function Main() Print(DecimalToHex(26)) Print(DecimalToBin(5)) End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43

[crayon-5cba8b0f36c99589456733 inline="true" ]port "<std>"   Using std..   Function DecimalToHex:String(dec:Int)   If(Not dec) Then Return "00"   Local dic:String = "0123456789ABCDEF" Local hex:String = "" While(dec) Local bits := dec & $f Local hi := String.FromChar(dic[bits]) hex = hi + hex dec = dec Shr 4 Wend Return hex   End   Function DecimalToBin:String(dec:Int)   If(Not dec) Then Return "0"   Local bin:String = "" While(dec) bin = String(dec & 1) + bin dec = dec Shr 1 Wend Return bin End   Function Main()   Print(DecimalToHex(26)) Print(DecimalToBin(5))   End

[/crayon]

[scurtyParticipant]

Oops. 4 not 8. Noob mistake. xD Gotta convert those strings. Haha.

[JesseParticipant]

here a more complete set:

Monkey

[crayon-5cba8b0f3c52f429005164 inline="true" ] #import "<std>" Using mojo.. Using std.. Function DecimalToHex:String(dec:Int) If(Not dec) Then Return "00" Local dic:String = "0123456789ABCDEF" Local hex:String = "" While(dec) Local bits := dec & $f Local hi := String.FromChar(dic[bits]) hex = hi + hex dec = dec Shr 4 Wend Return hex End Function DecimalToBin:String(dec:Int) If(Not dec) Then Return "0" Local bin:String = "" While(dec) bin = String(dec & 1) + bin dec = dec Shr 1 Wend Return bin End Function HexToDecimal:Int(str:String) If str = "" Return 0 Local dic := "0123456789ABCDEF" Local dec :Int = 0 While str.Length > 0 Local char := str.Left(1).ToUpper() If dic.Contains(char) dec = (dec Shl 4) | dic.Find(char) Else Return 0 Endif str = str.Mid(1,str.Length-1) Wend Return dec End Function Function BinToDec:Int(str:String) If str = "" Return 0 Local dec :Int = 0 While str.Length > 0 Local char := str.Left(1) If char = "0" Or char = "1" dec = (dec Shl 1) | Int(char) Else Return 0 Endif str = str.Mid(1,str.Length-1) Wend Return dec End Function Function Main() Print(DecimalToHex(26)) Print(DecimalToBin(5)) Print(HexToDecimal("1aA")) Print(BinToDec("10001")) End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94

[crayon-5cba8b0f3c52f429005164 inline="true" ] #import "<std>"   Using mojo.. Using std..   Function DecimalToHex:String(dec:Int)   If(Not dec) Then Return "00"   Local dic:String = "0123456789ABCDEF" Local hex:String = "" While(dec) Local bits := dec & $f Local hi := String.FromChar(dic[bits]) hex = hi + hex dec = dec Shr 4 Wend Return hex   End   Function DecimalToBin:String(dec:Int)   If(Not dec) Then Return "0"   Local bin:String = "" While(dec) bin = String(dec & 1) + bin dec = dec Shr 1 Wend Return bin End   Function HexToDecimal:Int(str:String) If str = "" Return 0 Local dic := "0123456789ABCDEF" Local dec :Int = 0 While str.Length > 0 Local char := str.Left(1).ToUpper() If dic.Contains(char) dec = (dec Shl 4) | dic.Find(char) Else Return 0 Endif str = str.Mid(1,str.Length-1) Wend Return dec End Function   Function BinToDec:Int(str:String) If str = "" Return 0 Local dec :Int = 0 While str.Length > 0 Local char := str.Left(1) If char = "0" Or char = "1" dec = (dec Shl 1) | Int(char) Else Return 0 Endif str = str.Mid(1,str.Length-1) Wend Return dec End Function   Function Main()   Print(DecimalToHex(26)) Print(DecimalToBin(5)) Print(HexToDecimal("1aA")) Print(BinToDec("10001")) End

[/crayon]

[Mark SiblyKeymaster]

Monkey

#import "<std>" Using std.stringio Function Main() Print ULongToString( 26,16 ) Print ULongToString( 5,2 ) Print StringToULong( "1aA",16 ) Print StringToULong( "10001",2) End

1 2 3 4 5 6 7 8 9 10 11 12 13

#import "<std>"   Using std.stringio   Function Main()   Print ULongToString( 26,16 ) Print ULongToString( 5,2 ) Print StringToULong( "1aA",16 ) Print StringToULong( "10001",2)   End

[JesseParticipant]

Thats funny, I have been through the string documentation several times but for some reason I never actually payed attention to those functions.

[scurtyParticipant]

Wow. *super facepalm*

Well I guess I know more about hex and binary now. xD Thank you Mark and everyone else. xD

[Mark SiblyKeymaster]

It’s good practice to write these yourself at least once in your career I think!

[scurtyParticipant]

You’re absolutely right! Knowledge is power these days. xD

[Author]

Posts