[AnatolParticipant]

Hi,

thanks for the hint nerobot. I’m just doing the “double work” out of habit, so should I ever change the way I disable controllers I only need to change it in one place, i.e. in Method Disable. I think here the performance impact should be negligible.

And cocon, I just came up with this manager class to keep it as flexible as possible. In the setup I basically just create controls with a condition and a callback. I could add this stuff into the render loop but I prefer to have it packaged in this class not to “pollute” the render loop too much, and also to easily disable/enable controls later. That’s where the Lamda functions are really useful.

So in the main program this is how I’m using this class:

Monkey

#Import "utils/control_manager" Class MyApp Extends Window Field ControlManager:ControlManager Const DegreesPerKeyDown := 1 Const RadiansPerKeyDown := DegreesPerKeyDown * Pi / 180 ' ... more code here Method AddControls() ControlManager = New ControlManager() If Accel.Supported ' Accelerometer controls Local unconditional := Lambda:Bool() Return True End Local rotatePlayerByAccelX := Lambda() Player.Rotation = -Accel.Y End ControlManager.Add( "accelerometer", unconditional, rotatePlayerByAccelX ) Else ' Keyboard controls Local leftArrowDown := Lambda:Bool() Return Keyboard.KeyDown( Key.Left ) End Local rightArrowDown := Lambda:Bool() Return Keyboard.KeyDown( Key.Right ) End Local playerRotateLeft := Lambda() Player.Rotation -= RadiansPerKeyDown End Local playerRotateRight := Lambda() Player.Rotation += RadiansPerKeyDown End ControlManager.Add( "leftArrowDown", leftArrowDown, playerRotateLeft ) ControlManager.Add( "rightArrowDown", rightArrowDown, playerRotateRight ) End End Method OnRender:Void( canvas:Canvas ) Override ControlManager.OnUpdate() Player.OnUpdate() ' ... more code here End End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57

#Import "utils/control_manager"     Class MyApp Extends Window      Field ControlManager:ControlManager   Const DegreesPerKeyDown := 1   Const RadiansPerKeyDown := DegreesPerKeyDown * Pi / 180     ' ... more code here        Method AddControls()     ControlManager = New ControlManager()              If Accel.Supported       ' Accelerometer controls              Local unconditional := Lambda:Bool()         Return True       End              Local rotatePlayerByAccelX := Lambda()         Player.Rotation = -Accel.Y       End              ControlManager.Add( "accelerometer", unconditional, rotatePlayerByAccelX )     Else       ' Keyboard controls              Local leftArrowDown := Lambda:Bool()         Return Keyboard.KeyDown( Key.Left )           End              Local rightArrowDown := Lambda:Bool()         Return Keyboard.KeyDown( Key.Right )             End              Local playerRotateLeft := Lambda()         Player.Rotation -= RadiansPerKeyDown       End              Local playerRotateRight := Lambda()         Player.Rotation += RadiansPerKeyDown       End              ControlManager.Add( "leftArrowDown", leftArrowDown, playerRotateLeft )       ControlManager.Add( "rightArrowDown", rightArrowDown, playerRotateRight )     End   End      Method OnRender:Void( canvas:Canvas ) Override         ControlManager.OnUpdate()         Player.OnUpdate()     ' ... more code here   End    End

I could later then just do something like

Monkey

ControlManager.Disable( "accelerometer" )

1	ControlManager.Disable( "accelerometer" )

<div id=”crayon-59d4ac7531a47621632511-36″ class=”crayon-line”></div>

[AnatolParticipant]

Thanks Mark. That’s good advice.

In this case I actually changed it to a key map so that I have easy access to individual collection items via its key.

Monkey

Class Control Field Trigger:Bool() Field Callback:Void() Field Enabled:Bool = True End Class ControlManager Field Controls := New Map<String,Control> Method Add ( key:String, trigger:Bool(), callback:Void() ) Local control := New Control() control.Trigger = trigger control.Callback = callback Controls.Add( key, control ) End Method Remove ( key:String ) Controls.Remove( key ) End Method Disable ( key:String ) Controls.Get( key ).Enabled = False End Method Enable ( key:String ) Controls.Get( key ).Enabled = True End Method DisableAll () For Local key := Eachin Controls.Keys Disable( key ) Next End Method EnableAll () For Local key := Eachin Controls.Keys Enable( key ) Next End Method OnUpdate () For Local control := Eachin Controls.Values If control.Enabled And control.Trigger() control.Callback() End Next End End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52

Class Control Field Trigger:Bool() Field Callback:Void() Field Enabled:Bool = True End     Class ControlManager Field Controls := New Map<String,Control> Method Add ( key:String, trigger:Bool(), callback:Void() ) Local control := New Control() control.Trigger = trigger control.Callback = callback Controls.Add( key, control ) End Method Remove ( key:String ) Controls.Remove( key ) End Method Disable ( key:String ) Controls.Get( key ).Enabled = False End Method Enable ( key:String ) Controls.Get( key ).Enabled = True End Method DisableAll () For Local key := Eachin Controls.Keys Disable( key ) Next End Method EnableAll () For Local key := Eachin Controls.Keys Enable( key ) Next End Method OnUpdate () For Local control := Eachin Controls.Values If control.Enabled And control.Trigger() control.Callback() End Next End End

Also, very nice that we have Lamda functions now. It’s really fun to use Monkey 2, now that I got more used to the syntax and strict types again.

[AnatolParticipant]

Oh! Thanks Jesse. I could’ve sworn that I tried this, but apparently not. And yes, that works well, even with length 0.

[AnatolParticipant]

Ah, great! Thanks for the info. I’ll try that.

[Author]

Posts