Ted2Go IDE

[HezkoreParticipant]

Another annoying this is that if I try to move the Tab Close button using Margin or Padding, you can still click on the original position of the close button.

[nerobotParticipant]

No you can still apply it (as you can clearly see in my GIF!) via selecting the same theme again.

You are right, sorry.

So, that is what I found:

1. style of TextView has no effect, and there is used “content” color for background.
2. if I setup “content”:”#282C34″ then I got correct color, not #223333
3. style of TextView work correctly in my monkey2 fork! and when I answered you first time I tried with it and it works. Now I tried with release1.1.01 and it does not work.
4. Needed more deep comparison code to understand.

This is my theme for test:

Monkey

{ "extends":"ted2-default", "styles":{ "TextView":{ "backgroundColor":"#282C34" } } }

1 2 3 4 5 6 7 8 9

{ "extends":"ted2-default", "styles":{ "TextView":{ "backgroundColor":"#282C34" } } }

and result on the screenshot.

So try to use version from monkey2 repository.

Attachments:

1. 

   2016-11-16_11-02-28.png
   

[AdamStrangeParticipant]

these are colors for code highlighting:
<clip>
LOL

so… why doesn’t the code reference the actual use and not color0, etc.

For the end user, editing a non-sensical document full of color0, etc makes no sense.

you could go further with the color definitions themselves:

E.G.

“#ff0000” and why not “Red”. why in “” and why if defining it as a UInt it is $ff0000ff. or as Color(1.0,0,0). There is no connection with any of it!

</div>
My solution was to have a unified set of colors, that are named and shown. so you know what they are in both words and a visual color picker.

E.G.

canvas.Color = Color.PicoBlack

or pop out the color picker and pick the color “PicoBlack”, or pick that sort of black color you like.

The color picker also shows what the rgb values are in floats.

Be very carful with having any sort of floating dialog – they get in the way

etc, etc

</div>

[nerobotParticipant]

For the end user, editing a non-sensical document full of color0, etc makes no sense.

The rule is: If you are not ready to study each param inside of theme – don’t touch this.

The end user should be enough to use predefined themes.

And as I said earlier – color picker is in todo.

[HezkoreParticipant]

I’ve built Monkey 2 from the master branch and Ted2Go from the master branch and applied your theme.
The colour is still wrong.

[skn3Participant]

nerobot, you the bomb!

[HezkoreParticipant]

I tried the “dev” branch of both Monkey 2 and Ted2Go now and the colour is STILL wrong. :/

[nerobotParticipant]

Hm. Looked like mystic.

I will try to understand this situation a bit later, ok? Probably, there is needed core monkey fixes.

[HezkoreParticipant]

It seems the error isn’t specifically linked to the IDE!
I’ve been experimenting and it looks like ALL my colours in Monkey 2 are wrong.

Here I’m drawing 3 rectangles, the 2 at the top should be blue-ish but are green when drawn.
The bottom one should be very different from the 2 at the top, but they look exactly the same when I draw them.

Monkey

#Import "<std>" #Import "<mojo>" Using std.. Using mojo.. Class MyWindow Extends Window Method OnRender( canvas:Canvas ) Override 'Blue via HEX canvas.Color=GetHexColor("#282C34") canvas.DrawRect(0,0,256,256) 'Blue via RGB canvas.Color=New Color(40.0/255.0,44.0/255.0,52.0/255.0) canvas.DrawRect(256,0,256,256) 'Green via HEX canvas.Color=GetHexColor("#223333") canvas.DrawRect(0,256,256,256) End End Function Main() New AppInstance New MyWindow App.Run() End 'Taken from Mojo's theme loader Function GetHexColor:Color(str:String) Local a:=1.0,r:=0.0,g:=0.0,b:=0.0 If str.StartsWith("#") If str.Length=4 '#RGB r=StringToULong( str.Slice( 1,2 ),16 )/15.0 g=StringToULong( str.Slice( 2,3 ),16 )/15.0 b=StringToULong( str.Slice( 3,4 ),16 )/15.0 Else If str.Length=5 '#ARGB a=StringToULong( str.Slice( 1,2 ),16 )/15.0 r=StringToULong( str.Slice( 2,3 ),16 )/15.0 g=StringToULong( str.Slice( 3,4 ),16 )/15.0 b=StringToULong( str.Slice( 4,5 ),16 )/15.0 Else If str.Length=7 '#RRGGBB r=StringToULong( str.Slice( 1,3 ),16 )/255.0 g=StringToULong( str.Slice( 3,5 ),16 )/255.0 b=StringToULong( str.Slice( 5,7 ),16 )/255.0 Else If str.Length=9 '#AARRGGBB a=StringToULong( str.Slice( 1,3 ),16 )/255.0 r=StringToULong( str.Slice( 3,5 ),16 )/255.0 g=StringToULong( str.Slice( 5,7 ),16 )/255.0 b=StringToULong( str.Slice( 7,9 ),16 )/255.0 Else Return Color.Magenta Endif Else Return Color.Magenta Endif Return New Color( r,g,b,a ) End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59

#Import "<std>" #Import "<mojo>"   Using std.. Using mojo..   Class MyWindow Extends Window Method OnRender( canvas:Canvas ) Override 'Blue via HEX canvas.Color=GetHexColor("#282C34") canvas.DrawRect(0,0,256,256) 'Blue via RGB canvas.Color=New Color(40.0/255.0,44.0/255.0,52.0/255.0) canvas.DrawRect(256,0,256,256) 'Green via HEX canvas.Color=GetHexColor("#223333") canvas.DrawRect(0,256,256,256) End End   Function Main() New AppInstance New MyWindow App.Run() End   'Taken from Mojo's theme loader Function GetHexColor:Color(str:String) Local a:=1.0,r:=0.0,g:=0.0,b:=0.0 If str.StartsWith("#") If str.Length=4 '#RGB r=StringToULong( str.Slice( 1,2 ),16 )/15.0 g=StringToULong( str.Slice( 2,3 ),16 )/15.0 b=StringToULong( str.Slice( 3,4 ),16 )/15.0 Else If str.Length=5 '#ARGB a=StringToULong( str.Slice( 1,2 ),16 )/15.0 r=StringToULong( str.Slice( 2,3 ),16 )/15.0 g=StringToULong( str.Slice( 3,4 ),16 )/15.0 b=StringToULong( str.Slice( 4,5 ),16 )/15.0 Else If str.Length=7 '#RRGGBB r=StringToULong( str.Slice( 1,3 ),16 )/255.0 g=StringToULong( str.Slice( 3,5 ),16 )/255.0 b=StringToULong( str.Slice( 5,7 ),16 )/255.0 Else If str.Length=9 '#AARRGGBB a=StringToULong( str.Slice( 1,3 ),16 )/255.0 r=StringToULong( str.Slice( 3,5 ),16 )/255.0 g=StringToULong( str.Slice( 5,7 ),16 )/255.0 b=StringToULong( str.Slice( 7,9 ),16 )/255.0 Else Return Color.Magenta Endif Else Return Color.Magenta Endif Return New Color( r,g,b,a ) End

That is for Windows.
But if I compile for Emscripten the result is correct!

I’ve started a separate thread for this, hoping Mark will see it!
On another note, is there any way to increase the distance between lines in the text view gadget?

[HezkoreParticipant]

@nerobot
I’ve added a toggle option for the Toolbar.
In mainwindow.monkey2 add this to the view menu creation:

Monkey

'View menu ' _themesMenu=CreateThemesMenu( "Themes..." ) _viewMenu=New Menu( "View" ) AddToggleActions( _viewMenu ) _viewMenu.AddSeparator() AddZoomActions( _viewMenu ) _viewMenu.AddSeparator() _viewMenu.AddSubMenu( _themesMenu )

1 2 3 4 5 6 7 8 9 10

'View menu ' _themesMenu=CreateThemesMenu( "Themes..." ) _viewMenu=New Menu( "View" ) AddToggleActions( _viewMenu ) _viewMenu.AddSeparator() AddZoomActions( _viewMenu ) _viewMenu.AddSeparator() _viewMenu.AddSubMenu( _themesMenu )

And here’s the new AddToggleActions function, add anywhere (I recommend above AddZoomActions function)

Monkey

Method AddToggleActions( menu:Menu ) menu.AddAction( "Toggle Toolbar" ).Triggered=Lambda() Self._toolBar.Visible = Not Self._toolBar.Visible End End

1 2 3 4 5

Method AddToggleActions( menu:Menu ) menu.AddAction( "Toggle Toolbar" ).Triggered=Lambda() Self._toolBar.Visible = Not Self._toolBar.Visible End End

I couldn’t figure out how to hide the code toolbar menu though, I’d like a toggle option for that too.

[nerobotParticipant]

For code toolbar – look into  codedocument.monkey2 -> CodeDocunent class -> New() method.

There is a code at the end of New():

Monkey

' bar + editor Local docker:=New DockingView docker.AddView( bar,"top" ) docker.ContentView=_codeView

1 2 3 4

' bar + editor Local docker:=New DockingView docker.AddView( bar,"top" ) docker.ContentView=_codeView

as a simplest solution just comment line

Monkey

docker.AddView( bar,"top" )

1	docker.AddView( bar,"top" )

later I’ll add show/hide options into menu.

[HezkoreParticipant]

Yeah I had a look at that.
But I couldn’t find a way to access “docker” after the New() method, and I want to Toggle it like the Toolbar.

[nerobotParticipant]

Steps to do are:

1. Replace local bar variable with field _toolBar
2. Add property ToolBarVisible:Bool
3. In mainwindow for toogle logic add method ToggleCodeToolBar()

Monkey

' Field _barVisible:Bool property ToolBarVisible:Bool() return _barVisible setter(value:Bool) _barVisible=value _toolBar.Visible=_barVisible end

1 2 3 4 5 6 7 8

' Field _barVisible:Bool property ToolBarVisible:Bool()   return _barVisible setter(value:Bool)   _barVisible=value   _toolBar.Visible=_barVisible end

Monkey

' in mainwindow method ToggleCodeToolBar() local docs:=_docsManager.getAll<CodeDocument>() 'any way to get all docs here for doc = eachin docs doc.ToolBarVisible=not doc.ToolBarVisible endif end

1 2 3 4 5 6 7

' in mainwindow method ToggleCodeToolBar()   local docs:=_docsManager.getAll<CodeDocument>() 'any way to get all docs here   for doc = eachin docs     doc.ToolBarVisible=not doc.ToolBarVisible   endif end

I wrote this code inside of browser to show you my direction. So need to be fixed of course.

[nerobotParticipant]

There are many bugs and weak spots in current version. I can’t wait I have spare time to fix them.

[HezkoreParticipant]

Yeah the search window is driving me crazy heh.
If I paste something in there it doesn’t work, if I open it and hit enter it clears the field etc.
But overall it’s a great improvement! So well done.
I can add a toggle option for the code toolbar, I know how, I just wasn’t sure how much of your code you wanted me to alter.
I was hoping you’d use my code I posted above in your next release hehe.

[Author]

Posts