[Mark SiblyKeymaster]

My work here is done…

[Mark SiblyKeymaster]

Excellent, the shaders are looking really great too!

I have long wanted to add some kind of ‘full screen 2d shader effect’ API to the mojo view system, but have been reluctant to do this as I’d be more or less ‘guessing’ how people wanted to use it (like 90% of what I do I guess) and it would likely end up cumbersome and nasty.

But seeing what people are actually wanting to do with shaders and how they want to use them is enormously useful and will hopefully make for some interesting mojo additions one of these days!

[Mark SiblyKeymaster]

 

What can I run/test that’s crashing?

Recent shader changes shouldn’t be affecting existing code.

[Mark SiblyKeymaster]

That’s the web site I linked!

That’ll teach me to skim read before coffee at 7.00 am…

And the wchar stuff isn’t all that complex to implement, you just need to be really careful of 2 huge C bogey-men – buffer over-runs and memory leaks!

[Mark SiblyKeymaster]

“just convert to/from WCHAR” only at the point where the Win32 API requires it

This is the basic idea but it’s not trivial!

I should have it mostly done now though – just pushed to develop branch so feel free to check it out.

There is also a minor chance that I’ve borked something in the process, as this stuff is used in lots of places. Ted2go is a pretty good test of libc/filesystem stuff and that seems to be going OK but still…use with caution.

Also found this in the process:

http://utf8everywhere.org/

A pretty good read on all the issues, and I agree with about 97% of it I think…

[Mark SiblyKeymaster]

What is String type under the hood? Is it utf-8 string?

No, it’s an internal custom 16 bit per char format.

Is it ok that LoadString/SaveString using CString instead of WString?

CString means ‘utf-8’ encoded null terminated string, so yes. WString is not really technically supported yet.

I tried to use russian letters for window title and I got abrakadabra when app started.

But if I load the same letters from file – everything is OK.

Not really sure what you mean here. Please post some sample code if you want me to look at something! This is especially important if international characters are involved as randomly copying and pasting stuff from google in an attempt to try to duplicate problems like this can only get me so far.

To clarify a bit on the whole windows+utf mess: The problem is typically with API calls where you have to pass a filename or something ‘visible’ (eg: window title) to an OS function.

All OS’s except windows accept utf-8 cstrings (ie: monkey2 CStrings) for filenames etc which are (conveniently, by design) backward compatible with plain ascii, and are fully handled by monkey2. When a monkey2 string is converted to a CString all information retained as its in utf-8 encoding.

However, windows requires you to use entirely different APIS if you want to use filenames etc that aren’t plain 7 bit ascii. Monkey2 doesn’t use such APIs yet, so non-ascii chars in filenames etc will cause problems, as monkey2 will still convert to utf-8 cstrings (which are still valid c strings, windows just doesn’t know how to deal with them properly).

These different APIs uses yet another string type – a WSTRING – which is very close to what monkey2 currently uses internally (although that could change) but needs to be null terminated etc. Note that there is also a c++ std::wstring which is similar to WSTRING but only on some targets. Fun stuff.

[Mark SiblyKeymaster]

I already include Assets the whole directory?

You need to prefix file name with “asset::” when you load it, eg: Image.Load( “asset::32x32sheet.png” ).

For texture flags, always use TextureFlags.Dynamic for an image you’re updating frequently (I added some of these I think).

Monkey

Namespace Myapp #Import "<std>" #Import "<mojo>" #Import "<mojo3d>" #Import "assets/" Using std.. Using mojo.. Const w:=800, h:=600 Class Myapp Extends Window Field canvas:Canvas Field icanvas:Canvas Field scanvas:Canvas Field image:Image Field sourceImage:Image Field targetImage:Image Field size:Int=16 ' try 8 16 32 64 Field cx:Int Field wx:Int Field wy:Int Field tilemap:=New Int[512*512] Field s:Int = 4 Method New() Super.New("Myapp", w, h, WindowFlags.Resizable) For Local y:=0 To 511 For Local x:=0 To 511 tilemap[x + y * 512] = Int(Rnd(127)) Next Next sourceImage=Image.Load( "asset::32x32sheet.png",Null,Null ) targetImage=New Image( sourceImage.Width,sourceImage.Height,PixelFormat.RGBA8,TextureFlags.Dynamic ) image=New Image( 512,512,PixelFormat.RGBA8,TextureFlags.Dynamic ) icanvas=New Canvas(image) scanvas=New Canvas(targetImage) ' canvas=New Canvas() NOT NEEDED IN MONKEY2 ' image.Texture.Flags &=~ TextureFlags.FilterMipmap End ' --------------------------------------------------------------------------------------- Method OnRender( canvas:Canvas ) Override App.RequestRender() ' canvas.Alpha=1.0 scanvas.Clear(Color.Black) ' INSTEAD OF SHADER (just copies sourceImage to targetImage) scanvas.DrawImage(sourceImage,0,0) ' INSTEAD OF SHADER (just copies sourceImage to targetImage) scanvas.Flush() ' INSTEAD OF SHADER (just copies sourceImage to targetImage) ' Init canvas & image 'canvas.Viewport(0,0,w,h) 'canvas.Scissor(0,0,w,h) 'canvas.Projection2d(0,w,0,h) canvas.Clear(Color.None) 'icanvas.Viewport(0,0,w,h) 'icanvas.Scissor(0,0,w,h) 'icanvas.Projection2d(0,w,0,h) icanvas.Clear(Color.None) ' Draw to image ' Scroll (by drawing onto itself) icanvas.Clear(Color.Black) icanvas.DrawImage(sourceImage,0,0) icanvas.DrawImage(targetImage,256,256) cx=(cx+2) Mod 512 For Local temp:=0 To 127 icanvas.DrawRect(64+temp,0,1,64,targetImage,0+temp+cx,0,1,64) Next ' Plots something in the tiles (shows how to draw something to an image *after* shader have been applied) For Local temp:=1 To 16 If Int(Rnd(1)) Then icanvas.Color = Color.Black Else icanvas.Color = Color.White Local xx:= Int(Rnd(7)) Local yy:= Int(Rnd(7)) icanvas.DrawRect(xx*4,yy*4,2*4,2*4) Next icanvas.Flush() ' Finished drawing ' Draw to canvas ' Cookiecut 32x32 tiles from a 512x512 tilesheet and draw as tiles of any size Local scrx:=wx Mod size Local scry:=wy Mod size Local mapx:=wx / size Local mapy:=wy / size Local cnty:= -scry For Local y:=mapy To mapy+((h/size)+1) Local cntx:=-scrx For Local x:=mapx To mapx+((w/size)+1) Local char:= tilemap[x + y * 512] Local tilex:= char & 15 Local tiley:= char Shr 4 canvas.DrawRect(cntx,cnty,size,size,image,tilex Shl 5,tiley Shl 5,32,32) cntx=cntx+size Next cnty=cnty+size Next canvas.Flush() ' Finished drawing If Keyboard.KeyReleased(Key.Escape) Then App.Terminate() End Method End Function Main() New AppInstance New Myapp App.Run() End Function

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105

Namespace Myapp #Import "<std>" #Import "<mojo>" #Import "<mojo3d>" #Import "assets/" Using std.. Using mojo.. Const w:=800, h:=600   Class Myapp Extends Window   Field canvas:Canvas Field icanvas:Canvas Field scanvas:Canvas Field image:Image Field sourceImage:Image Field targetImage:Image Field size:Int=16 ' try 8 16 32 64 Field cx:Int Field wx:Int Field wy:Int Field tilemap:=New Int[512*512] Field s:Int = 4 Method New() Super.New("Myapp", w, h, WindowFlags.Resizable) For Local y:=0 To 511 For Local x:=0 To 511 tilemap[x + y * 512] = Int(Rnd(127)) Next Next sourceImage=Image.Load( "asset::32x32sheet.png",Null,Null ) targetImage=New Image( sourceImage.Width,sourceImage.Height,PixelFormat.RGBA8,TextureFlags.Dynamic ) image=New Image( 512,512,PixelFormat.RGBA8,TextureFlags.Dynamic ) icanvas=New Canvas(image) scanvas=New Canvas(targetImage) ' canvas=New Canvas() NOT NEEDED IN MONKEY2 ' image.Texture.Flags &=~ TextureFlags.FilterMipmap End   ' ---------------------------------------------------------------------------------------   Method OnRender( canvas:Canvas ) Override App.RequestRender() ' canvas.Alpha=1.0 scanvas.Clear(Color.Black) ' INSTEAD OF SHADER (just copies sourceImage to targetImage) scanvas.DrawImage(sourceImage,0,0) ' INSTEAD OF SHADER (just copies sourceImage to targetImage) scanvas.Flush() ' INSTEAD OF SHADER (just copies sourceImage to targetImage)   ' Init canvas & image 'canvas.Viewport(0,0,w,h) 'canvas.Scissor(0,0,w,h) 'canvas.Projection2d(0,w,0,h) canvas.Clear(Color.None) 'icanvas.Viewport(0,0,w,h) 'icanvas.Scissor(0,0,w,h) 'icanvas.Projection2d(0,w,0,h) icanvas.Clear(Color.None)   ' Draw to image ' Scroll (by drawing onto itself) icanvas.Clear(Color.Black) icanvas.DrawImage(sourceImage,0,0) icanvas.DrawImage(targetImage,256,256) cx=(cx+2) Mod 512 For Local temp:=0 To 127 icanvas.DrawRect(64+temp,0,1,64,targetImage,0+temp+cx,0,1,64) Next ' Plots something in the tiles (shows how to draw something to an image *after* shader have been applied) For Local temp:=1 To 16 If Int(Rnd(1)) Then icanvas.Color = Color.Black Else icanvas.Color = Color.White Local xx:= Int(Rnd(7)) Local yy:= Int(Rnd(7)) icanvas.DrawRect(xx*4,yy*4,2*4,2*4) Next icanvas.Flush() ' Finished drawing ' Draw to canvas ' Cookiecut 32x32 tiles from a 512x512 tilesheet and draw as tiles of any size Local scrx:=wx Mod size Local scry:=wy Mod size Local mapx:=wx / size Local mapy:=wy / size Local cnty:= -scry For Local y:=mapy To mapy+((h/size)+1) Local cntx:=-scrx For Local x:=mapx To mapx+((w/size)+1) Local char:= tilemap[x + y * 512] Local tilex:= char & 15 Local tiley:= char Shr 4 canvas.DrawRect(cntx,cnty,size,size,image,tilex Shl 5,tiley Shl 5,32,32) cntx=cntx+size Next cnty=cnty+size Next canvas.Flush() ' Finished drawing If Keyboard.KeyReleased(Key.Escape) Then App.Terminate() End Method End Function Main() New AppInstance New Myapp App.Run() End Function

[Mark SiblyKeymaster]

Try building with debug on. You’re missing a ‘=New Int[512,512]’ and an “asset::blah.png”.

With these fixed I get a smooth scrolling sort of parallax charmap, with random chars all over the place, some sort of animated! Both monkey2 and monkeyx versions look the same to me.

[Mark SiblyKeymaster]

It could be anything  – it could be the fact that monkey2 really uses direct3d, whereas monkey-x  uses ‘pure’ opengl, it could be the way I uploaded textures to the driver, the order of API operations I use, whatever…the point is it’s invalid so don’t do it.

Drawing an image that you’ve just draw an image to is expansive in Monkey2.

If you have some runnable sample code, please post it, but nothing that uses undefined or invalid behaviour please!

[edit]You may be right, there may be some sort of issue here, but testing with invalid code is not the right way to find it.

[Mark SiblyKeymaster]

Ok, that’s pretty hard to follow, but as far as I can tell you’re trying to draw a texture onto itself, ie: you’re drawing ‘image’ to an ‘icanvas’, where icanvas has the same image as a render target. Please correct me if I’m wrong here…

Anyway, you can’t do this – it’s technically ‘undefined behaviour’ in opengl/gles/webgl and I’m surprised it works at all!

If you want to do stuff like this, you need to double buffer, ie: have 2 images/icanvses, and draw image0->icanvas1 and  image1->icanvas0 etc and flip between them.

[Mark SiblyKeymaster]

Still not quite sure what you mean here…could you try and explain the problem a bit more clearly.

I assume it’s speed related as there’s mention of snails in there, and that it’s something to do with drawing images to images but beyond that…?

Ideally, some nice simple runnable monkey2 code with a clear description of the ‘symptoms’ would be ideal!

[Mark SiblyKeymaster]

Here’s a little demo of manually drawing letterbox borders yourself.

This allows you to turn of windows clearing so there is 0 overdraw, I’m not sure it’ll be significantly faster, or even any faster at all as window clearing should be pretty fast. But it’s still nice to be able to customize letterbox borders…

If it is significantly faster, it’s probably worth adding an option similar to Window.ClearEnabled to automate it.

It uses the currently undocumented View.RenderBounds property, but it should be pretty obvious what this does, ie: it’s the view ‘bounds’  in windows coordinates. View bounds is view rect + padding + border + margin.

Monkey

Namespace myapp #Import "<std>" #Import "<mojo>" Using std.. Using mojo.. Class GameView Extends View Method New() Layout="letterbox" End Method OnRender( canvas:Canvas ) Override RequestRender() canvas.Clear( Color.Blue ) canvas.DrawText( "Hello World!",Width/2,Height/2,.5,.5 ) End Method OnMeasure:Vec2i() Override Return New Vec2i( 320,200 ) End End Class MyWindow Extends Window Method New() Super.New( "VRES test",640,480,WindowFlags.Resizable ) Local gameView:=New GameView ContentView=gameView ClearEnabled=False End Method OnRender( canvas:Canvas ) Override Local rect:=ContentView.RenderBounds canvas.Color=Color.Red 'left border? If rect.Left canvas.DrawRect( 0,0,rect.Left,Height ) 'right border? If rect.Right<Width canvas.DrawRect( rect.Right,0,Width-rect.Right,Height ) 'top border? If rect.Top canvas.DrawRect( 0,0,Width,rect.Top ) 'bottom border? If rect.Bottom<Height canvas.DrawRect( 0,rect.Bottom,Width,Height-rect.Bottom ) End End Function Main() New AppInstance New MyWindow App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76

Namespace myapp   #Import "<std>" #Import "<mojo>"   Using std.. Using mojo..   Class GameView Extends View Method New() Layout="letterbox" End Method OnRender( canvas:Canvas ) Override RequestRender() canvas.Clear( Color.Blue ) canvas.DrawText( "Hello World!",Width/2,Height/2,.5,.5 ) End Method OnMeasure:Vec2i() Override Return New Vec2i( 320,200 ) End   End     Class MyWindow Extends Window   Method New()   Super.New( "VRES test",640,480,WindowFlags.Resizable ) Local gameView:=New GameView ContentView=gameView ClearEnabled=False End Method OnRender( canvas:Canvas ) Override Local rect:=ContentView.RenderBounds   canvas.Color=Color.Red 'left border? If rect.Left canvas.DrawRect( 0,0,rect.Left,Height ) 'right border? If rect.Right<Width canvas.DrawRect( rect.Right,0,Width-rect.Right,Height ) 'top border? If rect.Top canvas.DrawRect( 0,0,Width,rect.Top ) 'bottom border? If rect.Bottom<Height canvas.DrawRect( 0,rect.Bottom,Width,Height-rect.Bottom ) End   End   Function Main()   New AppInstance New MyWindow App.Run() End

[Mark SiblyKeymaster]

Basically, the libc module (and more…) needs to be rewritten for Windows to use the ‘wide char’ versions of various OS filesystem APIs.

This is not a problem on any other OSes because they all very sensibly use utf-8 c strings for all APIs, which is backwardly compatible with old school ascii and means I can use ‘standard c’ APIs everywhere – except Windows!

It’ll happen eventually…

[Mark SiblyKeymaster]

that well-decorated site

Ha! You mean the xmas lights? They were the painstaking result of a 2 minute google image search!

I’ll see if I can’t knock something together for here…

[Mark SiblyKeymaster]

Meh, each to their own…locking this now as it’s not really achieving anything.

[Author]

Posts