[Mark SiblyKeymaster]

No problem, I was also very interested in how well my code worked as so far it’s only had a 50% success rate!

Up to 75% now so I feel a bit better…

[Mark SiblyKeymaster]

In this case I have this in my App class: App.SdlEventFilter = MySdlEventFilter , and then

This is weird because the latest code doesn’t use events at all!

Well, nearly, I still grab jevent->which for debugging, so jevent better never be NULL.

So some things to try: Remove ALL code from event handlers in joystick.monkey2. Check if other apps crash when joysticks are added/removed – maybe it’s an SDL event thing. Comment out stuff until it works. Stick some print statements around SDL calls – there shouldn’t be many of them left. You could also build a debug version and use gdb to debug it, but you’d have to tweak env_windows.txt a bit…Let me know if you want to try this.

I think the approach I’m using is good – in fact, latest SDL 2.0.7 adds a function that will make it even easier.

You could actually try latest SDL if you want, there are quite a few changes to joystick so they may have fixed something. Grab SDL 2.0.7 source from here: https://www.libsdl.org/download-2.0.php and copy the ‘include’ and ‘src’ dirs into the current sdl2/SDL dir, overwriting existing dirs (backup or whatever first!). Then, copy all the SDL_config_blah.h files from current include dir (ie: from your backup) to the new 2.0.7 include dir. Tried this yesterday and it seemed to work fine on windows, joystick and ted2go worked anyway. Much more testing to do before I can ‘officially’ upgrade sdl2 though.

After around 100 plug-unplug of two different gamepads I had no crash…

Thanks for super comprehensive test! I’ve also had SDL fail to register plugins a few times, but it never seems to cause any problems. Still, perhaps indicative of something bad going on in SDL, as I still get the ‘ping’ when it’s plugged in…but SDL misses it.

Tried with a XBox360 pad and a Pandora gamepad no crashes to report 

Thanks!

[Mark SiblyKeymaster]

(note to self: don’t edit posts by going back->edit->submit!)

[Mark SiblyKeymaster]

It should be very easy to build from source on llnux – as long as you have also installed the myriad of dev-lib dependancies required on Linux. And you’ll need these for building monkey2 apps as well as monkey2 itself, so hosting a prebuilt version on Linux is of very little value.

On Windows and Macos this stuff is easy – all required dependancies are built-in to the c++ compilers used by monkey2.

However, on Linux installing g++ is just the start, you’ll also need to install things like the dev libs for x, opengl, and a ton of other obscure stuff depedending on what actual version of linux you’re using.

I would love to make monkey2 easier to use on Linux, but making it ‘apt-gettable’ or something would be a huge undertaking for me, given my limited knowledge of the relevant linux stuff, and I just can’t justify the time/effort/pain involved as the audience for Linux seems to be tiny to non-existant?

The nice thing is that once you do have it running on Linux, it’s pretty sweet (but I would say that)!

[Mark SiblyKeymaster]

No idea –  perhaps try asking on the chipmunk forums?

https://chipmunk-physics.net/forum/viewforum.php?f=1

[Mark SiblyKeymaster]

Just using like the function above. Couldn’t think of a better way to check for “Any Key” being pressed.

You don’t need to pass rawkeys to KeyDown, you can just pass a plain ‘virtual’ key, eg: ‘Key.A’ or ‘Key.Z’ etc.

But to pass an int ‘key’ to KeyDown you’ll need to convert it to a ‘Key’ type first – in fact, this is probably all your use of ScanCodeToRawKey is really achieving here – In this case, it doesn’t really matter whether you pass virtual keys or rawkeys or banana keys to KeyDown, since you’re just throwing every possible value at it!

To convert an int to a key, you can ‘Cast<Key>( n )’ it – example below. But as people have noted there are other ways to do this too.

Monkey

Namespace myapp #Import "<std>" #Import "<mojo>" Using std.. Using mojo.. Class MyWindow Extends Window Method New( title:String="Simple mojo app",width:Int=640,height:Int=480,flags:WindowFlags=Null ) Super.New( title,width,height,flags ) End Method OnRender( canvas:Canvas ) Override App.RequestRender() canvas.DrawText( "Hello World!",Width/2,Height/2,.5,.5 ) For Local i:=0 Until 512 Local key:=Cast<Key>( i ) If Keyboard.KeyDown( key ) Print "KeyDown:"+Keyboard.KeyName( key ) End End End Function Main() New AppInstance New MyWindow App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43

Namespace myapp   #Import "<std>" #Import "<mojo>"   Using std.. Using mojo..   Class MyWindow Extends Window   Method New( title:String="Simple mojo app",width:Int=640,height:Int=480,flags:WindowFlags=Null )   Super.New( title,width,height,flags ) End   Method OnRender( canvas:Canvas ) Override App.RequestRender() canvas.DrawText( "Hello World!",Width/2,Height/2,.5,.5 )   For Local i:=0 Until 512 Local key:=Cast<Key>( i ) If Keyboard.KeyDown( key ) Print "KeyDown:"+Keyboard.KeyName( key ) End   End End   Function Main()   New AppInstance New MyWindow App.Run() End

[Mark SiblyKeymaster]

I did have a look into this andit’s doable but a bit complicated to make ‘nice’.

Just to clarify though, are you only wanting to apply a shader to a bunch of shapes? This is easier…

[Mark SiblyKeymaster]

ScanCodeToRawKey is an internal function – it has been @hidden from docs, and should therefore be considered ‘use art your own risk’.

I’ve had to make it public in the past as monkey2 lacked an ‘Internal’ directive, ie: decls are visible to other module members only. But that has recently been added to monkey so I have made several methods/functions Internal.

What are you actually using it for?

[Mark SiblyKeymaster]

Hmm, can’t find an Image.Window, do you perhaps mean Pixmap.Window?

It might have been more consistent if I’d used Image.Window, but the idea was for New Image( image,rect…) etc. to create a ‘window’ into an atlas that shares the same ‘material’ (ie: texture) as the atlas, thus minimizing renderstate changes.

But I messed up here, and each image created with New Image( image,rect… ) actually ended up with a new ‘material’ too, which caused a renderstate change for each DrawImage. Pretty easily fixed, although there’a a minor chance it may affect some existing code out there – will deal with that if/when it happens.

[Mark SiblyKeymaster]

Yay, decided to do my own bunnymark based on ethernaut’s and found a pretty major issue in mojo!

You’re supposed to be able to use images as atlases in mojo, and New Image( image,x,y,w,h ) is supposed to ‘grab’ a frame from an atlas.

This works BUT currently also creates a new material for the frame instead of just sharing the same material as the atlas – so my version was initially slower than ethernaut’s by a large margin! Fixing this so that all images created from other images ‘share’ the same material gives a considerable speed up – was getting about 50K images @60hz with ethernaut’s version, now get about 180K with mine!

Will push this change to the repos soon.

My bunnymark (works but will be slow with current mx2):

Monkey

Namespace bunnies #Import "assets/wabbit_alpha.png" #Import "<std>" #Import "<mojo>" Using std.. Using mojo.. Const initialCount := 10000 Function Main() New AppInstance New Bunnymark App.Run() End Function '****************************************************************************************************** Class Bunnymark Extends Window Global atlas:Image Global frames:=New Image[4] Field bunnies := New Stack<Bunny> Method New() Super.New("Bunnymark", 1024, 768, WindowFlags.Resizable ) atlas=Image.Load( "asset::wabbit_alpha.png" ) For Local j:=0 Until 2 For Local i:=0 Until 2 frames[ j*2+i ]=New Image( atlas,i*32,i*64,32,64 ) Next Next For Local n := 0 Until initialCount bunnies.Push( New Bunny( 512, 384,frames[ Rnd(4) ] ) ) Next End Method OnRender( canvas:Canvas ) Override App.RequestRender() If Keyboard.KeyReleased(Key.Escape) Then App.Terminate() canvas.Color = Color.White canvas.DrawRect( 0, 0, App.ActiveWindow.Width , 25 ) For Local bunny:=Eachin bunnies bunny.Update( canvas ) Next canvas.Color = Color.Black canvas.DrawText("The Bunnymark ( " + bunnies.Length + " )",10,5) canvas.DrawText(" FPS: " + App.FPS, 250, 5 ) canvas.DrawText(" Left mouse = +10, middle = +100, right = +1000 (hold alt key to remove) ", 450, 5 ) End Method OnMouseEvent( event:MouseEvent ) Override If event.Type = EventType.MouseDown Local _len := 0 If event.Button = MouseButton.Left _len = 10 Elseif event.Button = MouseButton.Middle _len = 100 Elseif event.Button = MouseButton.Right _len = 1000 End If Keyboard.KeyDown( Key.LeftAlt ) Or Keyboard.KeyDown( Key.RightAlt ) For Local n := 1 To _len If bunnies.Length Then bunnies.Pop() Next Else For Local n := 1 To _len bunnies.Push( New Bunny( Mouse.X, Mouse.Y,frames[ Rnd(4) ] ) ) Next End End End End '****************************************************************************************************** Class Bunny Global gravity := 0.1 Global border := 32.0 Field x: Float Field y: Float Field xspeed: Float Field yspeed: Float Field maxBounce:= 5.0 Field image:Image Method New( x:Float,y:Float,image:Image ) Self.x = x Self.y = y xspeed = Rnd( -10, 10 ) Self.image=image End Method Update:Void( canvas:Canvas ) yspeed += gravity y += yspeed x += xspeed If y < border*2 y = border*2 yspeed *= -1 yspeed = Clamp( yspeed, 0.0, Float( maxBounce ) ) End If y > App.ActiveWindow.Height - border y = App.ActiveWindow.Height - border yspeed = -random.Rnd( maxBounce * 3 ) End If( x < border ) Or ( x > App.ActiveWindow.Width - border ) xspeed *= -1 x = Clamp( x, border, Float(App.ActiveWindow.Width - border ) ) End canvas.DrawImage( image,x,y ) End End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144

Namespace bunnies   #Import "assets/wabbit_alpha.png"   #Import "<std>" #Import "<mojo>"   Using std.. Using mojo..   Const initialCount := 10000   Function Main() New AppInstance New Bunnymark App.Run() End Function   '******************************************************************************************************   Class Bunnymark Extends Window Global atlas:Image Global frames:=New Image[4] Field bunnies := New Stack<Bunny> Method New() Super.New("Bunnymark", 1024, 768, WindowFlags.Resizable ) atlas=Image.Load( "asset::wabbit_alpha.png" ) For Local j:=0 Until 2 For Local i:=0 Until 2 frames[ j*2+i ]=New Image( atlas,i*32,i*64,32,64 ) Next Next For Local n := 0 Until initialCount bunnies.Push( New Bunny( 512, 384,frames[ Rnd(4) ] ) ) Next End Method OnRender( canvas:Canvas ) Override App.RequestRender() If Keyboard.KeyReleased(Key.Escape) Then App.Terminate() canvas.Color = Color.White canvas.DrawRect( 0, 0, App.ActiveWindow.Width , 25 ) For Local bunny:=Eachin bunnies bunny.Update( canvas ) Next canvas.Color = Color.Black canvas.DrawText("The Bunnymark ( " + bunnies.Length + " )",10,5) canvas.DrawText(" FPS: " + App.FPS, 250, 5 ) canvas.DrawText(" Left mouse = +10, middle = +100, right = +1000  (hold alt key to remove) ", 450, 5 )   End Method OnMouseEvent( event:MouseEvent ) Override   If event.Type = EventType.MouseDown Local _len := 0   If event.Button = MouseButton.Left _len = 10 Elseif event.Button = MouseButton.Middle _len = 100 Elseif event.Button = MouseButton.Right _len = 1000 End   If Keyboard.KeyDown( Key.LeftAlt ) Or Keyboard.KeyDown( Key.RightAlt ) For Local n := 1 To _len If bunnies.Length Then bunnies.Pop() Next Else For Local n := 1 To _len bunnies.Push( New Bunny( Mouse.X, Mouse.Y,frames[ Rnd(4) ] ) ) Next End End End   End     '******************************************************************************************************     Class Bunny Global gravity := 0.1 Global border := 32.0 Field x: Float Field y: Float Field xspeed: Float Field yspeed: Float Field maxBounce:= 5.0   Field image:Image Method New( x:Float,y:Float,image:Image ) Self.x = x Self.y = y xspeed = Rnd( -10, 10 ) Self.image=image End Method Update:Void( canvas:Canvas ) yspeed += gravity   y += yspeed x += xspeed If y < border*2 y = border*2 yspeed *= -1 yspeed = Clamp( yspeed, 0.0, Float( maxBounce ) ) End If y > App.ActiveWindow.Height - border y = App.ActiveWindow.Height - border yspeed = -random.Rnd( maxBounce * 3 ) End If( x < border ) Or ( x > App.ActiveWindow.Width - border ) xspeed *= -1 x = Clamp( x, border, Float(App.ActiveWindow.Width - border ) ) End canvas.DrawImage( image,x,y ) End End

[Mark SiblyKeymaster]

I have never had any reports of a ‘true’ positive so I’m 99.999% sure you’re OK.

[Mark SiblyKeymaster]

Should be possible, I will look into it.

[Mark SiblyKeymaster]

But how does user ‘know’ they are using an extension and it’s safe to skip ‘?.’?

If there’s a possiblility an object could be Null, coder should always use ?. or check for null IMO, regardless of whether  member is an extension or not. Extensions should behave as much like ‘normal’ methods as possible.

Making a special case for extensions just complicates the language more. My current thinking anyway…

[Mark SiblyKeymaster]

Self can be null inside of extension.

I never really considered this, not sure if I like it or not!

[edit] Don’t think I do like it, esp now there’s ‘?.’ – please don’t depend on it in future.

[Mark SiblyKeymaster]

Yes, this issue has been in there for ages and I should probably get round to doing something about it one of these days, just not quite sure what exactly!

[Author]

Posts