[therevillsParticipant]

Thanks Abakobo!

Note that Image and Pixmap (extends Ressource) are not GCed so you you have to .Discard() them before replacing/loosing them or you’ll leak memory. But as the are not GCed Mark won’t tell it’s not safe to point to them!?

Hmmm, I thought I read Mark had changed the GC…

Edit:
On Mark’s Blog:

This means it’s not strictly necessary to use Discard to cleanup resources any more, GC will eventually do it for you. GCCollect() is still slow so Discard is recommended in realtime situations, but on the whole it should be possible to write apps without worrying about using Discard at all now.

Monkey2 v1.1.05 now available!

[therevillsParticipant]

Thanks Peter – I was wondering if you found a bug or something and decided on removing it.

Really like how you implemented the component functionality.

[therevillsParticipant]

Okay bench marking is done

Debug Timing

Monkey

OriginalVersion = 381ms OriginalVersion = 381002μs AbakoboVersion = 382ms AbakoboVersion = 382499μs impixiVersion = 5ms impixiVersion = 5000μs NewVersion = 2ms NewVersion = 2499μs

1 2 3 4 5 6 7 8 9 10

OriginalVersion  = 381ms OriginalVersion  = 381002μs AbakoboVersion   = 382ms AbakoboVersion   = 382499μs impixiVersion    = 5ms impixiVersion    = 5000μs NewVersion       = 2ms NewVersion       = 2499μs

Release Timing

Monkey

OriginalVersion = 20ms OriginalVersion = 20000μs AbakoboVersion = 18ms AbakoboVersion = 18022μs impixiVersion = 1ms impixiVersion = 501μs NewVersion = 0ms NewVersion = 499μs

1 2 3 4 5 6 7 8 9 10

OriginalVersion  = 20ms OriginalVersion  = 20000μs AbakoboVersion   = 18ms AbakoboVersion   = 18022μs impixiVersion    = 1ms impixiVersion    = 501μs NewVersion       = 0ms NewVersion       = 499μs

And here is the full code:

Monkey

Namespace myapp #Import "<std>" #Import "<mojo>" #Import "assets/" Using std.. Using mojo.. Const Size:=New Vec2i( 320,200 ) Class MyWindow Extends Window Field tileSet:Image[] Field tileSetMask:Int[,,] Field tileSetClass:TileSet Field tileSetClass2:TileSet2 Method New() Super.New( "My Window",1024,768,WindowFlags.Resizable ) Window.ClearColor = Color.Black Layout="letterbox" tileSet = LoadSpriteSheet("tileset.png", 32, 16, 16) tileSetMask = New Int[32, 16, 16] Local s := Millisecs() Local n := Microsecs() OriginalVersion() Print "OriginalVersion = " +(Millisecs()-s) Print "OriginalVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() AbakoboVersion() Print "AbakoboVersion = " +(Millisecs()-s) Print "AbakoboVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass = New TileSet("asset::tileset.png", 16, 16) Print "impixiVersion = " +(Millisecs()-s) Print "impixiVersion = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass2 = New TileSet2("tileset.png", 32, 16, 16) Print "NewVersion = " +(Millisecs()-s) Print "NewVersion = " +(Microsecs()-n) End Method OnRender( canvas:Canvas ) Override canvas.TextureFilteringEnabled = False App.RequestRender() canvas.DrawImage(tileSetClass.imgAtlas, 0, 0) canvas.DrawImage(tileSetClass.imgAtlasMask, tileSetClass.imgAtlas.Width, 0) Local drawTileIndex:Int = 29 For Local y := 0 To 16 - 1 For Local x := 0 To 16 - 1 If drawTileIndex > - 1 If tileSetClass2.tileSetMask[drawTileIndex, x, y] > 0 canvas.Color = Color.Orange canvas.DrawRect(x + 150 , y + 150, 1, 1) canvas.Color = Color.White End End End End End Method OnMeasure:Vec2i() Override Return Size End Method AbakoboVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pixPtr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End Method OriginalVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) For Local y := 0 To px.Height - 1 For Local x := 0 To px.Width - 1 Local color:Color = px.GetPixel(x, y) If color.A > 0 tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End End Class TileSet Public Method New(url:String, tileWidth:Int, tileHeight:Int) Local pmAtlas := Pixmap.Load(url, PixelFormat.Unknown) If Not pmAtlas Then RuntimeError("Could not load spritesheet: " + url) Local tileCount := (pmAtlas.Width / tileWidth) * (pmAtlas.Height / tileHeight) Local pmAtlasMask := New Pixmap(pmAtlas.Width, pmAtlas.Height, PixelFormat.I8) Local pmAtlasDataPtr:UByte Ptr = pmAtlas.Data + Cast<UByte>(pmAtlas.Depth - 1) Local pmAtlasMaskDataPtr:UByte Ptr = pmAtlasMask.Data + Cast<UByte>(pmAtlasMask.Depth - 1) Local pidx:ULong = 0 While pidx < (pmAtlas.Width * pmAtlas.Height) If pmAtlasDataPtr[0] > 0 pmAtlasMaskDataPtr[0] = 255 Else pmAtlasMaskDataPtr[0] = 0 Endif pmAtlasDataPtr += Cast<UByte>(pmAtlas.Depth) pmAtlasMaskDataPtr += Cast<UByte>(pmAtlasMask.Depth) pidx += 1 Wend imgAtlas = Image.Load(url) imgAtlasMask = New Image(pmAtlasMask) pmAtlas.Discard() End Field imgAtlas:Image Field imgAtlasMask:Image End Class TileSet2 Field tileSetMask:Int[,,] Field tileSet:Image[] Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) For Local k := 0 To cellHeight - 1 For Local j := 0 To cellWidth - 1 Local color:Color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If color.A > 0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End Next atlasImg = Null tileSet = imgs End End Function LoadSpriteSheet:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::") Local atlasTexture := Texture.Load(prefix + path, Null ) Assert( atlasTexture, " ~n ~nGameGraphics: Image " + path + " not found.~n ~n" ) Local imgs := New Image[ numFrames ] Local atlasImg := New Image( atlasTexture ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) Next atlasImg = Null Return imgs End Function Main() New AppInstance New MyWindow App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234

Namespace myapp   #Import "<std>" #Import "<mojo>" #Import "assets/"   Using std.. Using mojo..   Const Size:=New Vec2i( 320,200 )   Class MyWindow Extends Window Field tileSet:Image[] Field tileSetMask:Int[,,] Field tileSetClass:TileSet Field tileSetClass2:TileSet2 Method New() Super.New( "My Window",1024,768,WindowFlags.Resizable ) Window.ClearColor = Color.Black Layout="letterbox" tileSet = LoadSpriteSheet("tileset.png", 32, 16, 16) tileSetMask = New Int[32, 16, 16] Local s := Millisecs() Local n := Microsecs() OriginalVersion() Print "OriginalVersion  = " +(Millisecs()-s) Print "OriginalVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() AbakoboVersion() Print "AbakoboVersion = " +(Millisecs()-s) Print "AbakoboVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass = New TileSet("asset::tileset.png", 16, 16) Print "impixiVersion   = " +(Millisecs()-s) Print "impixiVersion  = " +(Microsecs()-n) s = Millisecs() n = Microsecs() tileSetClass2 = New TileSet2("tileset.png", 32, 16, 16) Print "NewVersion    = " +(Millisecs()-s) Print "NewVersion  = " +(Microsecs()-n) End   Method OnRender( canvas:Canvas ) Override canvas.TextureFilteringEnabled = False App.RequestRender() canvas.DrawImage(tileSetClass.imgAtlas, 0, 0) canvas.DrawImage(tileSetClass.imgAtlasMask, tileSetClass.imgAtlas.Width, 0) Local drawTileIndex:Int = 29 For Local y := 0 To 16 - 1 For Local x := 0 To 16 - 1 If drawTileIndex > - 1 If tileSetClass2.tileSetMask[drawTileIndex, x, y] > 0 canvas.Color = Color.Orange canvas.DrawRect(x + 150 , y + 150, 1, 1) canvas.Color = Color.White End End End End End Method OnMeasure:Vec2i() Override Return Size End Method AbakoboVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) Local pixPtr:UInt Ptr 'to declare only once so i's not created each time in the loop (more usefull with structs (like Color) or classes or arrays intanciation... 'RGBA8(per channel) is the default pixel format but can be different. 4*8=32bit long thus UInt For Local y := 0 To px.Height - 1 pixPtr=Cast<UInt Ptr>( px.PixelPtr( 0,y ) ) For Local x := 0 To px.Width - 1 If pixPtr[x]&$FF000000>0 'Bitwise opertor to check if there is some alpha (8 leftside bits of RGBA32(read ABGR! Endianess?) thus &$FF000000 to clear the BGR 24 bits. (is there a problem with the pixel format documentation? or is it reading small from big?) tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End Method OriginalVersion() For Local i:Int = 0 Until tileSet.Length Local tmpCanvas := New Canvas(tileSet[i]) Local px := tmpCanvas.CopyPixmap(tmpCanvas.Viewport) For Local y := 0 To px.Height - 1 For Local x := 0 To px.Width - 1 Local color:Color = px.GetPixel(x, y) If color.A > 0 tileSetMask[i, x, y] = 1 Else tileSetMask[i, x, y] = 0 End End End Next End End   Class TileSet Public Method New(url:String, tileWidth:Int, tileHeight:Int) Local pmAtlas := Pixmap.Load(url, PixelFormat.Unknown) If Not pmAtlas Then RuntimeError("Could not load spritesheet: " + url) Local tileCount := (pmAtlas.Width / tileWidth) * (pmAtlas.Height / tileHeight) Local pmAtlasMask := New Pixmap(pmAtlas.Width, pmAtlas.Height, PixelFormat.I8) Local pmAtlasDataPtr:UByte Ptr = pmAtlas.Data + Cast<UByte>(pmAtlas.Depth - 1) Local pmAtlasMaskDataPtr:UByte Ptr = pmAtlasMask.Data + Cast<UByte>(pmAtlasMask.Depth - 1) Local pidx:ULong = 0 While pidx < (pmAtlas.Width * pmAtlas.Height) If pmAtlasDataPtr[0] > 0 pmAtlasMaskDataPtr[0] = 255 Else pmAtlasMaskDataPtr[0] = 0 Endif pmAtlasDataPtr += Cast<UByte>(pmAtlas.Depth) pmAtlasMaskDataPtr += Cast<UByte>(pmAtlasMask.Depth) pidx += 1 Wend imgAtlas = Image.Load(url) imgAtlasMask = New Image(pmAtlasMask) pmAtlas.Discard() End Field imgAtlas:Image Field imgAtlasMask:Image   End   Class TileSet2 Field tileSetMask:Int[,,] Field tileSet:Image[]   Method New(path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::", format:PixelFormat = PixelFormat.Unknown) Local pixmap := Pixmap.Load(prefix + path, format ) Assert( pixmap, " ~n ~nGameGraphics: Pixmap " + path + " not found.~n ~n" ) tileSetMask = New Int[numFrames, cellWidth, cellHeight] Local imgs := New Image[ numFrames ] Local atlasImg := New Image( pixmap ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) For Local k := 0 To cellHeight - 1 For Local j := 0 To cellWidth - 1 Local color:Color = pixmap.GetPixel(x + j, y + k) 'Print "i = " + i + " j = " + j + " k = " + k If color.A > 0 tileSetMask[i, j, k] = 1 Else tileSetMask[i, j, k] = 0 End End End Next atlasImg = Null tileSet = imgs End End   Function LoadSpriteSheet:Image[] (path:String, numFrames:Int, cellWidth:Int, cellHeight:Int, filter:Bool = True, preScale:Float = 1.0, padding:Int = 0, border:Int = 0, prefix:String = "asset::") Local atlasTexture := Texture.Load(prefix + path, Null ) Assert( atlasTexture, " ~n ~nGameGraphics: Image " + path + " not found.~n ~n" ) Local imgs := New Image[ numFrames ] Local atlasImg := New Image( atlasTexture ) Local paddedWidth := cellWidth + ( padding * 2 ) Local paddedHeight := cellHeight + ( padding * 2 ) Local columns:Int = ( atlasImg.Width - border - border ) / paddedWidth For Local i := 0 Until numFrames Local col := i Mod columns Local x := ( col * paddedWidth ) + padding + border Local y := ( ( i / columns ) * paddedHeight ) + padding + border imgs[i] = New Image( atlasImg, New Recti( x , y, x + cellWidth, y + cellHeight ) ) imgs[i].Scale = New Vec2f( preScale, preScale ) Next atlasImg = Null Return imgs End   Function Main() New AppInstance New MyWindow App.Run() End

[therevillsParticipant]

Thanks guys! I’ll run some bench marking to see what is faster, I was considering of doing it “offline” too by creating a simple app which reads in the pixel data and spit it out to a JSON file.

@scurty

Not sure why you’re creating a canvas and then copying the viewport pixmap of it.

To allow me to read the pixel data from an Image, do you know another way?

[therevillsParticipant]

I thought AC stood for Android Code, but it looks like it stands for Application Control.

“AC Back” (the Back key (application control keypad))

https://wiki.libsdl.org/SDL_ScancodeAndKeycode

Thanks for fixing this.

[therevillsParticipant]

Nope you put in the right place…

Damn, KeyHit calls KeyPressed which calls ScanCode… and ScanCode checks Key.Max

I tried an Extension and sub classing the KeyboardDevice class both failed due to it uses a lot of private variables so it complains. I think we need Mark to make a change to get it to work – sorry.

I’ll raise a GitHub ticket and point to this thread. Could you change title of this thread please (edit your first post) as its a Monkey2 issue than a Diddy2 issue

Raised: https://github.com/blitz-research/monkey2/issues/293

[therevillsParticipant]

I’ve copied some of the monkey keyboard code and found the scan values for AC_BACK:

Monkey

name = AC Back scanCode = 270 keyCode = 1073742094

1 2 3 4 5

name     = AC Back scanCode = 270 keyCode  = 1073742094

So Amon could you please add this code your project:

Monkey

Method KeyCodeToKey:Key( keyCode:Int ) ' copied from keyboard.monkey2 If (keyCode & $40000000) keyCode=(keyCode & ~$40000000)+$80 ' If keyCode<=0 Or keyCode>=Int( Key.Max ) Return Null ' removed as back key goes beyond Key.Max Return Cast<Key>( keyCode ) End

1 2 3 4 5 6 7

Method KeyCodeToKey:Key( keyCode:Int ) ' copied from keyboard.monkey2 If (keyCode & $40000000) keyCode=(keyCode & ~$40000000)+$80 ' If keyCode<=0 Or keyCode>=Int( Key.Max ) Return Null ' removed as back key goes beyond Key.Max Return Cast<Key>( keyCode ) End

Then when you want to hit the back key:

Monkey

Local backKey:=KeyCodeToKey( 1073742094 ) If Keyboard.KeyHit(backKey) Print "BACK!" End

1 2 3 4 5 6

Local backKey:=KeyCodeToKey( 1073742094 ) If Keyboard.KeyHit(backKey) Print "BACK!" End

I havent tested this so this may or may NOT work!

[therevillsParticipant]

In the native keyinfo.cpp within Mojo, Mark has:

Monkey

"AC Back",SDL_SCANCODE_AC_BACK,SDLK_AC_BACK,

1	"AC Back",SDL_SCANCODE_AC_BACK,SDLK_AC_BACK,

KeyInfo is used in keyboard.monkey2:

Monkey

Extern Private Struct bbKeyInfo Field name:Void Ptr Field scanCode:Int Field keyCode:Int End Global bbKeyInfos:bbKeyInfo Ptr

1 2 3 4 5 6 7 8 9 10

Extern Private   Struct bbKeyInfo Field name:Void Ptr Field scanCode:Int Field keyCode:Int End   Global bbKeyInfos:bbKeyInfo Ptr

…

Monkey

Class KeyboardDevice ... Method Init() Local p:=bbKeyInfos While p->name Local name:=String.FromCString( p->name ) Local scanCode:=p->scanCode Local keyCode:=p->keyCode Local key:=KeyCodeToKey( keyCode ) _names[key]=name _raw2scan[key]=scanCode _scan2raw[scanCode]=key | Key.Raw #If __TARGET__="emscripten" _key2scan[key]=scanCode #Else _key2scan[key]=SDL_GetScancodeFromKey( Cast<SDL_Keycode>( keyCode ) ) #Endif _scan2key[_key2scan[key]]=key p=p+1 Wend End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30

Class KeyboardDevice ... Method Init() Local p:=bbKeyInfos While p->name Local name:=String.FromCString( p->name ) Local scanCode:=p->scanCode Local keyCode:=p->keyCode Local key:=KeyCodeToKey( keyCode ) _names[key]=name _raw2scan[key]=scanCode _scan2raw[scanCode]=key | Key.Raw #If __TARGET__="emscripten" _key2scan[key]=scanCode #Else _key2scan[key]=SDL_GetScancodeFromKey( Cast<SDL_Keycode>( keyCode ) ) #Endif _scan2key[_key2scan[key]]=key p=p+1 Wend   End

In SDL_keycode.h

Monkey

enum { ... SDLK_AC_BACK = SDL_SCANCODE_TO_KEYCODE(SDL_SCANCODE_AC_BACK),

1 2 3 4 5 6

enum { ...     SDLK_AC_BACK = SDL_SCANCODE_TO_KEYCODE(SDL_SCANCODE_AC_BACK),

And SDL_keyboard.c

Monkey

static const SDL_Keycode SDL_default_keymap[SDL_NUM_SCANCODES] = { ... SDLK_AC_BACK

1 2 3 4 5

static const SDL_Keycode SDL_default_keymap[SDL_NUM_SCANCODES] = { ... SDLK_AC_BACK

So we may be able to use it somehow…

[therevillsParticipant]

No idea sorry! Havent actually done any Android development in Monkey2 yet…

I’ll investigate, unless you or anyone else knows!

Edit: Quick Google in pure SDL2 C++:

Monkey

if (event.type == SDL_KEYDOWN) if (event.key.keysym.sym == SDLK_AC_BACK )

1 2	if (event.type == SDL_KEYDOWN) if (event.key.keysym.sym == SDLK_AC_BACK )

[therevillsParticipant]

Cool!

I dont know if its in MX2 yet, but for Windows we need a way to save to the “correct” Microsoft approved folder locations.

[therevillsParticipant]

Cool! MIT is fine with me

[therevillsParticipant]

Very nice! Also didnt know that Monkey2 could play videos! Thanks!

[therevillsParticipant]

Ah thanks Jesse! Yeah that makes sense!

[therevillsParticipant]

@pixelpaladin – did you see my post just before yours?

[therevillsParticipant]

@pixelpaladin – I cant get your code to work. When I try to compile I get:

Monkey

Error : Can't find overload for 'new:Void(monkey.types.String,monkey.types.String,monkey.types.String)' with argument types (monkey.types.String,monkey.types.String)

1 2	Error : Can't find overload for 'new:Void(monkey.types.String,monkey.types.String,monkey.types.String)' with argument types (monkey.types.String,monkey.types.String)

So I changed this line:

Monkey

crtShader = New Shader("crtshader", CRT_ShaderCode)

1	crtShader = New Shader("crtshader", CRT_ShaderCode)

to

Monkey

crtShader = New Shader("crtshader", CRT_ShaderCode, "")

1	crtShader = New Shader("crtshader", CRT_ShaderCode, "")

So it now compiles but crashes at runtime:

Monkey

Attempt to invoke method on null instance

1	Attempt to invoke method on null instance

Full code:

Monkey

Namespace crt #Import "<std>" #Import "<mojo>" #import "assets/tvscreen.png" Using std.. Using mojo.. Class GraphicsCRT Field crtCanvas:Canvas Field crtImage:Image Field crtShader:Shader Field resolution:Vec2i Global Instance:GraphicsCRT = Null Field overlayImg:Image Method New(width:UInt = 320, height:UInt = 240, rgbSplitIntensity:Float = 0.5, scanlineIntensity:Float = 0.1) If Instance <> Null Then RuntimeError("only one crt graphics instance is allowed") Instance = Self If width < 128 Then width = 128 If width > 800 Then width = 800 If height < 64 Then height = 64 If height > 600 Then height = 600 If rgbSplitIntensity < 0.0 Then rgbSplitIntensity = 0.0 If rgbSplitIntensity > 1.0 Then rgbSplitIntensity = 1.0 resolution = New Vec2i(width, height) Local CRT_ShaderCode:String 'CRT_ShaderCode = LoadString("asset::crt.txt") CRT_ShaderCode = "~n//@renderpasses 0,1,2~n~nvarying vec2 texCoord0;~nvarying vec4 color;~n~n//@vertex~n~nattribute vec4 mx2_Vertex;~nattribute vec2 mx2_TexCoord0;~nattribute vec4 mx2_Color;~n~nuniform mat4 mx2_ModelViewProjectionMatrix;~n~nuniform vec4 mx2_ImageColor;~n~nvoid main(){~n~n~ttexCoord0=mx2_TexCoord0;~n~n~tcolor=mx2_ImageColor * mx2_Color;~n~t~n~tgl_Position=mx2_ModelViewProjectionMatrix * mx2_Vertex;~n}~n~n//@fragment~n~nuniform sampler2D mx2_ImageTexture0;~n~nvoid main(){~n~n#if MX2_RENDERPASS==0~n~tvec2 texcoords = texCoord0;~n~tfloat bl = %BORDER_LEVEL%*0.1;~n~tfloat x = texcoords.x*(1.0+bl)-bl/2.0;~n~tfloat y = texcoords.y*(1.0+bl)-bl/2.0;~n~tfloat x2 = (x-0.5)*(1.0+ 0.5*%EFFECT_LEVEL% *((y-0.5)*(y-0.5)))+0.5;~n~tfloat y2 = (y-0.5)*(1.0+ 0.25*%EFFECT_LEVEL% *((x-0.5)*(x-0.5)))+0.5;~n~tvec2 v2 = vec2(x2, y2);~n~tvec4 temp = texture2D(mx2_ImageTexture0, v2);~n~tif (v2.x<0.0 || v2.x>1.0 || v2.y<0.0 || v2.y>1.0) {~n~t~ttemp = vec4(0.0,0.0,0.0,1.0);~n~t}else{~n~t~tfloat cr = sin((x2*%WIDTH%) *2.0*3.1415) * 0.5+0.5+0.1; //if(cr < 0.0) cr = 0.0;~n~t~tfloat cg = sin((x2*%WIDTH%-1.0*2.0*3.1415)*2.0*3.1415) * 0.5+0.5+0.1; //if(cg < 0.0) cg = 0.0;~n~t~tfloat cb = sin((x2*%WIDTH%-2.0*2.0*3.1415)*2.0*3.1415) * 0.5+0.5+0.1; //if(cg < 0.0) cg = 0.0;~n~t~ttemp = mix(temp*vec4(cr,cg,cb,1.0),temp,1.0-%RGB_SPLIT_INTENSITY%);~n~t~tif (%HEIGHT% <= 320.0) {~n~t~t~tfloat ck = sin((y2*%HEIGHT%) *2.0*3.1415) * 0.5+0.5+0.1;~n~t~t~ttemp = temp*(1.0-%SCANLINE_INTENSITY%) + temp*ck*%SCANLINE_INTENSITY%;~n~t~t}~n~t}~n~tgl_FragColor = (temp * color)*0.875+0.125;~n#else~n~tfloat alpha=texture2D( mx2_ImageTexture0,texCoord0 ).a * color.a;~n~tgl_FragColor=vec4( 0.0,0.0,0.0,alpha );~n#endif~n}~n" CRT_ShaderCode = CRT_ShaderCode.Replace("%WIDTH%", String(Int(resolution.x)+".0")) CRT_ShaderCode = CRT_ShaderCode.Replace("%HEIGHT%", String(Int(resolution.y)+".0")) CRT_ShaderCode = CRT_ShaderCode.Replace("%EFFECT_LEVEL%", "0.3")'0.5 CRT_ShaderCode = CRT_ShaderCode.Replace("%BORDER_LEVEL%", "0.3") Local sint:String = scanlineIntensity If Not sint.Contains(".") Then sint += ".0" CRT_ShaderCode = CRT_ShaderCode.Replace("%SCANLINE_INTENSITY%", sint) Local si:String = rgbSplitIntensity If Not si.Contains(".") Then si += ".0" CRT_ShaderCode = CRT_ShaderCode.Replace("%RGB_SPLIT_INTENSITY%", si) crtShader = New Shader("crtshader", CRT_ShaderCode, "") crtImage = New Image(resolution.x, resolution.y, TextureFlags.Dynamic, crtShader) crtCanvas = New Canvas(crtImage) overlayImg = Image.Load("asset::tvscreen.png") End Property Canvas:Canvas() Return crtCanvas End Property Resolution:Vec2i() Return resolution End Method DrawScreen:Void(targetCanvas:Canvas, x:Float, y:Float, width:Float, height:Float) crtCanvas.Flush() If targetCanvas = Null Then Return targetCanvas.DrawRect(x, y, width, height, crtImage) Local tempColor := targetCanvas.Color targetCanvas.Color = Color.White targetCanvas.DrawRect(x, y, width, height, overlayImg) targetCanvas.Color = tempColor End End Class AppWindow Extends Window Field crt:GraphicsCRT Field testImage:Image Method New(title:String, width:Int, height:Int) 'Call super class constructor - this just passes the arguments 'up' to the Window class constructor. Super.New(title, width, height, WindowFlags.Resizable) ' initialize crt screen (width, heightn, rgb-split-intensity) crt = New GraphicsCRT(320, 240, 0.75) Layout = "resize" ClearColor = New Color(0.0, 0.2, 0.4) Style.BackgroundColor = Color.Black SwapInterval = 1 End Method OnRender(canvas:Canvas) Override If Keyboard.KeyReleased(Key.Escape) Then App.Terminate() App.RequestRender() ' get crt canvas: Local crtCanvas:Canvas = crt.Canvas ' render some stuff on crt screen: crtCanvas.Clear(Color.Black) crtCanvas.BlendMode = BlendMode.Alpha crtCanvas.Color = Color.White crtCanvas.DrawText("Move Mouse", 5, 5) crtCanvas.BlendMode = BlendMode.Additive crtCanvas.Color = New Color(Float(Mouse.X)/Width, Float(Mouse.Y)/Height, 0.0) crtCanvas.DrawCircle(Float(Width-Mouse.X)*Float(crt.Resolution.x)/Width, Float(Height-Mouse.Y)*Float(crt.Resolution.y)/Height, 50) crtCanvas.Color = New Color(1.0-Float(Mouse.X)/Width, 1.0-Float(Mouse.Y)/Height, 1.0) crtCanvas.DrawCircle(Mouse.X*crt.Resolution.x/Width, Mouse.Y*crt.Resolution.y/Height, 50) ' draw crt screen on canvas: crt.DrawScreen(canvas, 0, 0, Width, Height) End End Function Main() New AppInstance New AppWindow("Test Application", App.DesktopSize.x/2 ,App.DesktopSize.y/2) App.Run() End

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121

Namespace crt   #Import "<std>" #Import "<mojo>"   #import "assets/tvscreen.png"   Using std.. Using mojo..   Class GraphicsCRT Field crtCanvas:Canvas Field crtImage:Image Field crtShader:Shader Field resolution:Vec2i Global Instance:GraphicsCRT = Null Field overlayImg:Image Method New(width:UInt = 320, height:UInt = 240, rgbSplitIntensity:Float = 0.5, scanlineIntensity:Float = 0.1) If Instance <> Null Then RuntimeError("only one crt graphics instance is allowed") Instance = Self If width < 128 Then width = 128 If width > 800 Then width = 800 If height < 64 Then height = 64 If height > 600 Then height = 600 If rgbSplitIntensity < 0.0 Then rgbSplitIntensity = 0.0 If rgbSplitIntensity > 1.0 Then rgbSplitIntensity = 1.0 resolution = New Vec2i(width, height) Local CRT_ShaderCode:String 'CRT_ShaderCode = LoadString("asset::crt.txt") CRT_ShaderCode = "~n//@renderpasses 0,1,2~n~nvarying vec2 texCoord0;~nvarying vec4 color;~n~n//@vertex~n~nattribute vec4 mx2_Vertex;~nattribute vec2 mx2_TexCoord0;~nattribute vec4 mx2_Color;~n~nuniform mat4 mx2_ModelViewProjectionMatrix;~n~nuniform vec4 mx2_ImageColor;~n~nvoid main(){~n~n~ttexCoord0=mx2_TexCoord0;~n~n~tcolor=mx2_ImageColor * mx2_Color;~n~t~n~tgl_Position=mx2_ModelViewProjectionMatrix * mx2_Vertex;~n}~n~n//@fragment~n~nuniform sampler2D mx2_ImageTexture0;~n~nvoid main(){~n~n#if MX2_RENDERPASS==0~n~tvec2 texcoords = texCoord0;~n~tfloat bl = %BORDER_LEVEL%*0.1;~n~tfloat x = texcoords.x*(1.0+bl)-bl/2.0;~n~tfloat y = texcoords.y*(1.0+bl)-bl/2.0;~n~tfloat x2 = (x-0.5)*(1.0+  0.5*%EFFECT_LEVEL%  *((y-0.5)*(y-0.5)))+0.5;~n~tfloat y2 = (y-0.5)*(1.0+  0.25*%EFFECT_LEVEL%  *((x-0.5)*(x-0.5)))+0.5;~n~tvec2 v2 = vec2(x2, y2);~n~tvec4 temp = texture2D(mx2_ImageTexture0, v2);~n~tif (v2.x<0.0 || v2.x>1.0 || v2.y<0.0 || v2.y>1.0) {~n~t~ttemp = vec4(0.0,0.0,0.0,1.0);~n~t}else{~n~t~tfloat cr = sin((x2*%WIDTH%)            *2.0*3.1415) * 0.5+0.5+0.1;   //if(cr < 0.0) cr = 0.0;~n~t~tfloat cg = sin((x2*%WIDTH%-1.0*2.0*3.1415)*2.0*3.1415) * 0.5+0.5+0.1;   //if(cg < 0.0) cg = 0.0;~n~t~tfloat cb = sin((x2*%WIDTH%-2.0*2.0*3.1415)*2.0*3.1415) * 0.5+0.5+0.1;   //if(cg < 0.0) cg = 0.0;~n~t~ttemp = mix(temp*vec4(cr,cg,cb,1.0),temp,1.0-%RGB_SPLIT_INTENSITY%);~n~t~tif (%HEIGHT% <= 320.0) {~n~t~t~tfloat ck = sin((y2*%HEIGHT%)               *2.0*3.1415) * 0.5+0.5+0.1;~n~t~t~ttemp = temp*(1.0-%SCANLINE_INTENSITY%) + temp*ck*%SCANLINE_INTENSITY%;~n~t~t}~n~t}~n~tgl_FragColor = (temp * color)*0.875+0.125;~n#else~n~tfloat alpha=texture2D( mx2_ImageTexture0,texCoord0 ).a * color.a;~n~tgl_FragColor=vec4( 0.0,0.0,0.0,alpha );~n#endif~n}~n" CRT_ShaderCode = CRT_ShaderCode.Replace("%WIDTH%", String(Int(resolution.x)+".0")) CRT_ShaderCode = CRT_ShaderCode.Replace("%HEIGHT%", String(Int(resolution.y)+".0")) CRT_ShaderCode = CRT_ShaderCode.Replace("%EFFECT_LEVEL%", "0.3")'0.5 CRT_ShaderCode = CRT_ShaderCode.Replace("%BORDER_LEVEL%", "0.3") Local sint:String = scanlineIntensity If Not sint.Contains(".") Then sint += ".0" CRT_ShaderCode = CRT_ShaderCode.Replace("%SCANLINE_INTENSITY%", sint) Local si:String = rgbSplitIntensity If Not si.Contains(".") Then si += ".0" CRT_ShaderCode = CRT_ShaderCode.Replace("%RGB_SPLIT_INTENSITY%", si) crtShader = New Shader("crtshader", CRT_ShaderCode, "") crtImage = New Image(resolution.x, resolution.y, TextureFlags.Dynamic, crtShader) crtCanvas = New Canvas(crtImage) overlayImg = Image.Load("asset::tvscreen.png") End Property Canvas:Canvas() Return crtCanvas End Property Resolution:Vec2i() Return resolution End Method DrawScreen:Void(targetCanvas:Canvas, x:Float, y:Float, width:Float, height:Float) crtCanvas.Flush() If targetCanvas = Null Then Return targetCanvas.DrawRect(x, y, width, height, crtImage) Local tempColor := targetCanvas.Color targetCanvas.Color = Color.White targetCanvas.DrawRect(x, y, width, height, overlayImg) targetCanvas.Color = tempColor End End       Class AppWindow Extends Window Field crt:GraphicsCRT Field testImage:Image Method New(title:String, width:Int, height:Int) 'Call super class constructor - this just passes the arguments 'up' to the Window class constructor. Super.New(title, width, height, WindowFlags.Resizable) ' initialize crt screen (width, heightn, rgb-split-intensity) crt = New GraphicsCRT(320, 240, 0.75) Layout = "resize" ClearColor = New Color(0.0, 0.2, 0.4) Style.BackgroundColor = Color.Black SwapInterval = 1 End Method OnRender(canvas:Canvas) Override If Keyboard.KeyReleased(Key.Escape) Then App.Terminate() App.RequestRender() ' get crt canvas: Local crtCanvas:Canvas = crt.Canvas ' render some stuff on crt screen: crtCanvas.Clear(Color.Black) crtCanvas.BlendMode = BlendMode.Alpha crtCanvas.Color = Color.White crtCanvas.DrawText("Move Mouse", 5, 5) crtCanvas.BlendMode = BlendMode.Additive crtCanvas.Color = New Color(Float(Mouse.X)/Width, Float(Mouse.Y)/Height, 0.0) crtCanvas.DrawCircle(Float(Width-Mouse.X)*Float(crt.Resolution.x)/Width, Float(Height-Mouse.Y)*Float(crt.Resolution.y)/Height, 50) crtCanvas.Color = New Color(1.0-Float(Mouse.X)/Width, 1.0-Float(Mouse.Y)/Height, 1.0) crtCanvas.DrawCircle(Mouse.X*crt.Resolution.x/Width, Mouse.Y*crt.Resolution.y/Height, 50) ' draw crt screen on canvas: crt.DrawScreen(canvas, 0, 0, Width, Height) End End Function Main() New AppInstance New AppWindow("Test Application", App.DesktopSize.x/2 ,App.DesktopSize.y/2) App.Run() End

[Author]

Posts